Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2572486iog; Sun, 19 Jun 2022 23:01:10 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tQy85bzEzKTRJPCm/JMUZGzuf7ylsnX3X6+EkmNJUIoV+tw66MOrfdR7pm9iatc7xhxeSO X-Received: by 2002:a05:6402:f8d:b0:435:6df2:68a with SMTP id eh13-20020a0564020f8d00b004356df2068amr13061293edb.209.1655704870469; Sun, 19 Jun 2022 23:01:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655704870; cv=none; d=google.com; s=arc-20160816; b=GnQ5AyB17xFN141N3Ehl8VsKd+EkZDIa9nIEyGbxG6xxZUxxKbd1VJTsXiVXoMIb0f jD/pfoUS4V4yrPd3P1zKM6VeTidHJnt8QN/4Y3UxytwP9+5O7iurecGAwc3v04aoFK3U NlLDcHj9Ut1XdTdQubTc4ThOONR9I1NohatqE3FwSiRrVvVAXpKTZ4GCcFDHvZMUxNra CNaG5FrECuEQMI9wItM+aT6X9eDzR4DwXxPBwFzdtxrf0EMt54Kx6LxwzEUIk0a4nERQ 1ytL8oGpEp4DinCBC6Cabzv/s1qt09YsKzm6VDPLS4punBzYNEijRo4qjrcKfwYkgikw 2Gfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=9EOYYx+p+RkPqrNIib5wPOSg2AyVrOrZK8ANlVZ/2C0=; b=zZ++Nmic5NbMakOBrbxHVxlnsxnYP8ym3NG6MF7B0urZfX4cuw8HmVYj8zR8kjQOnJ te+DC6+QhjY7ZKGUoDC0HU3kudgOR7Hxn7z499JkorOBiUTJylZ3ow5QBTboaoXyWvDD 41M467KHcikG2mzfjOMwDPC94DMl0QP7Rk/t41oSZJQwPUZuoCPsk1fJAVP508dEjgnK 61X5R2CA3GxiHlqX2jT3EAapghv6u4K0AvyiAethDGTx92bceen6hGa+W8W3PPBkXWdz zug7molp7ltsn9IAM526WEae8uy6FKd6RCsnpolKOlW67WMhBcnwQq19oinJDtzXZY1p YeoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Sd9h/Ixs"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z1-20020a056402274100b0042ad03b5aacsi13624481edd.5.2022.06.19.23.00.45; Sun, 19 Jun 2022 23:01:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="Sd9h/Ixs"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238341AbiFTF7Q (ORCPT + 99 others); Mon, 20 Jun 2022 01:59:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238399AbiFTF7P (ORCPT ); Mon, 20 Jun 2022 01:59:15 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59315DFB4; Sun, 19 Jun 2022 22:59:14 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id k7so8814550plg.7; Sun, 19 Jun 2022 22:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9EOYYx+p+RkPqrNIib5wPOSg2AyVrOrZK8ANlVZ/2C0=; b=Sd9h/IxsghHxFtpRXyO2j23oep6jTeY+ddHz8f4QSTM8ND9/3XbxUbbJALbA2lw9xL haE6vxGnUwsLOCdyJoKetcwNsK6RQlyuPVA477gFFw+CrTUkNtUI2znIqE6O4c3yaOsA Jjhj+mOldDeb8YVdOK3YvfNnXvadl2i8u00OqRtKRc0BEWPqm7HKq8UfXWih6ro/DHKR leoebCQJRCpN21odrBHY0J52k5OL0/2sUVTBuRWDmUzpW8so7TGO4KeLqkEPdNNaB8b/ ovsN5iZEXzRC9XA5HIz6Wc5a9NayCUuq6rnztSa6r5/mGyMr/YHT+FbxwjS7mQ+QUkel RBEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9EOYYx+p+RkPqrNIib5wPOSg2AyVrOrZK8ANlVZ/2C0=; b=4/MglQra9dpfQR4fTVbeaeTkSaOLdzRf6QMPk69lsQ5wRuhtguWw7fEKwuprpczMY+ 5Tjx2AM84nGcR2atAMcJPFWXIR620krLtOzdO3IIjfChvUSE6jUKPWC1r8s9sHxq2wQY 1hZdLPaEHWKjKSV9cQ8IPE3SmDQRJW6bZ6toM7A1+Gz+OjytaXgy0J6uF5KOuO8ydawQ KFbNIft+5+yQoni+MPAmT2ltmsUf69pnd9dD6pQ4nx1nCdLQLkM/s0v6rxIn/wiYJOqq 42KxfDeFNMXr8yXPgOFlor8LgqX7sHvUmhwJEzPIPStuYWJ59EMpn3hFSH23qqAKwhAZ xyCQ== X-Gm-Message-State: AJIora8fO9L2RB+Hwwob4w4IdvKTjm0SS26DyDVXVaKwe5C22a5Ivnh9 ruhY6AH1BDkH+MhgmHN6VOzB9MqzCQ8= X-Received: by 2002:a17:903:1c2:b0:163:ef7b:e10f with SMTP id e2-20020a17090301c200b00163ef7be10fmr21847526plh.158.1655704749223; Sun, 19 Jun 2022 22:59:09 -0700 (PDT) Received: from localhost ([2406:7400:63:5d34:e6c2:4c64:12ae:aa11]) by smtp.gmail.com with ESMTPSA id l4-20020a170903120400b001678ce9080dsm7724191plh.258.2022.06.19.22.58.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jun 2022 22:59:08 -0700 (PDT) From: Ritesh Harjani To: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Jan Kara , Alexander Viro , Ritesh Harjani Subject: [RFC 0/3] submit_bh: Drop unnecessary return values and API users Date: Mon, 20 Jun 2022 11:28:39 +0530 Message-Id: X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org submit_bh/submit_bh_wbc are non-blocking functions which just submits the bio and returns. The caller of submit_bh/submit_bh_wbc needs to wait on buffer till I/O completion and then check buffer head's b_state field to know if there was any I/O error. Hence there is no need for these functions to have any return type. Even now they always returns 0. Hence drop the return value and make their return type as void to avoid any confusion. Ritesh Harjani (3): jbd2: Drop useless return value of submit_bh fs/buffer: Drop useless return value of submit_bh fs/buffer: Make submit_bh & submit_bh_wbc return type as void fs/buffer.c | 19 ++++++++----------- fs/jbd2/commit.c | 11 +++++------ fs/jbd2/journal.c | 6 ++---- include/linux/buffer_head.h | 2 +- 4 files changed, 16 insertions(+), 22 deletions(-) -- 2.35.3