Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2592629iog; Sun, 19 Jun 2022 23:41:45 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s6IujZOFr0uJUGBVr+M2PbOkjU/plzJ47TF+ZbbHMevklf70SBWw12Ws7vce7WKzodo5AM X-Received: by 2002:a17:906:72d4:b0:712:1fa8:a685 with SMTP id m20-20020a17090672d400b007121fa8a685mr19006895ejl.709.1655707305485; Sun, 19 Jun 2022 23:41:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655707305; cv=none; d=google.com; s=arc-20160816; b=VSDFCb6+bWW6QnglUpmj6BD4+D/KUYmDF1ufcHL9SiEQ9+LM7gWVPw0oe6m9q47fjr egzaeSML+NUPnQMaXSdoQ2L4deIk+C2+6hyQiG8OsLgwRaKMRinBskirxfB+tdylmTR3 8YCb4M/a6i71evaWViMCHNQwHzEGkw0mShv5FrXhaCtCUvSaf4tb05CaEOSeuOJYbPjX ujG8T/hwaLYFATNsM0XvcPG01CZhjnnryd+xbISsngK4ECsieqdeauBp8r0axKEZ7+9P EhPUjAUNeFddktytRSbqBaCVGAAe06O3PQJxmCqKYDoJXHY1g96qVomQ+OY7Gzuq7koE kO5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=AaV9zsbAcToZWU93ArUl8ifsbd8pf8pNoJuicLCD97Y=; b=B0Sy8a7sGrKRNzHl7WnWJqdDupowiosva1lN2lQ7HSXvqFD9jRePBVDzHBBid7XEwM O65jacUCbc/5ajFkFC4F/K+bCqPy59yy3yyRYeBY0xsP9TThp4wa/Ir/k3GbPm/JNFaa ughI/h6VL/CmFkMJxeexJHyZQfUXijGnQ1vzirGqC6XXpzBl6vZ7uQXH5nDk3VC4abVr x7zpZjaNNoSlMF2/yPEd6gHlFvL1xzjb5lhqI0+LYayw93mOsPq4eS9bc4B0h2s+uFO2 Gtwhw/jQtGYN6rCmxiAsxgyceESl5qaznUG07zIWvkGjI78xvAmyUhFvCVmvNq2OS/wl +p1g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=CdMxhUWE; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e13-20020a170906648d00b0070513399532si9733796ejm.165.2022.06.19.23.41.16; Sun, 19 Jun 2022 23:41:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=CdMxhUWE; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238683AbiFTGji (ORCPT + 99 others); Mon, 20 Jun 2022 02:39:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230121AbiFTGji (ORCPT ); Mon, 20 Jun 2022 02:39:38 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06C75DEE0; Sun, 19 Jun 2022 23:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AaV9zsbAcToZWU93ArUl8ifsbd8pf8pNoJuicLCD97Y=; b=CdMxhUWELXIkD1RJMV8bL+5S2h 8Y3lpSzD2TIYolAU49Jy+g8lne7sNpMgq+C9DSIqdbYrdg/BtEulIm39OrvooUDfTRW9tWJT4Logb 17cv5ZfMNB72VlUSXIRtDFxI6jdq0tr4TYONeKVVgepqRA6gqjKbw8ccOpHVEP3PgOXJCyhyxzPhv 1jZvEZe2IyGUz2tMJFF/LAWvOMl9nBc9WUyUaxmbHaVkNJfeHUyDpjjdxTi5myl9v/Es1RyuZBqn2 912Ru/dyY1JWkEdYncKagYWnEJvy11aEZKD8mDIk/4JtxeocOR5+qmjaos5H8c0f7igze7UEy8YaT 3f6h+l3g==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3B4T-00GSNg-Ij; Mon, 20 Jun 2022 06:39:37 +0000 Date: Sun, 19 Jun 2022 23:39:37 -0700 From: Christoph Hellwig To: Ritesh Harjani Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jan Kara , Alexander Viro Subject: Re: [RFC 2/3] fs/buffer: Drop useless return value of submit_bh Message-ID: References: <77274d2a2030f6ee06901496f9c5fbe8779127a3.1655703467.git.ritesh.list@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77274d2a2030f6ee06901496f9c5fbe8779127a3.1655703467.git.ritesh.list@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jun 20, 2022 at 11:28:41AM +0530, Ritesh Harjani wrote: > submit_bh always returns 0. This patch drops the useless return value of > submit_bh from __sync_dirty_buffer(). Once all of submit_bh callers are > cleaned up, we can make it's return type as void. Looks good: Reviewed-by: Christoph Hellwig