Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp2592630iog; Sun, 19 Jun 2022 23:41:45 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vRyHNKg7tfnFAx/KWfHZ2P0I7DLJ4y45GTEle5t9EVjabP+v22nTUWltUPyzbySVge9Dxr X-Received: by 2002:a17:907:7e91:b0:721:9b87:7095 with SMTP id qb17-20020a1709077e9100b007219b877095mr8510052ejc.564.1655707305471; Sun, 19 Jun 2022 23:41:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655707305; cv=none; d=google.com; s=arc-20160816; b=Zt80+8Tcgh/BI8vOpeUmv0qt9bWRJLDce7q8fHIPjr9zV0Di5/7+yl2dtjdHOCqiA+ npsMJPw4ilgxxhWq2GABfcCpLDdJb2Fu7yEqseatwl3lGeV/OhNsM9zRgNHvBT2H7GQU jCHS1Fhgdio/jvb8AYWkp2tBoYoV5PBE3S/3CE9vM49fYVt2G5enafFVG1Yf4HKlgsvc uINNFEDINzx/6/DRJm7KqwFhLpS6JaGItpM6QFgyZvv49cT/upoA2ovGtzoWPFrGk9Ce JJCRVH2dVKn85nrpVwvMuPw1YSSCcku9824UuoOozO7YbJNLcAUhzulCm6k7Cfhk3tBT U9fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PL1Y7gAb9eOoJ8JMhqnLNDt8qQnWB+FdJ+JxX+JXHSM=; b=HDhkVQpF0oElgTMYDI/4pqmALlw01hqXYhGXQx0Vj67oD5Fb+bM0SMuub76BfaLFmx n0fAl1uUP32J2Js+YymPgYDYM+NHqGwUYdwSAljQY3pJ64lUkKkYMc5i4xHsK+CazMJi L0WwTwOHfuyvQRpOqUN5asGHHoLki+5jvpm/6a1WW9uHEAfkTzVwQlC3PdtMSRNpm9kG MIeDj5c8r1vlPhFoierUbzKLbvdCrIEoFARPd8eDAPeqiWhDI7IDAny45VKy034QIj5o Q43A/VgWIQ/BFQO1Q6zea/svYeEZ6opXk/21XMyhXqIVmY9tnZFqVmZN53Qpdw/pXK8m vNXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="oMqPvA/D"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r19-20020a05640251d300b0042e0b28922asi14247515edd.7.2022.06.19.23.41.16; Sun, 19 Jun 2022 23:41:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="oMqPvA/D"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238483AbiFTGk0 (ORCPT + 99 others); Mon, 20 Jun 2022 02:40:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238194AbiFTGkZ (ORCPT ); Mon, 20 Jun 2022 02:40:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47909DEF8; Sun, 19 Jun 2022 23:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PL1Y7gAb9eOoJ8JMhqnLNDt8qQnWB+FdJ+JxX+JXHSM=; b=oMqPvA/DxDGGVRGb8TJX2AxzIC Iahb7RB1vCAdiFQTFWUujtF5oKDwdKWD1HOHdtz8rel4nJj9GXK8XXvlQUwf/iRm3iw/v5KoWQW6g JpgejTd5PBKa3JkHGofm9UZvPYWKtd7MPruq4qd+M9U40fMp3gByCn1Ulvq1C1/7oabso54qkvMxY zJwYvi1AfknOJojUykpB8hAcYVsn6o+CHezz1wMvHjasIvd7gFNvhfgFGbL6IyEKTmp7YsDJZqkUx /RlM8aY5Nx95NtwpiOEcR30p2RnokSHPaanIn3vLPdMS9uoYN2WeLuWAYrLEeg3zXfNnKdptvTUGY ueKQSmew==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1o3B5E-00GSZb-S8; Mon, 20 Jun 2022 06:40:24 +0000 Date: Sun, 19 Jun 2022 23:40:24 -0700 From: Christoph Hellwig To: Ritesh Harjani Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jan Kara , Alexander Viro Subject: Re: [RFC 3/3] fs/buffer: Make submit_bh & submit_bh_wbc return type as void Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Jun 20, 2022 at 11:28:42AM +0530, Ritesh Harjani wrote: > submit_bh/submit_bh_wbc are non-blocking functions which just submits s/submits/submit/ > the bio and returns. The caller of submit_bh/submit_bh_wbc needs to wait s/retuns/return/ Otherwise looks good: Reviewed-by: Christoph Hellwig