Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f5b9f777-85a2-9c38-17f3-0c9be1eeb867@amd.com>
Date:   Tue, 21 Jun 2022 11:08:42 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
From:   "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>
Subject: Re: [PATCH v5 01/13] mm: add zone device coherent type memory support
To:     David Hildenbrand <david@redhat.com>,
        Alistair Popple <apopple@nvidia.com>
Cc:     Felix Kuehling <felix.kuehling@amd.com>, jgg@nvidia.com,
        linux-mm@kvack.org, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        hch@lst.de, jglisse@redhat.com, willy@infradead.org,
        akpm@linux-foundation.org
References: <20220531200041.24904-1-alex.sierra@amd.com>
 <20220531200041.24904-2-alex.sierra@amd.com>
 <3ac89358-2ce0-7d0d-8b9c-8b0e5cc48945@redhat.com>
 <02ed2cb7-3ad3-8ffc-6032-04ae1853e234@amd.com>
 <7605beee-0a76-4ee9-e950-17419630f2cf@redhat.com>
 <ddcebcc1-fb0a-e565-f14d-77c9d48f2928@amd.com>
 <6aef4b7f-0ced-08cd-1f0c-50c22996aa41@redhat.com>
 <65987ab8-426d-e533-0295-069312b4f751@amd.com>
 <34e94bdb-675a-5d5c-6137-8aa1ee658d49@redhat.com>
 <87letq6wb5.fsf@nvdebian.thelocal>
 <643c44e7-48be-375b-c7ab-6a30b5ee2937@redhat.com>
Content-Language: en-US
In-Reply-To: <643c44e7-48be-375b-c7ab-6a30b5ee2937@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVp1SlF4VXVINzkrbFE0Sjd4bnU5bHp4YnRER3hML2tRWWNmWEQwY3l2QjZl?=
 =?utf-8?B?Y2hPWkxLamxPbDNLU0o4Y1N4MDVoR295dmludDgrQnYwUnpEV2RqU1NoQUx5?=
 =?utf-8?B?bmRWRWZRTEttbDNkWEVOdFJUVUNlakdTTmMzaHBZN3NXbEJTQTFiRU1aT0k5?=
 =?utf-8?B?bmZ0eEg1aUZoUzg1bWZZRnRZR292c0xNdmtwdFNvZlRRL0tPc2wyYTFiemlt?=
 =?utf-8?B?cVlaVG51MXpIQ1c4anB0SmpYTUNtdG9MVGduZG0zQy9JL1lGaUhFZ0Y5Z2hn?=
 =?utf-8?B?elFBejFNck1nMVYyZVVZSjVCcGNNbjZqZzNaMHJ3R2pVazlwRk8vcUQ3c0JG?=
 =?utf-8?B?MGhKMEk3ZEFmc2pNUWpISDZBVGsvSmtjTmdQYmZOTDV0cFllaVBFQ2wvalJH?=
 =?utf-8?B?Um9XcG1BWUl3bkt0V3BGbGpHbnhObmVtZG9JQzNYaDZpdWtjdmRiR3V0dklp?=
 =?utf-8?B?WHNRVXhpOTNrT1p0NEl4VkJvMGFLKzlqSXVOWU1PbE12YWlzbXBBVithT1NK?=
 =?utf-8?B?UWJwK2dKaFVyWHRvaFpTbk9NVkRYKy9oZHl5TVgvb3J4emFVeHlzVDc2SnY5?=
 =?utf-8?B?T05QYldTVHFsMCs4WG5hcjhubE1NSm9MTUwyQWt1UmhVNnhZUTZBaHRlN2J6?=
 =?utf-8?B?K0xNUzdEQXRUSUFGcm1XcTJVZXBjazZQRlZnU2NnclRoTjk5bTExZTBzUHhl?=
 =?utf-8?B?ZkM2UlhkN05lWGdGeUNjU2VYaTVoQU9scy9NdDBzYzNQcnVEUGhNdHRaeFE0?=
 =?utf-8?B?c1VLd1ZpV3V3NzR5UWVpcjd2ek5TcHB0OXNrWDMwYXFXMUphM1d1bEtKZFA3?=
 =?utf-8?B?QTIwTzgyMERqTEFDODg5c0JYOXJlVFVGcGhEZGo1OHRUYUQycERDcUFVWVhH?=
 =?utf-8?B?NjlkbUZkZWEwaVludlRkTUpUenR2UmlqaHp6TitmTGRJeWRHbDNZOGZyRE4y?=
 =?utf-8?B?ZWNMcGs3RjNVUXF6V2lkRkVRdzV4RlpEVUtYakxHREZjQ3NhK0JSOG01WFdp?=
 =?utf-8?B?L294OVZkVk9pbXVQOEI3c0pua2g0TCtqR29DQkMyQ2NGUGVNRi9QaHo5Wi94?=
 =?utf-8?B?SHRnNUU0S1JBTkh4MTFCa3Rsb2RIZmg4UXRkY1JtSEpabk5IOFpNNkcydFJF?=
 =?utf-8?B?Zmwwb01QUFU0NzlxZjYyTEpNakd5ZnJma0xUTS9YNXRMWHQ3TUZVNkFVTHFm?=
 =?utf-8?B?VlJNSnFEWkNCN2Yrc3pwMjJKOXJ5REhpU3B0dHg4V1FpZzlCUnpQSXJFcnAw?=
 =?utf-8?B?RFZ1clVJSmplVFlGZEFVM2tyK09CRmdiUjExS08yNDZzWFovZUM3eHoxZ2pC?=
 =?utf-8?B?VU1qWHN2b0dLMW8xQWo4Z2dsQ2dNdUxGMkdScjRzYkZDSHpZU2tUZmU2UGY5?=
 =?utf-8?B?UWtRYnUxMDJncUNrOTdET1huSkxvTE84Szk5QVpaWnRpb1BkemR3cDFCOFJ2?=
 =?utf-8?B?VU95N3pwNjJ3a3g1cnZwRGRoeS9LRHZFZnNEdzdtSmo2eGlWTnJmaHRzTW52?=
 =?utf-8?B?SzNoSDdEYStwdW1jcG9zNWV5RUdNcWVtUk8zMVVkMXVhbllrRllhUzJ3akY1?=
 =?utf-8?B?d0tRRE9KR0d4LzA4enorWGtveGh5M0lKbUhEVGVOdkN1Zy8yVm16dkRzcDFh?=
 =?utf-8?B?WGdFOWxPakhoNloyTWtra2JRUmQ3YlVBS3AwMmltM3NBZzB3aUk1NlZ2aGMx?=
 =?utf-8?B?ZGtRalNGK2I2Q1NPOGV1citiR0JiMmNwNEVUMnc3RVpPZk5LdTJjRm9NdHc3?=
 =?utf-8?B?MitEOElzWnhFTjFkbElOeUF5ZllORVl4YXVsYWJUTS84RTFmam9seEYrWE82?=
 =?utf-8?B?V2FqQzNob28vK0hpeE5tWkkvMko5OGcwUHk3UDRiTXJxSjVvUjdRTHk5MWVG?=
 =?utf-8?B?eG4yK1BJbDROcDhGREM2M0FFYTB1RTNuU2ZwSFd4VlFpc0Ura2cvT2xxZGNU?=
 =?utf-8?B?UEdQaFZwbG9BTHZqNjhVaHNjTTZrbWJXdFovRFpKUFBGL0F2V2UyV1VUc0I5?=
 =?utf-8?B?LzNodVgrRE1CN0hSdStjUWY0akVTMkdVVGcySzV4Qk1oNE1YM0RPQk1veGxN?=
 =?utf-8?B?WXJOcE1NZmlsVkVRS0hqNEFIU2pNbGYrSE15ZnJXMkl1VlpNNDdwUDVJb1Fl?=
 =?utf-8?B?ZVBQSy9TTFlGaDQrNTl4cU5mUnJzVVlMaTlSRkZpWWE4SEo3Zzh0RW9SR2wv?=
 =?utf-8?B?b2NoVkdQWmtjVXYrSDhFcnBxNE5hU1ZIc3JaYXN1elBBaTg3SkJRUzlCZmpY?=
 =?utf-8?B?RWVzNUhiT2p4dFl1Z1NyR2hscnFKVnhuank4bUM1S3RmdHRycWE3ZGU1SmZT?=
 =?utf-8?B?QlF2TGM1dFdWdThWUndnMGI0VWxuQkNTbkgwdm9Rc2c1RjgveWx2dz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e10a1933-f369-4c26-c779-08da53a05331
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2717.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2022 16:08:48.3709
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ceTAs9QiLq5Fx23MD0J+KYIKVItn6S2E9lB4QoGJMZ8NAbyDjFzx7zfX2Pi0n2oZOpfhhkrBTPfHeIfEE2+zIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6234
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org


On 6/21/2022 7:25 AM, David Hildenbrand wrote:
> On 21.06.22 13:55, Alistair Popple wrote:
>> David Hildenbrand<david@redhat.com>  writes:
>>
>>> On 21.06.22 13:25, Felix Kuehling wrote:
>>>> Am 6/17/22 um 23:19 schrieb David Hildenbrand:
>>>>> On 17.06.22 21:27, Sierra Guiza, Alejandro (Alex) wrote:
>>>>>> On 6/17/2022 12:33 PM, David Hildenbrand wrote:
>>>>>>> On 17.06.22 19:20, Sierra Guiza, Alejandro (Alex) wrote:
>>>>>>>> On 6/17/2022 4:40 AM, David Hildenbrand wrote:
>>>>>>>>> On 31.05.22 22:00, Alex Sierra wrote:
>>>>>>>>>> Device memory that is cache coherent from device and CPU point of view.
>>>>>>>>>> This is used on platforms that have an advanced system bus (like CAPI
>>>>>>>>>> or CXL). Any page of a process can be migrated to such memory. However,
>>>>>>>>>> no one should be allowed to pin such memory so that it can always be
>>>>>>>>>> evicted.
>>>>>>>>>>
>>>>>>>>>> Signed-off-by: Alex Sierra<alex.sierra@amd.com>
>>>>>>>>>> Acked-by: Felix Kuehling<Felix.Kuehling@amd.com>
>>>>>>>>>> Reviewed-by: Alistair Popple<apopple@nvidia.com>
>>>>>>>>>> [hch: rebased ontop of the refcount changes,
>>>>>>>>>>           removed is_dev_private_or_coherent_page]
>>>>>>>>>> Signed-off-by: Christoph Hellwig<hch@lst.de>
>>>>>>>>>> ---
>>>>>>>>>>      include/linux/memremap.h | 19 +++++++++++++++++++
>>>>>>>>>>      mm/memcontrol.c          |  7 ++++---
>>>>>>>>>>      mm/memory-failure.c      |  8 ++++++--
>>>>>>>>>>      mm/memremap.c            | 10 ++++++++++
>>>>>>>>>>      mm/migrate_device.c      | 16 +++++++---------
>>>>>>>>>>      mm/rmap.c                |  5 +++--
>>>>>>>>>>      6 files changed, 49 insertions(+), 16 deletions(-)
>>>>>>>>>>
>>>>>>>>>> diff --git a/include/linux/memremap.h b/include/linux/memremap.h
>>>>>>>>>> index 8af304f6b504..9f752ebed613 100644
>>>>>>>>>> --- a/include/linux/memremap.h
>>>>>>>>>> +++ b/include/linux/memremap.h
>>>>>>>>>> @@ -41,6 +41,13 @@ struct vmem_altmap {
>>>>>>>>>>       * A more complete discussion of unaddressable memory may be found in
>>>>>>>>>>       * include/linux/hmm.h and Documentation/vm/hmm.rst.
>>>>>>>>>>       *
>>>>>>>>>> + * MEMORY_DEVICE_COHERENT:
>>>>>>>>>> + * Device memory that is cache coherent from device and CPU point of view. This
>>>>>>>>>> + * is used on platforms that have an advanced system bus (like CAPI or CXL). A
>>>>>>>>>> + * driver can hotplug the device memory using ZONE_DEVICE and with that memory
>>>>>>>>>> + * type. Any page of a process can be migrated to such memory. However no one
>>>>>>>>> Any page might not be right, I'm pretty sure. ... just thinking about special pages
>>>>>>>>> like vdso, shared zeropage, ... pinned pages ...
>>>>>>> Well, you cannot migrate long term pages, that's what I meant :)
>>>>>>>
>>>>>>>>>> + * should be allowed to pin such memory so that it can always be evicted.
>>>>>>>>>> + *
>>>>>>>>>>       * MEMORY_DEVICE_FS_DAX:
>>>>>>>>>>       * Host memory that has similar access semantics as System RAM i.e. DMA
>>>>>>>>>>       * coherent and supports page pinning. In support of coordinating page
>>>>>>>>>> @@ -61,6 +68,7 @@ struct vmem_altmap {
>>>>>>>>>>      enum memory_type {
>>>>>>>>>>      	/* 0 is reserved to catch uninitialized type fields */
>>>>>>>>>>      	MEMORY_DEVICE_PRIVATE = 1,
>>>>>>>>>> +	MEMORY_DEVICE_COHERENT,
>>>>>>>>>>      	MEMORY_DEVICE_FS_DAX,
>>>>>>>>>>      	MEMORY_DEVICE_GENERIC,
>>>>>>>>>>      	MEMORY_DEVICE_PCI_P2PDMA,
>>>>>>>>>> @@ -143,6 +151,17 @@ static inline bool folio_is_device_private(const struct folio *folio)
>>>>>>>>> In general, this LGTM, and it should be correct with PageAnonExclusive I think.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> However, where exactly is pinning forbidden?
>>>>>>>> Long-term pinning is forbidden since it would interfere with the device
>>>>>>>> memory manager owning the
>>>>>>>> device-coherent pages (e.g. evictions in TTM). However, normal pinning
>>>>>>>> is allowed on this device type.
>>>>>>> I don't see updates to folio_is_pinnable() in this patch.
>>>>>> Device coherent type pages should return true here, as they are pinnable
>>>>>> pages.
>>>>> That function is only called for long-term pinnings in try_grab_folio().
>>>>>
>>>>>>> So wouldn't try_grab_folio() simply pin these pages? What am I missing?
>>>>>> As far as I understand this return NULL for long term pin pages.
>>>>>> Otherwise they get refcount incremented.
>>>>> I don't follow.
>>>>>
>>>>> You're saying
>>>>>
>>>>> a) folio_is_pinnable() returns true for device coherent pages
>>>>>
>>>>> and that
>>>>>
>>>>> b) device coherent pages don't get long-term pinned
>>>>>
>>>>>
>>>>> Yet, the code says
>>>>>
>>>>> struct folio *try_grab_folio(struct page *page, int refs, unsigned int flags)
>>>>> {
>>>>> 	if (flags & FOLL_GET)
>>>>> 		return try_get_folio(page, refs);
>>>>> 	else if (flags & FOLL_PIN) {
>>>>> 		struct folio *folio;
>>>>>
>>>>> 		/*
>>>>> 		 * Can't do FOLL_LONGTERM + FOLL_PIN gup fast path if not in a
>>>>> 		 * right zone, so fail and let the caller fall back to the slow
>>>>> 		 * path.
>>>>> 		 */
>>>>> 		if (unlikely((flags & FOLL_LONGTERM) &&
>>>>> 			     !is_pinnable_page(page)))
>>>>> 			return NULL;
>>>>> 		...
>>>>> 		return folio;
>>>>> 	}
>>>>> }
>>>>>
>>>>>
>>>>> What prevents these pages from getting long-term pinned as stated in this patch?
>>>> Long-term pinning is handled by __gup_longterm_locked, which migrates
>>>> pages returned by __get_user_pages_locked that cannot be long-term
>>>> pinned. try_grab_folio is OK to grab the pages. Anything that can't be
>>>> long-term pinned will be migrated afterwards, and
>>>> __get_user_pages_locked will be retried. The migration of
>>>> DEVICE_COHERENT pages was implemented by Alistair in patch 5/13
>>>> ("mm/gup: migrate device coherent pages when pinning instead of failing").
>>> Thanks.
>>>
>>> __gup_longterm_locked()->check_and_migrate_movable_pages()
>>>
>>> Which checks folio_is_pinnable() and doesn't do anything if set.
>>>
>>> Sorry to be dense here, but I don't see how what's stated in this patch
>>> works without adjusting folio_is_pinnable().
>> Ugh, I think you might be right about try_grab_folio().
>>
>> We didn't update folio_is_pinnable() to include device coherent pages
>> because device coherent pages are pinnable. It is really just
>> FOLL_LONGTERM that we want to prevent here.
>>
>> For normal PUP that is done by my change in
>> check_and_migrate_movable_pages() which migrates pages being pinned with
>> FOLL_LONGTERM. But I think I incorrectly assumed we would take the
>> pte_devmap() path in gup_pte_range(), which we don't for coherent pages.
>> So I think the check in try_grab_folio() needs to be:
> I think I said it already (and I might be wrong without reading the
> code), but folio_is_pinnable() is *only* called for long-term pinnings.
>
> It should actually be called folio_is_longterm_pinnable().
>
> That's where that check should go, no?

David, I think you're right. We didn't catch this since the LONGTERM gup 
test we added to hmm-test only calls to pin_user_pages. Apparently 
try_grab_folio is called only from fast callers (ex. 
pin_user_pages_fast/get_user_pages_fast). I have added a conditional 
similar to what Alistair has proposed to return null on LONGTERM && 
(coherent_pages || folio_is_pinnable) at try_grab_folio. Also a new gup 
test was added with LONGTERM set that calls pin_user_pages_fast. 
Returning null under this condition it does causes the migration from 
dev to system memory.

Actually, Im having different problems with a call to PageAnonExclusive 
from try_to_migrate_one during page fault from a HMM test that first 
migrate pages to device private and forks to mark as COW these pages. 
Apparently is catching the first BUG VM_BUG_ON_PGFLAGS(!PageAnon(page), 
page)

Regards,
Alex Sierra