Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <622BA3BB-03EA-4271-8A2E-2ADAFB574155@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_1B6FC5B2-556F-4A2D-9F1C-A60D36468C15";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [man-pages RFC PATCH] statx.2, open.2: document STATX_DIOALIGN
Date:   Thu, 23 Jun 2022 10:27:19 -0600
In-Reply-To: <YrSOm2murB4Bc1RQ@magnolia>
Cc:     Eric Biggers <ebiggers@kernel.org>, linux-fsdevel@vger.kernel.org,
        linux-man@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org,
        linux-api@vger.kernel.org, linux-fscrypt@vger.kernel.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Keith Busch <kbusch@kernel.org>
To:     "Darrick J. Wong" <djwong@kernel.org>
References: <20220616202141.125079-1-ebiggers@kernel.org>
 <YrSOm2murB4Bc1RQ@magnolia>
Precedence: bulk


--Apple-Mail=_1B6FC5B2-556F-4A2D-9F1C-A60D36468C15
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset=us-ascii

On Jun 23, 2022, at 10:02 AM, Darrick J. Wong <djwong@kernel.org> wrote:
> 
> On Thu, Jun 16, 2022 at 01:21:41PM -0700, Eric Biggers wrote:
>> From: Eric Biggers <ebiggers@google.com>
>> 
>> @@ -244,8 +249,11 @@ STATX_SIZE	Want stx_size
>> STATX_BLOCKS	Want stx_blocks
>> STATX_BASIC_STATS	[All of the above]
>> STATX_BTIME	Want stx_btime
>> +STATX_ALL	The same as STATX_BASIC_STATS | STATX_BTIME.
>> +         	This is deprecated and should not be used.
> 
> STATX_ALL is deprecated??  I was under the impression that _ALL meant
> all the known bits for that kernel release, but...

For userspace STATX_ALL doesn't make sense, and it isn't used by the kernel.

Firstly, that would be a compile-time value for an application, so it
may be incorrect for the kernel the code is actually run on (either too
many or too few bits could be set).

Secondly, it isn't really useful for an app to request "all attributes"
if it doesn't know what they all mean, as that potentially adds useless
overhead.  Better for it to explicitly request the attributes that it
needs.  If that is fewer than the kernel could return it is irrelevant,
since the app would ignore them anyway.

The kernel will already ignore and mask attributes that *it* doesn't
understand, so requesting more is fine and STATX_ALL doesn't help this.

Cheers, Andreas


--Apple-Mail=_1B6FC5B2-556F-4A2D-9F1C-A60D36468C15
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAmK0lGcACgkQcqXauRfM
H+CkuA//avp4Tuh55VpE8yHOQ8z64y5vrwNesx7bZ8atQCuwyhbJlvdTGn27SVv1
4j1+/hWy3q+Jsot1ja0njROgu9KlOetTJ7qK4tlq4buIjBuB1izLfyGtSUtRezui
Z93g7NQEpOSFyNwknXMz2vTB4gOxgMd0V9jCkElXXC+EClReBJq/Jts+/qNH8cnU
j2kdedwlaAg3zMbSWbygM0DxumX1YB0dCYuK/SyyAyjWr4I5mHFqHeyZf3ej2fVB
g/wUfgv7Ku50XluSp4/deoA8R/TJbCkQikvKS4S9pI/LqMeOEZ6moyIJ8KRyWKSs
wbSn8e2E49hUrxKO15kQx2vIs1BS1WLN1PWmv4TVnkTmfkuf7iUVVMxlU3Jfifcx
qZXhYvTv7UvL/oV12MJHzQiYR/YUytHzdeliMC+sDa/tCyWE0UZMAZaKFgO9vV9h
gdHfsvdNabGbFBE8ul5auWUT6QaqmytVQOk6239FD/gHD3Vw4ZVptZKDziYfwULV
JgVDmWSi8RzmV3F+g3Lr9oGWqFbErsl+QWm80wXaC7yxHm3C2wKKqwPx6bfFbucT
PuSiilxCV7qDXmDRISKNt/JMaLsxh8w+15v92wWhacEtgMzIyVsjudfePb2wiUtw
bLbXOh9Pj4DCci4an5lxVhj8jEYThvOPq1FlB6e7qhrXwoGwugE=
=83Nf
-----END PGP SIGNATURE-----

--Apple-Mail=_1B6FC5B2-556F-4A2D-9F1C-A60D36468C15--