Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3c9345ca-7dd8-3833-e341-4f97f124b772@amd.com>
Date:   Tue, 28 Jun 2022 22:56:33 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v6 02/14] mm: handling Non-LRU pages returned by
 vm_normal_pages
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>, jgg@nvidia.com
Cc:     Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        hch@lst.de, jglisse@redhat.com, apopple@nvidia.com,
        willy@infradead.org, akpm@linux-foundation.org
References: <20220628001454.3503-1-alex.sierra@amd.com>
 <20220628001454.3503-3-alex.sierra@amd.com>
 <79a7969c-311f-d36b-4d44-dfe2f02c9b99@redhat.com>
From:   "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>
In-Reply-To: <79a7969c-311f-d36b-4d44-dfe2f02c9b99@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3ArR2psMVU4SDBCQSsxY1VaSURJYTJURTFsVzVISFNaYnNNSEg4V1VGcS8w?=
 =?utf-8?B?dDNVY2lZY2dvWDlDRmZUTWJGbFFFUVdacDVIMXNmN25KL0tEc3NlUmtlSW01?=
 =?utf-8?B?RCtzb1pPRGJnMFBBK0M2SWN2cmhaVjE2NG5oeDUxUFVGQ2c0bkw2T1lGTGN2?=
 =?utf-8?B?V1pRMVB2eTV4SlkwSGZoUDJ2ak1abFlacUhSMkR2SXRVUUxrTE5wM3RrRkND?=
 =?utf-8?B?cTNVcnJoa01oWm5ORlZ6dUJzSWU3VkJ3aXEwWllRblE5aThJWDZkcDZYdUt5?=
 =?utf-8?B?N1M3NHJUNldIT0IyY2tQZFgxa0dqbmNScjZXVllScTFQMmpldTNIWS9MeCs4?=
 =?utf-8?B?OUgzNkZvYkVOTVVJeWY5ZzdBTFIxN0FyMEU4cWJSZ0tXa2JmbFJSSTJsZFNX?=
 =?utf-8?B?MzVINzB4cDRZVnBvL1ZkV2lZUm9GZGRoWW1rNGZLeG9SeTJyTlJ5UlN3S1h2?=
 =?utf-8?B?Q1I1aGc1Q1ZzS1I2L3MvRTUxb0xYOEdEcTE4VjNRWTZnYnU4U3gydFlCTXk1?=
 =?utf-8?B?MGlWY0R6R013dHMzTkJ4RmNSd3J2ejl0c2x2RXRDMFZQU1J2aFdlL2ZDQlZj?=
 =?utf-8?B?c1lQZ1dlam1jdGlhYVZkOHpCQmFBKzY2aUhqeW5sK0tSa2Q3VUk5Z29BdFN5?=
 =?utf-8?B?OWFjTWRFQkdybzdZMUtqaUVBSFJINXNLalN4TGhwbG9pS1IwWG9acHQxWVVx?=
 =?utf-8?B?c1FpaUJ4aU9DNFJjUzYvMXJIM1ZQUHNVMGdrRFNBenFNYitLOFZqQ2Fjdmlt?=
 =?utf-8?B?bG55TW80aTlHcDdTbkhpdnd6cGxnOEVHL1g4aWF3bWRHRi90TEdEZG5vbGd0?=
 =?utf-8?B?WWYrM2NqbHlJMGY4MmxNUUxIeld5TzRyT3NuMWEvR3lwYkdNMFBnMDFSQ3pB?=
 =?utf-8?B?ZE1zU3ByWGF6bEFPUFExc3hMcFVlTmpBMTBWRG13WThvVS8wSDBpNUtvSXRz?=
 =?utf-8?B?ODljUDgrbGFzdjYvR0pYaEsxTitsUDgvNytlcXg1NTVxUnBkRzJBTW82NjB1?=
 =?utf-8?B?ZjJ5ME5VMTZvRVplSGcvZTFXMG1Dcy9IQmdBWDkweEk3TmI1dFl3bDkrZlh3?=
 =?utf-8?B?all2dTljYmM3d0MzNDNFV0tZb2s5WUVwMFg5STMzQXg4bzZ6Z1BlUHJZSWt2?=
 =?utf-8?B?T25FaStoUG04T29pN2J1NG1UWU5RUTFuQUcyN2UrMDdJZXlLbEJ6L0VaTVR0?=
 =?utf-8?B?ZEhBLzY0QW96MkhxK2JEZ2p4cjFkb2FLLzR1OCs4MWc4dndUdnQ1Z3Via2ZB?=
 =?utf-8?B?RFNtWXRpSG55Q2xEalJNRGpJTGxVVytCY1JpSXltWWFTSXNXTnN2bDV2bUw1?=
 =?utf-8?B?c3UrL041TkFONEpJNVIwSmRYL21qNlVyQXZrSUdYUVM1NkJ2VEozQnZXZGlu?=
 =?utf-8?B?V2J5dGovL3VBc3pydi9xQ25OMi9pWXlXMnE0N1hweTN3dHRncUY5R3VuSitZ?=
 =?utf-8?B?VkdacFpoNStNdzB3Q3B6QS9WYzlBMjZpMWZlc1lHN1dZOXBldGQzVXE0V3JE?=
 =?utf-8?B?eXdJcVZ1SzEzWXAwRE5walc2ZFN0SFhBcFppdG02S2RGeWRGdVRPUFdtZEJj?=
 =?utf-8?B?M0lDblFzR0VhRUpDRXBvZUhueEFwQ3VsVlIwODlOY1FBM0l0NU12SVBiakZL?=
 =?utf-8?B?Mkl2ZERZU3NWYndrV1RyQzY2Tm9LUlo3SjdQNnJuR3l2eHJXMnl3bEZKK3NC?=
 =?utf-8?B?bUo2UWQrMGtMby9JcjdyVDUxaFdmRmcyb2VjaVBLN0U0RThsa0ZrTnJ6Q1lN?=
 =?utf-8?B?bDI1L29wTG1ET1B2T2V2ZkkrTExzWVN3Ui9ZeXZ4b2l3b3QyK1dPNmF4Nktz?=
 =?utf-8?B?SjBKV0F3Q2pHZksvQ3RTQlowdk5qWjNsa29OOHlXRk5BQjE2T080UGJ5U0xk?=
 =?utf-8?B?QlJnRUk5ZFhWL3pWTmEvcDA4cDlYUytSdE1oSkh6UlB3VXE0cUhSUTlKU3Y2?=
 =?utf-8?B?YkxYdG9ZUUJUSDJQKysvamxiRXVpNldOcTFxenpnQjdsUm1aQ3hzV3RnSmpC?=
 =?utf-8?B?NDBpZ1kzVTQ4NGVUbGdIajhoRnpPakJXZHpiOVVTSitod3d0cHY0TndRdEVs?=
 =?utf-8?B?ZXVqZGg2VGFYWGhSSC91ZzJsck9qdEd0ZFo2U3hlWmtYcnprTmpZanB3YWg5?=
 =?utf-8?Q?IBHgHE9u7wcEPnfSXyaYJgzec?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ebb10a27-23f7-480a-c9e5-08da59835e6b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2717.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2022 03:56:38.8400
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: T8s2QwEeEbhVzcNh2BqkK7Z1FvQzr8jS541m7H90TQqC+XLpGZ+Lnt3Ad788+Ibl8bqQTxstgPK5NLlRWwaisA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3274
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org


On 6/28/2022 5:42 AM, David Hildenbrand wrote:
> On 28.06.22 02:14, Alex Sierra wrote:
>> With DEVICE_COHERENT, we'll soon have vm_normal_pages() return
>> device-managed anonymous pages that are not LRU pages. Although they
>> behave like normal pages for purposes of mapping in CPU page, and for
>> COW. They do not support LRU lists, NUMA migration or THP.
>>
>> We also introduced a FOLL_LRU flag that adds the same behaviour to
>> follow_page and related APIs, to allow callers to specify that they
>> expect to put pages on an LRU list.
>>
>> Signed-off-by: Alex Sierra <alex.sierra@amd.com>
>> Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>
>> Reviewed-by: Alistair Popple <apopple@nvidia.com>
>> ---
> I think my review feedback regarding FOLL_LRU has been ignored.

Sorry David, this has been addressed in v7.

Regards,
Alex Sierra

>
>