Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <575b48a6-e372-acda-9a7c-449f307a588c@amd.com>
Date:   Wed, 29 Jun 2022 18:08:40 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v7 01/14] mm: rename is_pinnable_pages to
 is_pinnable_longterm_pages
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        Alex Sierra <alex.sierra@amd.com>, jgg@nvidia.com
Cc:     linux-mm@kvack.org, rcampbell@nvidia.com,
        linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        hch@lst.de, jglisse@redhat.com, apopple@nvidia.com,
        willy@infradead.org, akpm@linux-foundation.org
References: <20220629035426.20013-1-alex.sierra@amd.com>
 <20220629035426.20013-2-alex.sierra@amd.com>
 <f00f9c93-c115-d222-dc8c-11493ccd2567@redhat.com>
From:   Felix Kuehling <felix.kuehling@amd.com>
Organization: AMD Inc.
In-Reply-To: <f00f9c93-c115-d222-dc8c-11493ccd2567@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUxDcW4xSko3STlIMGJjZVp1eXc5U3lWOXpSemo5MUdRcXJlM1VjUmsyUEh6?=
 =?utf-8?B?UUV2cTV6UXE2ZUF1VHZVNGRSRVdGMDRHWVduTUp4dFM0M25hTmxLT2JRd3Br?=
 =?utf-8?B?anA0Z3BqTWlnSGp5bTJGSlBzNFpCcGJlSHdPYWQ1NmlocCtscW1UYnZvUU5G?=
 =?utf-8?B?ZkhqUFlxeVlMcTdmejQvTmVIQ3BkdTlhTmpVR0NiNFV0RTNjeW5iWkg5NE9p?=
 =?utf-8?B?dmphTGlHL3p1STZxazBndm9UTjJYTHFKRkhRbzFWbU01cnFZMWlQaTYyWmF0?=
 =?utf-8?B?Ni9RcW96SVQ3VHpBUHhVZ2Z6bU1FcnNhcDgzbnZ2TFpHaFI0WWhBMHRkQVZN?=
 =?utf-8?B?MU9ONTF1T3BUTUFqWGJYSm02a0tONDNiWkhONzhMUzQ0V1VxL3BIRkdWQ1pl?=
 =?utf-8?B?ZmRZZklxSkRPTnNNVU16bFFZaWRsTUxwMTZlblRJZW1mOUozM1Y4dWlnZ05q?=
 =?utf-8?B?eEtQTk5uUTAwcTdLRGNYVkJ1dnBFVlJIZVROZll6aEJQNlNTdkdWY0RPM1VZ?=
 =?utf-8?B?VzU2cndsYStsN3NjVWpmOUxoVFdqd0pGNitKYnZ5UTNVQ0pQQnNnRHRXemJq?=
 =?utf-8?B?bzFzdWFGV3J1czlXeldYdU4vdDUzckRSN2wzUHlITWRqVktMTG9xRVVTMWJ5?=
 =?utf-8?B?cHZPTndWaTBIV1ljTUNuYXhXWkFhazFyalFwd09ta0NCa3NFWU9oL0cybm15?=
 =?utf-8?B?a1lUSTdTRk5YSkRCYjNtcTQrU2VIS2FJclplZExTdnlzV3ZXWmQrdDBJM3ll?=
 =?utf-8?B?bE8yZFBXVS9JY3dhU1FuZ3RRNUczS1ZUc1h6U0lCK0tFbnJ4NUhwOXRPTFov?=
 =?utf-8?B?ZjVDKzFRS3RDUytBbjUxWEY2RjdxNDIranBFdkJZbmZJeWxzUWFwWkNvQ1A1?=
 =?utf-8?B?K2Z6d3NzQ01xQ1pHY3Vkdkk3SjJHbmJiV1NNOXNKaWhSSlZEaE1VbktwK1Zt?=
 =?utf-8?B?ZlFJWkVmV2NXOTFPQllBT0ZuekpWNTByMDhNVFoyeHJlQnlRQlNhT0dCMEN4?=
 =?utf-8?B?a2VRbjZyMTlETHBLYnc4ejNQTWo3bVcxS3pWYm10WlQxVDRzNVVscHN4TkxM?=
 =?utf-8?B?SThjcU9aVUJJMXpVb2xsanZVWFJzOFd4UDd2U0hEbHNxL2Z1UTdrekpTQzZp?=
 =?utf-8?B?THlnUkFFRUNjRWhuRFF2aWgvbTEycGZNUXdWR2dUQytQSXdDQm91WHJlRVVz?=
 =?utf-8?B?TDlHNW5EMEhGK3JEMHF1M0FJbnFhcGkyU29OanJ5M2ZlOUNmeUZCRHJXVm5S?=
 =?utf-8?B?SmJkbTQ0SVpLZE1rODZkeVJqYVVqZ3h4d29sNk9MNXAzZGtDWXJDeFh4Wk5M?=
 =?utf-8?B?eGVVVVA5Y1Mya29CVHJBWmttK3VhZXRVNVUvS2drV2xWN0t5aFR0WjIyVFNV?=
 =?utf-8?B?UGgxUTNzNWpBY2g3RDNKMkZSVDJrbVNpMGY3TWplUURLKzE1WlNTTWtvaVRH?=
 =?utf-8?B?RjBpaHJkcVpXM3RReDk1STFkT0pzRXJWaDJSSU9mUit4bFNqRjQ5YW9iWU1l?=
 =?utf-8?B?YTRLZ2p2VE9Wa3psSVVZaDFZczQvemdFNTI4YWdLa3dFM0ptWFpoY2UrTVNC?=
 =?utf-8?B?RXRudENha3ljTWUrd2Fwck1oQmYrbHh1bHBWR2JqWHZUODVZbDUyT1dOeWgw?=
 =?utf-8?B?cHJVcVprZ2ROdUpTNnVLTWM1SWphM2svcElVNElqZXhBSElDdGJtb1hBMVN4?=
 =?utf-8?B?M1VybmlKSGUxK21UMlV1am9TUGt0VmQ4YWpmRzNKcUYvL240VThpVG0rMzhx?=
 =?utf-8?B?bG1GYjNNRmI0OHI5RFNJa3JQc2l0U0N5YXN0YmhSbjdDZXhKTXdTSHl1RjY3?=
 =?utf-8?B?Q1MwTUNuMnI4NVU4SkNBM01EOWRYdFV5ZUcyaHFuTHhKUDZ5MXQvNnU3NHdC?=
 =?utf-8?B?VHhSamt1MTU0aXdhNWZJcVpRaFNQVzFPTDI5UVZ0NGt0UExCTHdTRVhyZTlm?=
 =?utf-8?B?UUhFZlVna2xJYTVWZjZVaG5iUjlSME1aNUwwbVQ2UE4zOHZrRnd0NkVja3lY?=
 =?utf-8?B?UnFYRis1THpxamZRMDBMKzdCVWpNd1NDSmxkSncyNDYzNmV6Rlh5T2J2VTZi?=
 =?utf-8?B?VlFJNzh0WGFGTXJ1bEFRV0ZzemhNbDJMbUhiOWpFNkh3TUlxQ21HWEZlOTdR?=
 =?utf-8?Q?E6sT7z5tSP5ZrHuu1w+DR4TuC?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 65e0837e-01d9-4059-178b-08da5a1bed83
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2022 22:08:42.3629
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /RSCww2pHaRbsnxVZsESHNvs+oz9f/YyPWRFNO7FvSER7oG2NyKXL3mYP7ZNrbkpGvRkGmb4+/S8hJThlsF8JQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6609
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

On 2022-06-29 03:33, David Hildenbrand wrote:
> On 29.06.22 05:54, Alex Sierra wrote:
>> is_pinnable_page() and folio_is_pinnable() were renamed to
>> is_longterm_pinnable_page() and folio_is_longterm_pinnable()
>> respectively. These functions are used in the FOLL_LONGTERM flag
>> context.
> Subject talks about "*_pages"
>
>
> Can you elaborate why the move from mm.h to memremap.h is justified?

Patch 2 adds is_device_coherent_page in memremap.h and updates 
is_longterm_pinnable_page to call is_device_coherent_page. memremap.h 
cannot include mm.h because it is itself included by mm.h. So the choice 
was to move is_longterm_pinnable_page to memremap.h, or move 
is_device_coherent_page and all its dependencies to mm.h. The latter 
would have been a bigger change.


>
> I'd have called it "is_longterm_pinnable_page", but I am not a native
> speaker, so no strong opinion :)

I think only the patch title has the name backwards. The code uses 
is_longterm_pinnable_page.

Regards,
   Felix


>
>