Received: by 2002:a6b:cdcf:0:0:0:0:0 with SMTP id d198csp1008596iog; Wed, 29 Jun 2022 16:28:26 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vXH1MrgNg7HHV2pJlTB4FPr/J4aKtfwaTTiQtqxR9SdhBd6Slc5e1FCnON1EdgbMz2ksoR X-Received: by 2002:a17:902:c405:b0:16a:23c7:e9a6 with SMTP id k5-20020a170902c40500b0016a23c7e9a6mr11506387plk.58.1656545306373; Wed, 29 Jun 2022 16:28:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1656545306; cv=none; d=google.com; s=arc-20160816; b=Hx8eYWpVQ7N+r4ahIykXBhci8LandJxAP1XpzTD1OgWB2TLb39HBiJEKuGToxesIww anQHJhCKLyx3oJW9J35j80OJqst7ATJ5mivTz1wlCmRXNqzLjNgX177+aMphELu8UUme khFJ4gdzfg8Ko09An4Ph2EkN45WwsF0j9elk6vKOutmktLrPZoOeqjPZKSQcCu2DbrOq cUEpWRtjyrPUObLHgulOg4P6N+7sQ8JKBcc7HHsIZicheRFtGLnz56f2fKmGtD47LMz9 AyI7ioqzHsyLnuhjuttxGz+CcxpqY/tbiFbc5CqTWpPvcRnSEjsSyxXWcp7KAnLG6+xX l6Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=sivMz5SfiF5S53/Rl1WMnAN0B8PkqhNJOlE8OzlViBE=; b=ldh3PQnKGPx25IPATfrjW7K5QeKubkhjqNxXcZIDzFLTbavejpG/qyfb2U2ucsJqeF Oe0fdNGFVEGgJc1tHf/slJaUHdF5BANfG/A1e9GvRYv1egxwDKm0n2G43aXxzdqtyBUS dkGpa7tCSwGEH4eKT4gd8O6mEvw7EMZT+m0PdLcJaTHhXNqSRj453PbXSvj78dkNoA+K Iv8441sCWHx0c0Fw000KpEMmSMoyO1iyZSP1GDrxu/nKM0J5n/Ol4r3Z/3LIHcQ/g3N+ XMywZFQCUzi2kQX2YWaBvDd343Ja4UmEEIQuo8BOY2fXEbA99OZw4XCs742eXHEj0Xzz 7Iqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=yIUhyRd1; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v1-20020a655c41000000b004089d1b3912si22414974pgr.204.2022.06.29.16.27.55; Wed, 29 Jun 2022 16:28:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=yIUhyRd1; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229654AbiF2XYS (ORCPT + 99 others); Wed, 29 Jun 2022 19:24:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229540AbiF2XYR (ORCPT ); Wed, 29 Jun 2022 19:24:17 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 826CB23BF3; Wed, 29 Jun 2022 16:24:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3D785B82466; Wed, 29 Jun 2022 23:24:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51CB1C34114; Wed, 29 Jun 2022 23:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1656545053; bh=Dnxtg2+47dMB9fvk3mpZuwgNcKCi6p+et4oU9iDj/kY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=yIUhyRd1UmOnjNmm25XNKViGfXOi0X4HOJ10GLIlf13tTMKTjOUKLDyQ4Z2DbDg0O cVQjech3q/YmOGPV9iO+PcS3fpGyfcUYsFfe1708PQjUEfslyL6ytDB/D+Pq4Yvxiq Yqsj0t71BtS8NGnMPbzTZ5t6X4C+LtXr/VhhiUbg= Date: Wed, 29 Jun 2022 16:24:12 -0700 From: Andrew Morton To: Felix Kuehling Cc: David Hildenbrand , Alex Sierra , jgg@nvidia.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org Subject: Re: [PATCH v7 01/14] mm: rename is_pinnable_pages to is_pinnable_longterm_pages Message-Id: <20220629162412.d6aa0bf6244e487e4279fc31@linux-foundation.org> In-Reply-To: <575b48a6-e372-acda-9a7c-449f307a588c@amd.com> References: <20220629035426.20013-1-alex.sierra@amd.com> <20220629035426.20013-2-alex.sierra@amd.com> <575b48a6-e372-acda-9a7c-449f307a588c@amd.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, 29 Jun 2022 18:08:40 -0400 Felix Kuehling wrote: > > > > I'd have called it "is_longterm_pinnable_page", but I am not a native > > speaker, so no strong opinion :) > > I think only the patch title has the name backwards. The code uses > is_longterm_pinnable_page. Patch title was quite buggy ;) I made it "mm: rename is_pinnable_page() to is_longterm_pinnable_page()" in my copy.