Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp24606imw; Thu, 7 Jul 2022 20:20:40 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sdfdTCI+LLlWT2neMTxYInAHKNauTVwVRvdLamNDaGHkA/RsyBeB5EMOuXmEhYJH1oX+d4 X-Received: by 2002:a62:1509:0:b0:528:98a1:1f7e with SMTP id 9-20020a621509000000b0052898a11f7emr1366178pfv.11.1657250440330; Thu, 07 Jul 2022 20:20:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657250440; cv=none; d=google.com; s=arc-20160816; b=01lu9hFIcxPh85MYR2C5iXGPnbJz+eVy22fbpIT2Newa6zYC731Wvb+/u9vYNDu1u8 S7cusHNKMhlLU4g2ICaRK//Bb4SzmPtqo3B2vDCptpbY8k2x5s37OlR+krg91KPrD+Hy iff8cjs7m+Sl5ydcYax0uWQCuGd39/vdtlZad2EPjsqNWAm55cKip4OcSrbe46ljAF4t 07UXyYwsHMQK+OZbJNmJ33ckpV/tCSNbaEVwPjzG80KKrEZhJQqg93TJvZP/lbuaFE8A 7hE1VKzYMEAfF8tjv+2Siq015Zzb/8OPtLMXGZezVn/F57bjuNm7mHHaxaYSXJVxRmnK uI0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=F6pvyLnh3lX9Tis+dwIC/keqjw/oM/iUsJG6g/XqKPs=; b=omRfS6ztIJRZnAv0n615Uw1mOdYOsb26uaufFSfYVpe6PceHdGQVO7Sk0MfGIgbInt e5YQ4l52CCd6fpD0FbINA3gvUbuM7A6c1h/PXeoE3L5rUObHChIsAPmIVgECphGnq3aq ig1fnZqWZhE1uWDpOvQuJbrEVXC5F+RxWBwUc+C8i/MTKJpDtBC/xmQV7mBTLdCl5nOD Q8gbaD7kyK7gGYbkAosTCYmYX6T5LQCVU7M5dy1qDvu06g6LA2AfFJusdJfxKIiscZC4 cEl4ysys769oFtvd2bvC5OzGbaaAGqREryl7JalJOipE+U4qLexC2ULLZ6lZKDI7WbJU B44g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=AfhnZLBo; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 16-20020a631950000000b003fcdc3249b8si57414347pgz.494.2022.07.07.20.20.23; Thu, 07 Jul 2022 20:20:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=AfhnZLBo; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236925AbiGHDUU (ORCPT + 99 others); Thu, 7 Jul 2022 23:20:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236845AbiGHDUT (ORCPT ); Thu, 7 Jul 2022 23:20:19 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56838747B4; Thu, 7 Jul 2022 20:20:18 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-118-63.bstnma.fios.verizon.net [173.48.118.63]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 2683JxER032632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 7 Jul 2022 23:20:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1657250402; bh=F6pvyLnh3lX9Tis+dwIC/keqjw/oM/iUsJG6g/XqKPs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=AfhnZLBo42DJXgMMv2RaGhLMFpwqXyI1ExJKlF3EpHbUasJUrUWkwNhJhImpapc20 OAzq966v38IPZVR5QhC7vxeDdYnb09gAo5iR2r9pCRKWCks3TUWLIY1npbKjtIOoWq l1kwwMt48pcWfKDFuzaD/RVimRFDqAxgcSJxqLiamDcQS3LxbCg9lYt43a8kBifVGo qs3GOXOsVB38WuarjWBN5ORq3EmR1ActyuTN0TEDno/5N/nEb6oybWxJ3KWUcCh1c5 x1htiaXgRxu7545Z27PORvYm5auru6ajpNdyOUx7R8V36SPuLYDK+jgRGKNyOncBBK 9ASnr48aROGRA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 87FD115C433F; Thu, 7 Jul 2022 23:19:59 -0400 (EDT) From: "Theodore Ts'o" To: adilger.kernel@dilger.ca, hanjinke.666@bytedance.com Cc: "Theodore Ts'o" , linux-kernel@vger.kernel.org, lei.rao@intel.com, linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: reuse order and buddy in mb_mark_used when buddy split Date: Thu, 7 Jul 2022 23:19:54 -0400 Message-Id: <165725003055.1812964.2153174785419318400.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220606155305.74146-1-hanjinke.666@bytedance.com> References: <20220606155305.74146-1-hanjinke.666@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 6 Jun 2022 23:53:05 +0800, Jinke Han wrote: > From: hanjinke > > After each buddy split, mb_mark_used will search the proper order > for the block which may consume some loop in mb_find_order_for_block. > In fact, we can reuse the oder and buddy generated by the buddy split. > > Reviewed by: lei.rao@intel.com > > [...] Applied, thanks! [1/1] ext4: reuse order and buddy in mb_mark_used when buddy split commit: 08779aaa3f63ccb5cb3a2b78135132231677085e Best regards, -- Theodore Ts'o