Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp372666imw; Tue, 12 Jul 2022 22:57:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vlR56XJbY7ggp6iKJetcEhad1FEdMXs/Oxf8g58+nTOC4yKK6734IIzVtsPq/bFf08Nn3H X-Received: by 2002:a17:903:1105:b0:16c:32e4:6453 with SMTP id n5-20020a170903110500b0016c32e46453mr1653121plh.131.1657691875213; Tue, 12 Jul 2022 22:57:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657691875; cv=none; d=google.com; s=arc-20160816; b=equRAClQNep+IrmLG9ni947HIVsAImkQX/vuYOOmTB6ZRNYPThqtPG3cB8S/Z8ToJp h36rcjkmhN8yxoUPxWleVv+tDyVxLIh9DlANO/2Gk91F+CDC1PPinxdH49OVZ1mvZg7d WY7lTUMWgGdKuTc95hHb35uqlM5pTWwl/KSyuYQEsmrP716MJAMD56dIraDcZZXDNDoo eD1etP9qZzSQ02Ut6g1XMnkaQtqoNFfnnCpVT/OvLPtAYr5nLHKMuyBrdNlD3jGZiKS0 TEPLUwLjmSQC5ptn3oRFzwAQt6OWXs8CqQC4fnXbLr85tjKpxghhlyfwlXa8PT8VGF1e IdHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=20fYCpa6V6Ap10mEOQh3cL90/z7nSmsIewaP84vytaE=; b=h/sP16Fr0e6gkZ4QhzdSUV3wQSsHGsOH5v5auasefqZnepeJ+e8GEH49MZJpxN+LzF j+XhFFe0KEcnxv2jSpl6i5KRkV3SsQ+DXpIucDdnls75wk5AL2JOM8OncbOr9392wPEA XxeIddG0xg9ogE0T0ysUDx9ewSUzNjw5AAQMJ/dzcyyKsHO4wtc+dhGr2SQS69ndyFqF IzE64rZGH0SGGGtGn8rjPBs05lPS3kiM5uDePUXcX5rd/rSWMJfJKpdLwn4UDWiynBmC +otMMpoEFC0fM92KjvnmPYRGcAmPJwOoD7IQjkvY1Mcp2Bir4sPphE6cmVx3bcM5vNqI Tr1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=qh0sF5wn; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s29-20020a056a00179d00b0052ad083f789si11579015pfg.312.2022.07.12.22.57.43; Tue, 12 Jul 2022 22:57:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=qh0sF5wn; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233416AbiGMFxn (ORCPT + 99 others); Wed, 13 Jul 2022 01:53:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232287AbiGMFxj (ORCPT ); Wed, 13 Jul 2022 01:53:39 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A15EDD5; Tue, 12 Jul 2022 22:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=20fYCpa6V6Ap10mEOQh3cL90/z7nSmsIewaP84vytaE=; b=qh0sF5wn2Ta7HQYLFlY/P/Q9Wi DS2ijefXpSBdkMRpGE9Xk4pb6JYtV2a3YEQtifKPjKehtbR6ZvnECB9ae8ReP2XIadd8BoIMUsgwv 8yjoGchrDeEgcwI9LNlYEKD1U6bj16k1Ha8HxlK5UrRBqbSo7xJEYeen35qZ9zzFDFe/jv2yZwMtS hI1ykmF+ndaa1FvAd0SZcSbb7CcwoVicWCK915yEKaJFEgPS7XM+KzrdcPqjCz9HPCJi3u8Hj+RAr M5AVOo+lJIjwhmLkaBi87rz7EH6i8wgeIjc+GTplUECFn0Diq3CizjrqPhTdnsXn1/eCIGeNWVM4u iXwU2e5Q==; Received: from ip4d15c27d.dynamic.kabel-deutschland.de ([77.21.194.125] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1oBVJQ-000NR5-KG; Wed, 13 Jul 2022 05:53:29 +0000 From: Christoph Hellwig To: Jens Axboe Cc: =?UTF-8?q?Christoph=20B=C3=B6hmwalder?= , "Md. Haris Iqbal" , Jack Wang , Song Liu , "Theodore Ts'o" , Andreas Dilger , Jan Kara , Mark Fasheh , Joel Becker , Joseph Qi , linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: [PATCH 3/9] drbd: stop using bdevname in drbd_report_io_error Date: Wed, 13 Jul 2022 07:53:11 +0200 Message-Id: <20220713055317.1888500-4-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220713055317.1888500-1-hch@lst.de> References: <20220713055317.1888500-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Just use the %pg format specifier instead. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_req.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index e64bcfba30ef3..6d8dd14458c69 100644 --- a/drivers/block/drbd/drbd_req.c +++ b/drivers/block/drbd/drbd_req.c @@ -523,16 +523,14 @@ static void mod_rq_state(struct drbd_request *req, struct bio_and_error *m, static void drbd_report_io_error(struct drbd_device *device, struct drbd_request *req) { - char b[BDEVNAME_SIZE]; - if (!__ratelimit(&drbd_ratelimit_state)) return; - drbd_warn(device, "local %s IO error sector %llu+%u on %s\n", + drbd_warn(device, "local %s IO error sector %llu+%u on %pg\n", (req->rq_state & RQ_WRITE) ? "WRITE" : "READ", (unsigned long long)req->i.sector, req->i.size >> 9, - bdevname(device->ldev->backing_bdev, b)); + device->ldev->backing_bdev); } /* Helper for HANDED_OVER_TO_NETWORK. -- 2.30.2