Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp628060imw; Thu, 14 Jul 2022 07:58:11 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tfDak6Qu3EbjLIWLURhLIJHDvn30nlr+L/Z14lMD+Ze2FnSzF2ZKE3Y0745WaZecMHu1A1 X-Received: by 2002:a63:5921:0:b0:412:4732:a4d with SMTP id n33-20020a635921000000b0041247320a4dmr7817008pgb.543.1657810691365; Thu, 14 Jul 2022 07:58:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657810691; cv=none; d=google.com; s=arc-20160816; b=GcUv3GabwDbKsRylrCqtGi1lLnotRMTPTJOZpCgpKJPz02oqWi+zLyWpWKYXsIuPIe 8yL/L35T1JhoLmoK5I+8yfZKC6sW4J+u7Ffka7yMIbgcYH+eAvJhHDTg+AlagHOo794z vhhHcdZV5ewgtqbuhBp1fVmE5Z/s4rYPm9csX4yO6A0K69gkL5MVbU38IeQhcpnl97rf r287NHY1x/Xr4qWx/BN3FLCqE099PQCtnvoySytj5C8PWPFV02btGdANjpO1iV7iPq03 QCZmlX5fdeKZv0VImwQgqx1cALdf8eDeUtaamKIcjsopAw1Ht0vB4Dht2+YOp1Y/GqHd L3+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QawvQ560xdvpwEjmvpfYqk0KReolW7mc5YwpiDi8AfQ=; b=TerG6nnTSnrHF1PjXcv7HPu2QbM8nfU69ZGgcJ2bS69rorLEzFlOKqOlrV4N5J5F2v lGewt6Z0WffQ8mhn3pGQBnQZ586Vet6EJdaqWyBhTRZPC0X8zlk8GcJIbh3bezjgcEuc 4Kjoqb6lX7WMLvk8K/VlLszViuWMXEs360mG5hHYv08IPf5zRXRlsdUVN3Kgo1PfxvvI MdxODT3csQ/WVxp/d8jaG5qPxTaavCxGZHXco0IM6l7cze6ogCZlS0WTLU3yjcKmhlO8 OndyPnu+dB+ebMoMshHNCwOFEFmbsBHkfQ3hEYki1IaFcXUMqiaNPOo2LUQn07uJEkhS 5B1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b="pu/S7BHY"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g10-20020a056a000b8a00b0052857cf783esi2355910pfj.231.2022.07.14.07.57.56; Thu, 14 Jul 2022 07:58:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b="pu/S7BHY"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239050AbiGNOzS (ORCPT + 99 others); Thu, 14 Jul 2022 10:55:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239376AbiGNOzP (ORCPT ); Thu, 14 Jul 2022 10:55:15 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE5BB52445; Thu, 14 Jul 2022 07:55:13 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-118-63.bstnma.fios.verizon.net [173.48.118.63]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 26EEsLPg008235 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Jul 2022 10:54:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1657810466; bh=QawvQ560xdvpwEjmvpfYqk0KReolW7mc5YwpiDi8AfQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=pu/S7BHY5/kT9cNJvuSsMX2+ODL61NzBt9WeY0kH2iDG1wLIRcJqXa056UAdnT5+R AOBqk+iBbUVfpambcQLLwkcwq41iDUgaWVXHm0jCDFkqWSpDaoESYWo2IWefkCcFPR dNlco22a1oOA7NYcLgzPxYPBZPms8A98tFYGPOCk3otxcYnaC30u5O484Q6oS806vX nqNfS1uK+j9hjifljIYmah6A264d9whosKObzjpZTzUMGjE7Zx/aXeDSM0PApGB+9y avfsuVx4y3MSJ8j+JXl3SVk3a5IQDq2BOebsVOHim9lSZk09zLlA2Qei9BCtXZjSZp VkEYcHXptjpPA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 3753C15C003C; Thu, 14 Jul 2022 10:54:21 -0400 (EDT) Date: Thu, 14 Jul 2022 10:54:21 -0400 From: "Theodore Ts'o" To: Christoph Hellwig Cc: Jens Axboe , Christoph =?iso-8859-1?Q?B=F6hmwalder?= , "Md. Haris Iqbal" , Jack Wang , Song Liu , Andreas Dilger , Jan Kara , Mark Fasheh , Joel Becker , Joseph Qi , linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH 8/9] ext4: only initialize mmp_bdevname once Message-ID: References: <20220713055317.1888500-1-hch@lst.de> <20220713055317.1888500-9-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220713055317.1888500-9-hch@lst.de> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jul 13, 2022 at 07:53:16AM +0200, Christoph Hellwig wrote: > mmp_bdevname is currently both initialized nested inside the kthread_run > call in ext4_multi_mount_protect and in the kmmpd thread started by it. > > Lift the initiaization out of the kthread_run call in > ext4_multi_mount_protect, move the BUILD_BUG_ON next to it and remove > the duplicate assignment inside of kmmpd. > > Signed-off-by: Christoph Hellwig Acked-by: Theodore Ts'o