Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp628993imw; Thu, 14 Jul 2022 07:59:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uHa7pJ0mTmavZc+H/w50Z6ugi2geRcQgjgJayUzsfgUMhRKAR2PqMG2SyTsfiIK1j+aQVD X-Received: by 2002:a63:ba1d:0:b0:419:7e6e:2858 with SMTP id k29-20020a63ba1d000000b004197e6e2858mr7840660pgf.67.1657810767145; Thu, 14 Jul 2022 07:59:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657810767; cv=none; d=google.com; s=arc-20160816; b=SDN+PWBIaF8rwji5sB5wTBxAf+DW0hoL2hes7PVwniZwHiMSiGzS9Hd6KfyO/YbfJ1 YAlo8f3xC7SnfTk9Oie6UoITsRycBzaAMbzJe064+8GhbRgcFVOA8Q38yEIPQNV7gCSK ECnmMG+ASiNcLs5fbtLXVxqFo9s2orHoSPt24TSO6Qpenca0lKb6Sveh7TGwFsVMv+7A zVeF5+9q0rvoYhIKAd60AwgQZ/OCNjlIEL7dO/ioA9Hs6GudnTjZi5q4ZNiuSC0D7lEB XhQa+fYeXtU4Hu48v97epPtBGg/vUgYy7IwzVTjLBzyJO1sC9pAd+lVVxSDXvpX9vHoJ Przw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LniF0VaQb7G8jQOtwHp006IFOhhLUxQVn8FynPI4Cic=; b=0UG01HtrogW7YKMI68xPPO0cEAm6iKegzMB0NREr0GZteiJewJ3Pn5s8cdb1PSg2ZT l9g7Ou2rCqWKudsiBtzPcC0QVimBd7Rx07FPvhWdIdjfyWHnaE6kaYHonN72TfzNGsjB aF6KgBoJmo0ZZ4ahCE+zNY6HFm2eQPmfP6wrJCCM4U/gxuLhIvSo0ugjvWCj0BY4TeTa M86ag6rnRh4wp57xzrAJhhDuM4a6+j4mIxvPr/dtH3pjrzuHXxAgd0lF6w2n4QP+Gwte /DW4BaUk/d/5m5TwG98zQo0pM+WGufhM9M4GSbB8GB9zmGENA4sXn/s+MUd3GsO0qZLC LyBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=C1uxIweF; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p7-20020a170902e74700b0016bd8e4267csi2725100plf.188.2022.07.14.07.59.11; Thu, 14 Jul 2022 07:59:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=C1uxIweF; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239660AbiGNO6R (ORCPT + 99 others); Thu, 14 Jul 2022 10:58:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239655AbiGNO6K (ORCPT ); Thu, 14 Jul 2022 10:58:10 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8342F5C9E0 for ; Thu, 14 Jul 2022 07:58:08 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-118-63.bstnma.fios.verizon.net [173.48.118.63]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 26EEvrVn009941 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Jul 2022 10:57:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1657810675; bh=LniF0VaQb7G8jQOtwHp006IFOhhLUxQVn8FynPI4Cic=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=C1uxIweFbEJYz9EJYTA+SLpBabzbBcLVerm6M7BgWeaonB7FPNfZXGSzBW/WdMnQV Te2Xn8Ab8TVeqSy142SlWiQpQnZ0waZTnHknuz3909Hb2lpAC2P/4XpIiCTKOoeMna s0TSNRwuQPaygJTNdEB3VOFOEh4cLjHaF0sTHS4rg5fTKHYtofGa2aELgK5TmOYkiU mbAhPCMjJm4B8qsyeOMk5f+mUriHOYT6+ts6JiakY96KRkeClbKtHQZULAKVKVDXY0 pUsla2RvwiuOI37xo/fLVKqez9P2HswSDCetzu9fq1SeVCdkSgoXtTYKZ1wfkObVpC GIAZrU60Ii5hA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id B4FF715C003C; Thu, 14 Jul 2022 10:57:53 -0400 (EDT) From: "Theodore Ts'o" To: enwlinux@gmail.com, linux-ext4@vger.kernel.org Cc: "Theodore Ts'o" , yebin10@huawei.com Subject: Re: [PATCH] ext4: fix extent status tree race in writeback error recovery path Date: Thu, 14 Jul 2022 10:57:52 -0400 Message-Id: <165781065440.2470585.17226618557732749649.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220615160530.1928801-1-enwlinux@gmail.com> References: <20220615160530.1928801-1-enwlinux@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, 15 Jun 2022 12:05:30 -0400, Eric Whitney wrote: > A race can occur in the unlikely event ext4 is unable to allocate a > physical cluster for a delayed allocation in a bigalloc file system > during writeback. Failure to allocate a cluster forces error recovery > that includes a call to mpage_release_unused_pages(). That function > removes any corresponding delayed allocated blocks from the extent > status tree. If a new delayed write is in progress on the same cluster > simultaneously, resulting in the addition of an new extent containing > one or more blocks in that cluster to the extent status tree, delayed > block accounting can be thrown off if that delayed write then encounters > a similar cluster allocation failure during future writeback. > > [...] Applied, thanks! [1/1] ext4: fix extent status tree race in writeback error recovery path commit: 8e469e57340049d4735b71660d29bd4fd3ae1607 Best regards, -- Theodore Ts'o