Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp5072667imw; Tue, 19 Jul 2022 20:32:49 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vvTg8Sefoh0c764pDSpB0A+0zYwd7XVErC3WBn379pHONB4QaMEH9EqQmEsb8yHiCg1EmG X-Received: by 2002:a17:906:58d1:b0:72e:e049:cf00 with SMTP id e17-20020a17090658d100b0072ee049cf00mr26479919ejs.361.1658287969626; Tue, 19 Jul 2022 20:32:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658287969; cv=none; d=google.com; s=arc-20160816; b=UlnWzlDxoiE3CPKo+jZp+wUkg3tacD/FcJpNFvgF6kPZdnh1PZ8DoXj8/C8iHE9L7P eelmWzjSajJsvd4y6TmIbgwhw3J8BrJjznPqhtg4O5Ecvf1orb9a0cWTdMVA+6gG16En IB05TnMdiifdzZ+16rWUhdBD8GDmAgk33QPqcTiu9W0y8ku4Y9gAoMndlYR/dFxU1I2k xsHRuxtu02xwHAXI7jGk2nPpXw0xIDgXvNM5BFdQjenElI6tU+lv1VCyaskY+jy+xqup 3NrKNKS7tKjfB1IfmlPZXu8DlQHn7/n71C68L53GYlIu59LH4nydDzcsgiaEVHQXjDyg e61g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=gu/Ya+HLNKChQ8FEyH8dSabXYrpS2k0ipyhSkSCwcB4=; b=fLChNGpWbxJcW6hOMao4JPKpl07ZXmaT53RRrrLLpNanZKuF7LJaU4dMljLHk309FQ vjk+nbu2QM+kt5e212hbpF2mI9FaNkvyQhnJnG4cFvwGR1+FvIH8AvmsWwQKN092Wig8 aMsG/0q2gU6zD5TbXrQCcFCPxSG7+rDvLVt5yAUIZdF1aLwA/ruuISLoyya6GNz/Ft5K 35scOvOUXKbpPc3Scn2oh+rBWi3r7Drnjk3TppwG86SIbP+FquGqvf171r5CAf7cvMhX 7Fo7jbP7SGVI7HWhyY6JA/57ngB3apjfipvoV4ELU41574c1vvAssa1zNYodBnJzsJZ/ culg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=t8PVoSzg; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v20-20020aa7d9d4000000b0043a96b5da4esi17609329eds.90.2022.07.19.20.32.14; Tue, 19 Jul 2022 20:32:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=t8PVoSzg; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237934AbiGTDTR (ORCPT + 99 others); Tue, 19 Jul 2022 23:19:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231222AbiGTDS4 (ORCPT ); Tue, 19 Jul 2022 23:18:56 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE94A23BD9; Tue, 19 Jul 2022 20:18:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gu/Ya+HLNKChQ8FEyH8dSabXYrpS2k0ipyhSkSCwcB4=; b=t8PVoSzgQnNZWE9p3TMdL0mIlW XiG6sISPQ0jVBatZcZqIcR4peDcbenoH6BpNAOffxB2Dc+JvrVwPysQk+gKHVLA0BggDUADM1f8bE 2tZ6k990YN76GaK+hgW0b9n4gjUpAxSRZiPIgxnmrIxBSZ/bIcToTJtLtcaF+540hZrpWrxDSdXWF k/Ct07PiX/Q23asl0hVTM26S1oazjBEszYRzaT8ekid42AwLzJHV1ywievqvUcXHIinG6BrsTsZfU vMbVxcK4otZF8VGTI5u5OvxLNZarAWLtaYHBmWYwu2ruZMy2W//pytbGa0i66MxipFQOi7hcM78jv g6uKczQA==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oE0Ed-00E78p-FA; Wed, 20 Jul 2022 03:18:51 +0000 Date: Wed, 20 Jul 2022 04:18:51 +0100 From: Matthew Wilcox To: Jeremy Bongio Cc: Ted Tso , linux-ext4@vger.kernel.org, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4] Add ioctls to get/set the ext4 superblock uuid. Message-ID: References: <20220719234131.235187-1-bongiojp@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220719234131.235187-1-bongiojp@gmail.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jul 19, 2022 at 04:41:31PM -0700, Jeremy Bongio wrote: > +/* > + * Structure for EXT4_IOC_GETFSUUID/EXT4_IOC_SETFSUUID > + */ > +struct fsuuid { > + __u32 fsu_len; > + __u32 fsu_flags; > + __u8 fsu_uuid[]; > +}; A UUID has a defined size (128 bits): https://en.wikipedia.org/wiki/Universally_unique_identifier Why are we defining flags and len?