Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp667630imi; Fri, 22 Jul 2022 07:01:10 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sz2p01I0gTEiesVs3QjRJ+Jgy2HlbaJ34EU/2sstohPIJrBBxj0YrTVRRIiMhXknjCidjV X-Received: by 2002:a05:6402:2b8f:b0:43a:66d4:a025 with SMTP id fj15-20020a0564022b8f00b0043a66d4a025mr827798edb.121.1658498470165; Fri, 22 Jul 2022 07:01:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658498470; cv=none; d=google.com; s=arc-20160816; b=x2MlPSh5t+NNx/ebQs05McEfUNMbcWUF+g8n+rpmd3CbJ6OGagofp3vkzjSugQNbcw qsVKRUvV8rPlksPpBTA/GpKYa7oZQx+Mql29nz3w2Dt6A/zpYHPNiZQUbKf5AbhCJ44e nPJLaiKvmyVPg2Xx3eYM/GKGkngGZIE3Q3MU/9gWKXwyrsQaabZUBWkDZq8nwLSamC4s RBF7cknPV+wpu/FEPTSrLzqqrK36DsxELtMu4w60B9oMnxvBgX8hd8qyoQi61Kk4yNAZ 1C/t6rBTk0Bnk8PiCrJlaqdD9jNlk1LZ+OqIhgD8DPmorJtGQT5ZkAgWedMSfEcEqal+ b+zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=eUPtkUbR9nSM/4hlqsfrWX/EXs8Pb0BkytPA1RSiQkc=; b=iCIAEUz3ajRTuBh/QyjZsWFIQ4kaKz3wLd/CHWByKLZBdtNZLHMRDvGaSMg7j7XMfU eg1LYyoukAcFL+cv6NWspOFjIGXkq+/M5YzSkmAI+s+wZlVbisq47BHgdBymZRe59oLT pVlHZtCgfL6+5FMD+LiFq91img01srnUn5TFvWhf4ilr709BBXohcYJ4vVeyO6IQVOHD rUhkPvVUO2Iy7DIs2jNJCA3VUMyuuUoBXlRHT1Oc9ApyWJagUhqjwxiqfhsgTQZUXIaq q5Tt472KQn/VbqtM+eHtGa+G7bcDswVfsXMwdJrmw5AGQmAoq4/QMHFUb8EVfjkWBm08 yvYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=KEBvBxdF; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dn15-20020a17090794cf00b006ff6c9f7081si6230182ejc.738.2022.07.22.07.00.42; Fri, 22 Jul 2022 07:01:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=KEBvBxdF; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231807AbiGVN6k (ORCPT + 99 others); Fri, 22 Jul 2022 09:58:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234356AbiGVN6h (ORCPT ); Fri, 22 Jul 2022 09:58:37 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E189904CF for ; Fri, 22 Jul 2022 06:58:36 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-118-63.bstnma.fios.verizon.net [173.48.118.63]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 26MDwTMU016770 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Jul 2022 09:58:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1658498311; bh=eUPtkUbR9nSM/4hlqsfrWX/EXs8Pb0BkytPA1RSiQkc=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=KEBvBxdFUYE1Lj2LwkyBQamoon65/TxoPJTfqie18l6OjQFL7/zeOpmHQwdJgP8iQ xlKh1eOgoZTXeTfJl7kDNZb81zc0X+sQxRmn77UMjFRf25cF6Izr5LWmG4cFIJ4Ld/ e33Zn3NfjhBl1YQya8d+Ay46LrREJNWNWWgZkv2df0P3GvxABEiblZcSShR432VzAh VkL4insxlPinzLsx3JgsXtFon6yp7hkRnA7F650YHVLSvQxonk2haD9ViC1rHfvn5i RLAj4reW3T6MysuJYP0NrXhcHGJeCjAnMfFWBTXdBX/AHO9SBTzhJLqMMNg+2ignMU MuLWlQgjCSVzw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 7839515C3F07; Fri, 22 Jul 2022 09:58:27 -0400 (EDT) From: "Theodore Ts'o" To: linux-ext4@vger.kernel.org, okiselev@amazon.com Cc: "Theodore Ts'o" , Jan Kara Subject: Re: [PATCH -V2 1/2] ext4: reduce computation of overhead during resize Date: Fri, 22 Jul 2022 09:58:21 -0400 Message-Id: <165849767596.303416.13460164582488168327.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, 20 Jul 2022 04:26:22 +0000, Kiselev, Oleg wrote: > This patch avoids doing an O(n**2)-complexity walk through every flex group. > Instead, it uses the already computed overhead information for the newly > allocated space, and simply adds it to the previously calculated > overhead stored in the superblock. This drastically reduces the time > taken to resize very large bigalloc filesystems (from 3+ hours for a > 64TB fs down to milliseconds). > > [...] Applied, thanks! (Some slight adjustments were needed to resolve a merge conflict.) [1/2] ext4: reduce computation of overhead during resize commit: d985f3d81c0be1c673ac0462b26727b2a1aeb0d6 Best regards, -- Theodore Ts'o