Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp667706imi; Fri, 22 Jul 2022 07:01:14 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vjLRodPhGs7KOCD0AFNw1tnNLM+yuCjRWZbL9aR4jBm307MfZkBXl4j9QOQlnsx/9J80/b X-Received: by 2002:a05:6402:43cf:b0:43b:d65e:2002 with SMTP id p15-20020a05640243cf00b0043bd65e2002mr838634edc.91.1658498473903; Fri, 22 Jul 2022 07:01:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658498473; cv=none; d=google.com; s=arc-20160816; b=tczeAojcrEFVIf/Dgu9Ndf02a9jTwJ8DghNydt6HUw2HPjjhKvGQWW1iz+We3Xhsk0 LyVHT5LQmuA0m9r85wCdbwDGbcJ1hND5uNki1xoPk3qI3wfghTLE/wbS4VuwzO86RoFr 8fe9dWpij/H0glHQmuIxnH17WcAcK5NRBwN1rUlENo5Q3v9Egj8uHvWHwF9DrEggGLWC 8uX8UakXL41gffmwYXL05l/KYr2Hwz+4aHtTuYK/EiLchkXoMHBItBAD8HycaaCasLXe DP/p9Z4gRmIK/70+vpn8CFhc1lEYq5nO3rGZqlnu2VJI5eR7pnPd/rIj4o1YC3FN84Ur eOdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7n681hZd+dwrHFbW5+woRzLcfpQI3pxHEssya9/He1U=; b=OSOaTwAcwuNVw4Ksy9svIvZWKXRpNntZb0+MaTMrC70pzxxBJExZobkNwB1MHtkm09 EmwU4601GBRbOHXmBbeWsu9YZrK1zwyhoESS8tUyKwf7T3ARzaZgFOacumQAvsEsF0on H3lWkyNkrD8OUFvqxokv8GfUTtAV4MCV4AXcXvOLpRGuEjJbhdvU+9PpeDauM5eZGnIC Gtb2Jd2KImP9ysiFwYWlYUNO9YkGZlGMzVg/49bziUbpEbqrhWhcJ3SvpIGpfHf1IjAP mCdam3qcu+SZcPKNq6eBwX+1RQth4wVVhMQjfSFmijVPeBPfTxtsvFXbhUsHd62dAxQY o4Qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=AKyxFvEB; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n12-20020a05640205cc00b0043a50fda151si7020820edx.434.2022.07.22.07.00.48; Fri, 22 Jul 2022 07:01:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=AKyxFvEB; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235443AbiGVN7N (ORCPT + 99 others); Fri, 22 Jul 2022 09:59:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235292AbiGVN6v (ORCPT ); Fri, 22 Jul 2022 09:58:51 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CC4792869; Fri, 22 Jul 2022 06:58:43 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-118-63.bstnma.fios.verizon.net [173.48.118.63]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 26MDwR84016700 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Jul 2022 09:58:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1658498309; bh=7n681hZd+dwrHFbW5+woRzLcfpQI3pxHEssya9/He1U=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=AKyxFvEBnZqeN4JyETkpWdhOS3+uv/c2N2pWZBXPKYloPTW2sQbn8iJUNZeLN0r1E 1MDb5trwcLkiB80P+6dsI/skKLyNuwMHARZFr/ouTOh+P8cmSwNRJwxH1US0C2R86d TCgbWI72sjO3HdJeWKmC4pGYkfrHX8BRR+gKRJSq+AsGUKu9gyOmksJfkY/wdAbd1T RZ1NZrP/Awdgvmy+EgnhkBFPZr6tJkkONtrnAJGCghKjglhQmD3yVT2m0nPwPUTwMR c4zD7iJOUVShbRhH/bIpe8/uApMiqLlQzFPkRaKEns+4PppuYhdMXYqM8A4djTM183 usFxghWp9mTLA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 6B2BB15C3F00; Fri, 22 Jul 2022 09:58:27 -0400 (EDT) From: "Theodore Ts'o" To: Jan Kara Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, Ritesh Harjani , stable@vger.kernel.org Subject: Re: [PATCH 01/10] mbcache: Don't reclaim used entries Date: Fri, 22 Jul 2022 09:58:14 -0400 Message-Id: <165849767595.303416.835565204310722952.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220712105436.32204-1-jack@suse.cz> References: <20220712104519.29887-1-jack@suse.cz> <20220712105436.32204-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, 12 Jul 2022 12:54:20 +0200, Jan Kara wrote: > Do not reclaim entries that are currently used by somebody from a > shrinker. Firstly, these entries are likely useful. Secondly, we will > need to keep such entries to protect pending increment of xattr block > refcount. > Applied, thanks! (Some slight adjustments were needed to resolve a merge conflict.) [01/10] mbcache: Don't reclaim used entries commit: ee595bcf21a86af4cff673000e2728d61c7c0e7b [02/10] mbcache: Add functions to delete entry if unused commit: ad3923aa44185f5f65e17764fe5c30501c6dfd22 [03/10] ext4: Remove EA inode entry from mbcache on inode eviction commit: 428dc374a6cb6c0cbbf6fe8984b667ef78dc7d75 [04/10] ext4: Unindent codeblock in ext4_xattr_block_set() commit: d52086dcf26a6284b08b5544210a7475b4837d52 [05/10] ext4: Fix race when reusing xattr blocks commit: 132991ed28822cfb4be41ac72195f00fc0baf3c8 [06/10] ext2: Factor our freeing of xattr block reference commit: c30e78a5f165244985aa346bdd460d459094470e [07/10] ext2: Unindent codeblock in ext2_xattr_set() commit: 0e85fb030d13e427deca44a95aabb2475614f8d2 [08/10] ext2: Avoid deleting xattr block that is being reused commit: 44ce98e77ab4583b17ff4f501c2076eec3b759d7 [09/10] mbcache: Remove mb_cache_entry_delete() commit: c3671ffa0919f2d433576c99c4e211cd367afda0 [10/10] mbcache: Automatically delete entries from cache on freeing commit: b51539a7d04fb7d05b28ab9387364ccde88b6b6d Best regards, -- Theodore Ts'o