Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 22 Jul 2022 23:11:14 +0800
From:   Zorro Lang <zlang@redhat.com>
To:     Sun Ke <sunke32@huawei.com>
Cc:     Theodore Ts'o <tytso@mit.edu>, fstests@vger.kernel.org,
        linux-ext4@vger.kernel.org
Subject: Re: [PATCH v3 1/2] ext4: resize fs after resize_inode without e2fsck
Message-ID: <20220722151114.c4w7s6v6fu5hphf5@zlang-mailbox>
References: <20220713092859.3881376-1-sunke32@huawei.com>
 <20220713092859.3881376-2-sunke32@huawei.com>
 <20220714154607.qq6cqgvncxhsn66w@zlang-mailbox>
 <YtCSAjiMc9RElnHu@mit.edu>
 <20220715180815.gegmapvruor6vin3@zlang-mailbox>
 <b424fd69-aeb4-f749-d09b-5d824454dd94@huawei.com>
 <YtqPXcFbbrFBr1om@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <YtqPXcFbbrFBr1om@mit.edu>
Precedence: bulk

On Fri, Jul 22, 2022 at 07:51:57AM -0400, Theodore Ts'o wrote:
> On Fri, Jul 22, 2022 at 04:16:26PM +0800, Sun Ke wrote:
> > 
> > 1. The test run fsck automatically, and complain inconsistent，I think it
> > need not run fsck.
> 
> The check script always run fscks after the test.  In order to
> suppress the fsck complaint, we'll need to add this after the
> resize2fs invocation:
> 
> _scratch_unmount
> $DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 0" $SCRATCH_DEV \
>         >>$seqres.full 2>&1
> 
> This resets the s_reserved_gdt_blocks field back to zero, so the fsck
> doesn't fail.  Which is fine, because the point of the test is to see
> whether the kernel dereferences a NULL pointer or not.

Or maybe just replace _reuqire_scratch with _require_scratch_nocheck, if we
corrupt the fs on SCRATCH_DEV intentionally?

Thanks,
Zorro

> 
> > 2. It warn missing kernel fix, but the commit had merged.
> 
> The way _fixed_by_kernel_commit works is if the test fails (for any
> reason), it prints that you MAY be missing the bugfix commit:
> 
> > HINT: You _MAY_ be missing kernel fix:
> >       b55c3cd102a6 ext4: add reserved GDT blocks check
> 
> 		     	       		- Ted
>