Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp795897imi; Fri, 22 Jul 2022 09:38:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vUblwUvhca7d2jGzGNyGUn2PpoEkOjPKi0wgMSasDRCeym2B0GzS3ytFznwdnloUEIqLEX X-Received: by 2002:a05:6402:1b03:b0:43b:c8df:bc43 with SMTP id by3-20020a0564021b0300b0043bc8dfbc43mr747169edb.174.1658507914879; Fri, 22 Jul 2022 09:38:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658507914; cv=none; d=google.com; s=arc-20160816; b=Q1dAnTUwMEmi0GMoTyweF8THzWJINaqKf4iDVHDREt5m7RMq0AqO7s4Tx4RN2iYhPC IaOOO9SgngR/FYaV7NUZ29iyN+XAolq/ReM9BhooJY09fDu2jXptm5er0gvUD4YQoqCu 6soeAnEqRjCWuRsD7CJgfp9pLCW96igUWblVBG3Zoagf9A+fNpSOPp2FYfn3Fk8PQZ2S h04Ra5/1PF5tY8QwKP4swP2hryepRCFJzB5xq4iOspJVhI2Dql7oojhxwbri7L6TNk/F ErwV1+ckdM3V7iJhACBQf4nOwOmGw/z6ZVPij2lIR38mHzzxHKbnZme1vAAYwQ+fzjEe 6ZMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=V4B0S7YlVC/I6JJKkg4wR+2YzppJ/F016/91YQyybNY=; b=jRN9A20RvNWpVcDZBYB9d4S2G1ZJyaKEZSX1c/YvalpFiJ1Gdbm8GM1okXWvmPg8Dx UIJesLtcMkEgcUelffI6SM6a7OWRk0IO+puUz+CUhoBK12Db3fWOJUMv4CFPwvq4kyNj +IGkltd2f7cCl8/fGGQlWXhqtMPlyjQri73pgI0sqvSUlVgFtKfcUPPKiTbNeA3rLh4E ABWbyGamW2QY92yGqtQ+bBK8lT1bV1M6ciQo5/Pku+++wCz9KYVOt/oA14DIYRFktQsS R1pdWMLsaBClcFtT09xxXKqLc18da1bgdlHIHxZK8BpuLymVYGaivbu71/XokzRShcsL 4ZLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=WwPmIZpP; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k17-20020a05640212d100b0043bbb19a3b4si5175311edx.174.2022.07.22.09.38.09; Fri, 22 Jul 2022 09:38:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=WwPmIZpP; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234012AbiGVQhR (ORCPT + 99 others); Fri, 22 Jul 2022 12:37:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229567AbiGVQhR (ORCPT ); Fri, 22 Jul 2022 12:37:17 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E80FF93694; Fri, 22 Jul 2022 09:37:15 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-118-63.bstnma.fios.verizon.net [173.48.118.63]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 26MGaxo1007545 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 22 Jul 2022 12:37:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1658507820; bh=V4B0S7YlVC/I6JJKkg4wR+2YzppJ/F016/91YQyybNY=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=WwPmIZpPGwXATxQ5Mpx5IszodLJJdsnNqzyV6W+P7IG3c7rSLUkSyakfeG/TvJvYS iR7Ro+p+g512QJmiP5dh1f+KIKnQFOlFmu/EALiaLVT9PcuHXMWw6TSxR5tExXwmZB USUT+3rauJtGeWA1H8SGEv+T7+ZyCHfGXNXz1HOVhvzFcrMyqma6CGz39waCnN1AI1 5l9WCnX7VXUDohBK9bx1oPJzd5Swecgb8UvECBHBkVRxbuPK7m4n8CpFQQwlos9vPv iBKH9hevuXuWpBv55YkLdW0HjpY0GdT3lLAuL6cQD3iJKi4FxN7vVG9GHogk5HN6h/ Gy4GUOwDgCqUw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 215ED15C3EF7; Fri, 22 Jul 2022 12:36:59 -0400 (EDT) Date: Fri, 22 Jul 2022 12:36:59 -0400 From: "Theodore Ts'o" To: Zorro Lang Cc: Sun Ke , fstests@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH v3 1/2] ext4: resize fs after resize_inode without e2fsck Message-ID: References: <20220713092859.3881376-1-sunke32@huawei.com> <20220713092859.3881376-2-sunke32@huawei.com> <20220714154607.qq6cqgvncxhsn66w@zlang-mailbox> <20220715180815.gegmapvruor6vin3@zlang-mailbox> <20220722151114.c4w7s6v6fu5hphf5@zlang-mailbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220722151114.c4w7s6v6fu5hphf5@zlang-mailbox> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Jul 22, 2022 at 11:11:14PM +0800, Zorro Lang wrote: > > This resets the s_reserved_gdt_blocks field back to zero, so the fsck > > doesn't fail. Which is fine, because the point of the test is to see > > whether the kernel dereferences a NULL pointer or not. > > Or maybe just replace _reuqire_scratch with _require_scratch_nocheck, if we > corrupt the fs on SCRATCH_DEV intentionally? Agreed, that would be a better solution. - Ted