Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org,
        linux-api@vger.kernel.org, linux-fscrypt@vger.kernel.org,
        linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
        Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v4 1/9] statx: add direct I/O alignment information
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1fsitjbqn.fsf@ca-mkp.ca.oracle.com>
References: <20220722071228.146690-1-ebiggers@kernel.org>
        <20220722071228.146690-2-ebiggers@kernel.org>
Date:   Fri, 22 Jul 2022 13:31:37 -0400
In-Reply-To: <20220722071228.146690-2-ebiggers@kernel.org> (Eric Biggers's
        message of "Fri, 22 Jul 2022 00:12:20 -0700")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Dzwd96FM8nx1tGBiG/ngGu2aqEf+U1Pt98lTe06EWBn5NBUAtAZ8LkLXT8Xk?=
 =?us-ascii?Q?WiH9faQotWRDBj9PsPQ7Eqxb5kRPWmoFSAsYlJ2GOqDVhg4tZRvnxzGWYoBB?=
 =?us-ascii?Q?HwZZso2kpDH8imV2IMQJSLzQkWAsK/W0mUBfITXGVdmDYLth+bpIGX7TMXwY?=
 =?us-ascii?Q?dvskNhd9fTLdmH9U/Mcy3e8uAEGWWU+auoD8FdZLZqqm78Zrqx0gaabrf6Zj?=
 =?us-ascii?Q?iRKpMReNh7hXera41veaKenT93jAkYpWDQAayb29x5xUy4XW3npPWydgvU1X?=
 =?us-ascii?Q?FTQPxVtVIaMJ2nebTxrllnmU6SkRidYK6PplLRiRpclW0LauxPy+253CIzEB?=
 =?us-ascii?Q?NxKKyoVijpmQZuELqW7i9JwsP7MCZ+WeUa8CtzcAB3or9fzjoo/g707jbONI?=
 =?us-ascii?Q?VwS+cSdVQ90wpxNcXzwU82Liu5LDvBOhG9CzR1KD5waYkJaG6KIqmmxbK8kl?=
 =?us-ascii?Q?LGs/7Boma4GWHupx54lkg4g3HSIIuF5GYBQ+rupMlm8X5nfCjCJ7ZEBuU3z7?=
 =?us-ascii?Q?ZAbl50aaPsEQWpxxh8axicBr3vee3wV9lo0b+d73+jbKgNnDUGfGeWW8pZcB?=
 =?us-ascii?Q?nG8AQn93XdZIee6jH75CZEZ8QenGC4fxaDsRNKUufWGyYs0Le80aWNhqBIhJ?=
 =?us-ascii?Q?SLp9qDeN3Vfw83MHut8sWUWArASOLrmFu/6SmZgwtoUmZmrD/zXX5R2IOl9E?=
 =?us-ascii?Q?gTFydH7l/DRcuJYjGkfxoMJy3z9QM8F4xGznQLW9CxwZjOk/UAn6rUtuFO7H?=
 =?us-ascii?Q?4JvNgEXY9uIoQD6AI5WlHWx42KqZLYbgDu15PFScwf1VDsl6AljKX0OdGysl?=
 =?us-ascii?Q?fDrt2zCon6qJ+nAVFlhG8sGdeMlUc0bD/WaKTEsZISJc9/0ldIxkPG1Jdbwq?=
 =?us-ascii?Q?pWeSwnqOMxO1FrmdS0SqOcbPPq09NxdmHP24E7jV+RAWoOQAkZbI7y+Y8ndZ?=
 =?us-ascii?Q?RUokigI6EDVG23Lf8zYxvcUSD6MdOnoH28dNXPbw+77wgXXHZQnQ2G30m6pP?=
 =?us-ascii?Q?bEhS56g7NXOfRJllFdAxT12OjGTgVaciLrc/jHVXa9xKSufnUJhzmJ+uDVtg?=
 =?us-ascii?Q?HiLV/CosQDeN3aayA9GBhtvepeEM5vOd3Dt5xd3GMgOhnF93HSQQxWHJgowO?=
 =?us-ascii?Q?LBNoMilzo5ZelMWGSOwix552NMOwVGORtM8LH99iOCEUyIs4y5az0My9CROW?=
 =?us-ascii?Q?9kCam7ydH0tHq1rGjQuaWL/9wYGngAlLn4L0bJ1909eWjpGANuhyGiG0/bTr?=
 =?us-ascii?Q?qELzKcjp/VWhzAMNz3RKc4854UneUOoGLdgv0iTlyF066djmEZvJUpPosFi1?=
 =?us-ascii?Q?Z6VzxvCNCD4Bn6KQlbKZ9JWVLf5ZgX6FoQ69i31PuXzhXrD5s3pg0TKaO9t4?=
 =?us-ascii?Q?ULIMFKZYEv0YxFIV3I6IQxx3QqVhIBArv1uvR7D4351vVV7beFT6IkqInX1Q?=
 =?us-ascii?Q?+E3JFkVSWvFozNvmluM1cJMqFMgK/dlksXathqoLFKe4xMW2qtMtHLZHMeGM?=
 =?us-ascii?Q?efMQyhc8hoeetyCz19KzTIAomAsnPIZDYLUmZNjUACBsnBMvSrgUM3bfwAhT?=
 =?us-ascii?Q?zGh7T74yfFCE3Rp4g15Jst5VSyGBlzJUaj1avxR9oztpUEnq2AvejAd8L6+y?=
 =?us-ascii?Q?2g=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24dd708a-b4df-403b-29f8-08da6c080951
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 17:31:39.9761
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +VL3DpcVUUBMVCpsskuI04bS5wLmfRP3XfSUQA8ToWejXGHVlbSLGTxBqxTAvTy2aDqB30KRGGmwnYwLLSbFCI+9f1gMIhWgaO4vyUx9j0M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3828
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-22_06,2022-07-21_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 adultscore=0 spamscore=0 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207220073
X-Proofpoint-GUID: HWlmaJ5ZR3HLVBjfYQxsutj3rKOxGw4j
X-Proofpoint-ORIG-GUID: HWlmaJ5ZR3HLVBjfYQxsutj3rKOxGw4j
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org


Eric,

> Therefore, let's expose this information via statx().  Add the
> STATX_DIOALIGN flag and two new statx fields associated with it:
>
> * stx_dio_mem_align: the alignment (in bytes) required for user memory
>   buffers for DIO, or 0 if DIO is not supported on the file.
>
> * stx_dio_offset_align: the alignment (in bytes) required for file
>   offsets and I/O segment lengths for DIO, or 0 if DIO is not supported
>   on the file.  This will only be nonzero if stx_dio_mem_align is
>   nonzero, and vice versa.

Nice to finally have a generic interface for this!

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering