Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <adb2031b-774d-e645-2aec-f9de433b0a7c@amd.com>
Date:   Mon, 25 Jul 2022 21:22:06 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v9 06/14] mm/gup: migrate device coherent pages when
 pinning instead of failing
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>
Cc:     jgg@nvidia.com, Felix.Kuehling@amd.com, linux-mm@kvack.org,
        rcampbell@nvidia.com, linux-ext4@vger.kernel.org,
        linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com,
        apopple@nvidia.com, willy@infradead.org
References: <20220715150521.18165-1-alex.sierra@amd.com>
 <20220715150521.18165-7-alex.sierra@amd.com>
 <225554c2-9174-555e-ddc0-df95c39211bc@redhat.com>
 <20220718133235.4fdbd6ec303219e5a3ba49cf@linux-foundation.org>
From:   "Sierra Guiza, Alejandro (Alex)" <alex.sierra@amd.com>
In-Reply-To: <20220718133235.4fdbd6ec303219e5a3ba49cf@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TDJmTnUwL0ZNTk11czEwREg4QzhUY01wNDUvYkNFOHRIajVKdkUrN2pOWmc2?=
 =?utf-8?B?QnRTV2R2aXRxYXNBd09wZE5pbDgyc1BXZ0srRGtTZlN4cGxwQ0xOeFQ3V3I0?=
 =?utf-8?B?QU1VWlF2KzQ3TGJsRnVwK0JOVlNTamk0cURqRW5Qbys0WnF0WmttUVpjQWsr?=
 =?utf-8?B?MWI1SkxRcXBRNjkzSTd5TWt6VFIrbGZmNy9oYUxZZDkyTXNKYUJrbFhadkY0?=
 =?utf-8?B?Mk1qMGI1OFBPaWtYM1IveEFjb2VFR042eDZmdEg1UU1oVzJaTEdObFJxUGZU?=
 =?utf-8?B?K2h4TkRmTTkvOGNBL0R2WGppWHZwZ0xycUR0ZWszNE5FSDFGWEZDZ29KcEpN?=
 =?utf-8?B?Z2pyR01sQ1AwTG16N0NhdkVPSnpHMmpHay9QdEJ3YUR2TzQ3TmpxWHZjaXdw?=
 =?utf-8?B?akpud0VWVHhKcU9hV1loaHVKWnB5VFNDbStxK3BOeGFwTzJGNjFOMGgwY0Vv?=
 =?utf-8?B?VDFCdTdYcVM4RXpaeU5EckVscTJZUkQwU0Y3c3Mwamc4NHA4YkhVK1N2OE1i?=
 =?utf-8?B?RTJaMEtrSldpTmFnbm9JS1B1OGlRQmt5ckd2RWVsbndiL0p2bjAwaVRjKzBW?=
 =?utf-8?B?bVRObFdPL2NtNjhHVHRvNk4rWmxSWXRBaTNob3hjalZTNjFkWU96UEE2cmov?=
 =?utf-8?B?V242UStpUDVxaFRwVCs3SktxMWppbnhhVlJGM0Uzd3hOYldsL2tkSXFTNW5R?=
 =?utf-8?B?aGdiZHMzVHNXU0IvanoxNWUxYmxpeGx6b2ZVTE9UK2ovS0ZvOUhFbC9hYkxp?=
 =?utf-8?B?c0ZEMEU2aDZOTS9GZmdSQkhYeUF4dTc2bHNKME5oS1hCNTNMSmlnWG8vOG5C?=
 =?utf-8?B?ZTBRamFBNDByMWpOcFJiU1A3SEpTSGhQOXFBQ3lubUZvODRmNFc4MTRVcCtp?=
 =?utf-8?B?RjhMUnZWTHV4eUVMRXhFclpPOGM1NjVSdE40V2xZbzFHTGd1RXpPRXM1ZGpn?=
 =?utf-8?B?M0FjMHB4QWR0TnlKMEpMYWpvcTJXdnBDTVllWGNYU1FsV2RLSDYvWkNYbER1?=
 =?utf-8?B?VXJSVjViU3Npd2dlUXFPZzgvazdvb1lreTNQbVdSNGo2V2p2a3NTeCtDMENJ?=
 =?utf-8?B?MjRDM0FwclRWZzVCN1gxakloek5VQ3VtZ2QvbjBEMXIyOVBpeDRQRWhtU1NP?=
 =?utf-8?B?dDZGV2JxQjBUOFR4UVc4dTQ3TGlacXdtYzBRUTN6U3BscU1reDVWbnhpejUw?=
 =?utf-8?B?L0xaTFg3eTNRMDVkZkpKRHhOZTEzcGUrSVpNejQ5WCtMWlR5aC9yUHpFOHNM?=
 =?utf-8?B?bXNwZENTSUpEdkxxcCthTDRqYXZyOUFXK3VWMXQ4dDg4OS9obUthS2ZUdHl3?=
 =?utf-8?B?aFhrbjNxcWR2eE5ZQzNRWDRYbWwrVzlObnVaWWdSTktqMEJySDJ5UjA2MTdq?=
 =?utf-8?B?amUwMGNYUkhOMDNTUENoSDZyemRBYVdsa0FNMjJOVFNXaERsekNBY1ZHYnVj?=
 =?utf-8?B?bXo1bnBDSGJQVFhFcHVHNW5qM1p5QlVxalBxdFNDcUNEMHRUSlVUS0drMHJE?=
 =?utf-8?B?NDRkRkpJbmRIYUFYVGNjcm1HajBvaTJ1NnIrbm4xQzlJYm5DbE12REE2ZDNz?=
 =?utf-8?B?QjJqajZHQnVZUmxxRFgxOEFXVlBDV0JrU0tVYzBIZkNYdWU0OWdWYjg1SkRQ?=
 =?utf-8?B?bFREKy9FTFUrS0tSVFZUYVkvU01RR0xPaUQ2U3RtMExZODFybGR2dzhzUWZT?=
 =?utf-8?B?Y2I4bWQxMlFQZVVQUndhb0huaGlhY0VqamVSVkFWZWpuT1NOU2p0dGg5SVZ3?=
 =?utf-8?B?bzBSN0Y2R3ZHWEpjRWRJWW5Ma3hOLzlVYzQ4Wm83eU1BTzRaN0JyKy9hRThZ?=
 =?utf-8?B?WXhvamFFSUJieHBzOTZTR3JRMDBHR3hMTXpNbGpSdnptN2tvMW9sam96cDJn?=
 =?utf-8?B?L2JkaFU4dFl0RzJPMEI5SzBrN0d1NEI3MFBhb0NERW5FMGhFbHR1cXpGdzhN?=
 =?utf-8?B?TkRaRTZuT2kvRXd1M2tsdEFKRS9NZVJwcHdMd3l3T2tPeFcxeHRXcWpkdDN4?=
 =?utf-8?B?ZGpTeDlFL0tHVkNlNlRYdGJpbjM2NUVabFN1bGtHNnp2dEx5WThYaW1GNUVL?=
 =?utf-8?B?eWdjVEsyWCsvT2pvQzRoWE0wMGVCYlBOMU1UWjlNLzRocFFqRE5ob1A2U0Qv?=
 =?utf-8?Q?KcZ5DeuorR9JUR+u3KrogDN1D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c425227-7bb6-41e7-168d-08da6eada50b
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2717.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 02:22:10.6367
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x5/1s3anPTCfAjzWLDj2205eYAz9oolwUU4OZ1a/TvSoazCEtQ8l1eoqYYKLU3J0j58jAPw8mYfItr2lz/eroA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1481
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org


On 7/18/2022 3:32 PM, Andrew Morton wrote:
> On Mon, 18 Jul 2022 12:56:29 +0200 David Hildenbrand <david@redhat.com> wrote:
>
>>>   		/*
>>>   		 * Try to move out any movable page before pinning the range.
>>>   		 */
>>> @@ -1919,7 +1948,8 @@ static long check_and_migrate_movable_pages(unsigned long nr_pages,
>>>   				    folio_nr_pages(folio));
>>>   	}
>>>   
>>> -	if (!list_empty(&movable_page_list) || isolation_error_count)
>>> +	if (!list_empty(&movable_page_list) || isolation_error_count
>>> +		|| coherent_pages)
>> The common style is to
>>
>> a) add the || to the end of the previous line
>> b) indent such the we have a nice-to-read alignment
>>
>> if (!list_empty(&movable_page_list) || isolation_error_count ||
>>      coherent_pages)
>>
> I missed that.  This series is now in mm-stable so any fix will need to
> be a standalone followup patch, please.
Hi Andrew,
Just wanted to make sure nothing is missing from our side to merge this 
patch series.

Regards,
Alex Sierra
>
>> Apart from that lgtm.
>>
>> Reviewed-by: David Hildenbrand <david@redhat.com>
> And your reviewed-by's will be lost.  Stupid git.