Received: by 2002:ac0:e34a:0:0:0:0:0 with SMTP id g10csp895550imn; Tue, 26 Jul 2022 12:18:46 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vQZpqLwELCvWr3t0Ve1eBNABJiU2MonZd5exxMSYRxDznAPq68vy2/BZuY50JVcjYsxSzZ X-Received: by 2002:a05:6402:b7b:b0:43c:90c0:86cc with SMTP id cb27-20020a0564020b7b00b0043c90c086ccmr1927753edb.247.1658863125964; Tue, 26 Jul 2022 12:18:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658863125; cv=none; d=google.com; s=arc-20160816; b=zy/1s256iMjo0Pq+xzRsQVXQzx1RYh4c57uMbS3B5pEc1hALkeOYZ8B+VmuILmEIxP W/IB31mXTtH5yi392VEUTQj6SvReLUbmYvJzwcdKeC01HTzi/QmO4Wr358GB/nidSFOJ BscZfqKbf1vE00ytGrPaJ1gIsrtfUlc6Iq7CDSIKU2oTPrNj4sSz6YyJkp2REw/OG69v Sly64QosvZQn7egstpamu4zq+U9lRbHyvmtvtOl4cnsK8dWIpu8p4dlJZ5mHHsPzJjHw ry2K9FXtkEHnOuZwiVe4d9r1u/6wCXPFeHrT1UzHkSWERcI9ZMFD2Yr60pxLamtDWy5a QL3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=MzZXP/vj/Abz2WtBVVozJ7dXPkYbx3otQAg0rA87LoQ=; b=DSpNy2t1sibzjgqJw8XPT/rmPbSn18ebS9+Wi8u/6SaxZZOHiq52Hi36mf0StM8x58 TD63CmgiO5TLA8wbzMV8r3XpU+ioLNXogTk5FeVyvBZIN1fdrb+/gYbYk7UcRcs5C5JW bdd1KzQkl/o8vHHRBtJTuiDXQAXk1Tvo0GX3M5dlCabIpBtWs+1PVKr2v0yfl9RGA8mZ l5/vNSHA1Ovu3vuODtAOAl/W2MFY1aXqLlvAohvmsIAXYAo8bjVayctzfhktj5zSuGao S5WE+LoX1urZXiEWV8e8KtuZZuXuo1ZOE/4D14M4QhNTl002NNPQ+/681jmIT8hZR0UO 8vzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=jtWtbCvK; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dk15-20020a0564021d8f00b0043c981d12desi526861edb.507.2022.07.26.12.18.10; Tue, 26 Jul 2022 12:18:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=jtWtbCvK; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231810AbiGZTFL (ORCPT + 99 others); Tue, 26 Jul 2022 15:05:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239738AbiGZTFK (ORCPT ); Tue, 26 Jul 2022 15:05:10 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0046FC4B; Tue, 26 Jul 2022 12:05:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AA4C3B819C5; Tue, 26 Jul 2022 19:05:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7469C433C1; Tue, 26 Jul 2022 19:05:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1658862306; bh=8HO1+0RNEW20BOdzYYpK3e0czzp1ctqmJl8m1mL5930=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jtWtbCvK3nAkuqT2HuiCQ7VGsG6UUqOPsV6eZjfDx6mo6ENgUYGB52rsb2vBlQWwz w2cz8xupjrK9I0ISykF/uaB+onTvwra4lMAK6ilCsMeHDnXFebfJemPcSOKKQIAeVv eDoEcuJScyoa0uvCKR+qZSe8ejnDGj1gw5J79dF0= Date: Tue, 26 Jul 2022 12:05:04 -0700 From: Andrew Morton To: "Sierra Guiza, Alejandro (Alex)" Cc: David Hildenbrand , jgg@nvidia.com, Felix.Kuehling@amd.com, linux-mm@kvack.org, rcampbell@nvidia.com, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, hch@lst.de, jglisse@redhat.com, apopple@nvidia.com, willy@infradead.org Subject: Re: [PATCH v9 06/14] mm/gup: migrate device coherent pages when pinning instead of failing Message-Id: <20220726120504.39498eff3843baf1d8fd5168@linux-foundation.org> In-Reply-To: References: <20220715150521.18165-1-alex.sierra@amd.com> <20220715150521.18165-7-alex.sierra@amd.com> <225554c2-9174-555e-ddc0-df95c39211bc@redhat.com> <20220718133235.4fdbd6ec303219e5a3ba49cf@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 25 Jul 2022 21:22:06 -0500 "Sierra Guiza, Alejandro (Alex)" wrote: > >> a) add the || to the end of the previous line > >> b) indent such the we have a nice-to-read alignment > >> > >> if (!list_empty(&movable_page_list) || isolation_error_count || > >> coherent_pages) > >> > > I missed that. This series is now in mm-stable so any fix will need to > > be a standalone followup patch, please. > Hi Andrew, > Just wanted to make sure nothing is missing from our side to merge this > patch series. It's queued in mm-stable and all looks good for a 5.20-rc1 merge.