Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 27 Jul 2022 20:07:32 +0800
From:   Zorro Lang <zlang@redhat.com>
To:     Sun Ke <sunke32@huawei.com>
Cc:     fstests@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v5] ext4: resize an ext4 which resize_inode feature is
 disabled but has reserved GDT blocks.
Message-ID: <20220727120732.3645x57voyfozujz@zlang-mailbox>
References: <20220727071140.3886185-1-sunke32@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220727071140.3886185-1-sunke32@huawei.com>
Precedence: bulk

On Wed, Jul 27, 2022 at 03:11:40PM +0800, Sun Ke wrote:
> A regression test for b55c3cd102a6 ("ext4: add reserved GDT blocks
> check"). Make sure there's not kernel crash, if resize an ext4 which
> resize_inode feature is disabled but has reserved GDT blocks.
> 
> Signed-off-by: Sun Ke <sunke32@huawei.com>
> ---

This version looks good to me, if no more review points from ext4 list,
I'll merge it.

Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/ext4/057     | 41 +++++++++++++++++++++++++++++++++++++++++
>  tests/ext4/057.out |  2 ++
>  2 files changed, 43 insertions(+)
>  create mode 100755 tests/ext4/057
>  create mode 100644 tests/ext4/057.out
> 
> diff --git a/tests/ext4/057 b/tests/ext4/057
> new file mode 100755
> index 00000000..969da377
> --- /dev/null
> +++ b/tests/ext4/057
> @@ -0,0 +1,41 @@
> +#! /bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +# Copyright (c) 2022 HUAWEI.  All Rights Reserved.
> +#
> +# FS QA Test 057
> +#
> +# A regression test for b55c3cd102a6 ("ext4: add reserved GDT blocks check").
> +# Make sure there's not kernel crash, if resize an ext4 which resize_inode
> +# feature is disabled but has reserved GDT blocks.
> +#
> +. ./common/preamble
> +_begin_fstest auto resize quick
> +
> +# real QA test starts here
> +_supported_fs ext4
> +_fixed_by_kernel_commit b55c3cd102a6 \
> +	"ext4: add reserved GDT blocks check"
> +
> +_require_command "$RESIZE2FS_PROG" resize2fs
> +_require_command "$DEBUGFS_PROG" debugfs
> +_require_scratch_size_nocheck $((1024 * 1024))
> +
> +# Initalize a 512M ext4 fs with resize_inode feature disabled
> +dev_size=$((512 * 1024 * 1024))
> +MKFS_OPTIONS="-O ^resize_inode $MKFS_OPTIONS" _scratch_mkfs_sized $dev_size \
> +	>>$seqres.full 2>&1 || _fail "mkfs failed"
> +
> +# Force some reserved GDT blocks to trigger the bug
> +$DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 100" $SCRATCH_DEV \
> +	>>$seqres.full 2>&1
> +$DEBUGFS_PROG -R "show_super_stats -h" $SCRATCH_DEV 2>/dev/null | \
> +	grep "Reserved GDT blocks"
> +
> +_scratch_mount
> +
> +# Expect no crash from this resize operation
> +$RESIZE2FS_PROG $SCRATCH_DEV 1G >> $seqres.full 2>&1
> +
> +# success, all done
> +status=0
> +exit
> diff --git a/tests/ext4/057.out b/tests/ext4/057.out
> new file mode 100644
> index 00000000..99423e16
> --- /dev/null
> +++ b/tests/ext4/057.out
> @@ -0,0 +1,2 @@
> +QA output created by 057
> +Reserved GDT blocks:      100
> -- 
> 2.13.6
>