Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 3 Aug 2022 15:58:14 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Alexey Lyashkov <alexey.lyashkov@gmail.com>
Cc:     linux-ext4@vger.kernel.org, Andreas Dilger <adilger@dilger.ca>,
        Artem Blagodarenko <artem.blagodarenko@gmail.com>
Subject: Re: [PATCH] e2fsprogs: avoid code duplication
Message-ID: <YurTVlGWqwym2Hgg@mit.edu>
References: <20220803075407.538398-1-alexey.lyashkov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220803075407.538398-1-alexey.lyashkov@gmail.com>
Precedence: bulk

On Wed, Aug 03, 2022 at 10:54:07AM +0300, Alexey Lyashkov wrote:
> debugfs and e2fsck have a so much code duplication in journal handing.
> debugfs have lack a many journal features handing also.
> Let's start code merging to avoid code duplication and lack features.

This is definitely worth doing, and as you've pointed out, there are a
number of features which are in e2fsck/journal.c, which are not in
debugfs/journal.c.  The most notable one which I picked up on is the
fast_commit code --- which is in the master/next branch, but not in
the maint branch.

I suggest that we move the functionality into the libsupport library
first.  I want to make sure we get the abstractions right before we
"cast them into stone" by moving the functions to libext2fs.
Libsupport is not exported outside of e2fsprogs, so if we decide we
want to change function signatures, or make some functions private, we
can do that more easily if we experiment with moving things into
libsupport first.

						- Ted