Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp110120rwb; Wed, 10 Aug 2022 20:38:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR5fA349aUCPZIBBwyupmOZlEhQ9kJ54gO/IDAkWdM72yL/jft2GOE6Y5pVbqeF3B1BV/n5f X-Received: by 2002:a65:4848:0:b0:3fc:52c3:6ca5 with SMTP id i8-20020a654848000000b003fc52c36ca5mr24876430pgs.264.1660189130074; Wed, 10 Aug 2022 20:38:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660189130; cv=none; d=google.com; s=arc-20160816; b=F3GGynRmavTb9EfOxPnhB0hwpGtgHJGQD6W+thy2Hj1lx7v0KK6VcsMV697hBKRB0/ WHksWXweizSNdfTiNdnoe+YjJMAdsyjbfUI9ORNalefs37Vp3hesmgIlV5XrGxv6vx1l eAXz6a8ZXRPb+ifJWlScXXyETYWVXPG1OC6q+rgiiPHHS5QSj9OF49psVdvLHOw5QUuP mXad8dN82DWkA86Tti5KCsPj814vTpTRVug+aB7SRs76xqOjROeCwU1fMy9NfYpkSXxR WJb6MBlKUFlWhLcZtqu7gmcOUbVDSj38++VcLnI9ynAKXeqfALaJMffaFMD/4+tJAy96 RPlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cfzkZkjWh/iJBOdhJ25KomYkKGtIXUQjC4hmQ+tsZqs=; b=mTll5i8eK5FK6wM7WIokVWbd29WqXzF8dWnLIfgZ2pQop+YDYcIo2VxUTZAT6alwyk jLDRdcNKYVqsR9sl73hBALRqbztIA2XiQUcw6ubbUD2l8ArwVfNYbufnnoTNBKhbgsIm GFz6PLriOGENPkdO1g1FgXmxP8y0n1qZa+KpMc1Jo+rpU6NtlKGmolfYYwV4OXRnYWE1 4OyMerGcn+4xzI1Ry4siDnmAa9FTA4Fr9172bpF4/kmrdcANhkYNoez7oN4kd3gY0Thq uPC7OSBAo+ShRU3bQom4DWmt13P9paZpEs51PuqizHiH4xuRQvQi6AtUqBkRvia/wWvo Am2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=YUnr5ztX; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d20-20020a63fd14000000b0041d773c031csi10344226pgh.129.2022.08.10.20.38.19; Wed, 10 Aug 2022 20:38:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=YUnr5ztX; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233668AbiHKDSj (ORCPT + 99 others); Wed, 10 Aug 2022 23:18:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231667AbiHKDSh (ORCPT ); Wed, 10 Aug 2022 23:18:37 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5BF97CB5C for ; Wed, 10 Aug 2022 20:18:34 -0700 (PDT) Received: from letrec.thunk.org (c-24-1-67-28.hsd1.il.comcast.net [24.1.67.28]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 27B3INWn018101 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Aug 2022 23:18:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1660187905; bh=cfzkZkjWh/iJBOdhJ25KomYkKGtIXUQjC4hmQ+tsZqs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=YUnr5ztXgrPprVW069WHqC/XBAmrPnW+cpAD4uyJsY45OZmpFbdVGfj39rlKGBBj/ 4vZEE3mg2tHp6QonZLtUlCuFcP0x6r5+QpdJmp1vAhPr6/Z1Q8a6kTLuHAhKUCj1gJ I4dMEbezhBwjG34GVlQO/FhfcQTOGwAwzhXNEVR8yNhJ41Vr1/YHpEXLliTmN+3kOL e14IioiSSqhCHHwljbJKW6cJoZ1hRsr4/l7WVaZxI0lhrwxDRkeA6cyqeVYdhOkwNK eHdNyGIunOdPBzpV466oUcCQKDFB4HYiOePGYDJqht1w+IfK0ECLG3aqu4frJB97Da 4o3CnatDdYIGg== Received: by letrec.thunk.org (Postfix, from userid 15806) id 8FCEE8C2E04; Wed, 10 Aug 2022 23:18:23 -0400 (EDT) Date: Wed, 10 Aug 2022 23:18:23 -0400 From: "Theodore Ts'o" To: Lukas Czerner Cc: linux-ext4@vger.kernel.org, Daniel Ng Subject: Re: [PATCH] e2fsprogs: fix device name parsing to resolve names containing '=' Message-ID: References: <20220805094703.155967-1-lczerner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220805094703.155967-1-lczerner@redhat.com> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Hi Lukas, Could you move get_devname() into its own file in lib/support? e.g., create a devname.c and devname.h. The reason for this is that plausible.c tries to call libmagic via dlopen() so we don't need to drag libmagic into the minimal package set for distros. But that means that any executiables that try to use devname() will drag in lib/support/pausible.c, which means if you don't change the makefiles to link in -ldl, static linking will fail: - Ted