Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 11 Aug 2022 05:32:02 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     "Darrick J. Wong" <djwong@kernel.org>
Cc:     guaneryu@gmail.com, zlang@redhat.com, linux-xfs@vger.kernel.org,
        fstests@vger.kernel.org, guan@eryu.me, tytso@mit.edu,
        linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/3] common/rc: move ext4-specific helpers into a
 separate common/ext4 file
Message-ID: <YvT2wslkHNKKuDY8@infradead.org>
References: <166007884125.3276300.15348421560641051945.stgit@magnolia>
 <166007884681.3276300.8815951431509313240.stgit@magnolia>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <166007884681.3276300.8815951431509313240.stgit@magnolia>
Precedence: bulk

On Tue, Aug 09, 2022 at 02:00:46PM -0700, Darrick J. Wong wrote:
> --- a/common/config
> +++ b/common/config
> @@ -512,6 +512,10 @@ _source_specific_fs()
>  		;;
>  	ext4)
>  		[ "$MKFS_EXT4_PROG" = "" ] && _fatal "mkfs.ext4 not found"
> +		. ./common/ext4
> +		;;
> +	ext2|ext3|ext4dev)
> +		. ./common/ext4

Not really new in this patch, but why does ext4 check for a specific
mkfs and the others don't?

Also can we drop ext4dev while we're at it?

The patch itself looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>