Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 12 Aug 2022 09:12:38 +0200
From:   Lukas Czerner <lczerner@redhat.com>
To:     Theodore Ts'o <tytso@mit.edu>
Cc:     linux-ext4@vger.kernel.org, Daniel Ng <danielng@google.com>
Subject: Re: [PATCH] e2fsprogs: fix device name parsing to resolve names
 containing '='
Message-ID: <20220812071238.d766gj3do7clwhdn@fedora>
References: <20220805094703.155967-1-lczerner@redhat.com>
 <YvR0/wmZgf1HwidK@mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YvR0/wmZgf1HwidK@mit.edu>
Precedence: bulk

On Wed, Aug 10, 2022 at 11:18:23PM -0400, Theodore Ts'o wrote:
> Hi Lukas,
> 
> Could you move get_devname() into its own file in lib/support?  e.g.,
> create a devname.c and devname.h.
> 
> The reason for this is that plausible.c tries to call libmagic via
> dlopen() so we don't need to drag libmagic into the minimal package
> set for distros.  But that means that any executiables that try to use
> devname() will drag in lib/support/pausible.c, which means if you
> don't change the makefiles to link in -ldl, static linking will fail:
> 
> 					- Ted

Ah, I didn't notice that. I'll move it into a separate file,
devname.[ch] sounds good.

Thanks!
-Lukas