Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 12 Aug 2022 14:19:47 +0100
From:   =?iso-8859-1?Q?Lu=EDs?= Henriques <lhenriques@suse.de>
To:     Baokun Li <libaokun1@huawei.com>
Cc:     Theodore Ts'o <tytso@mit.edu>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        wenqingliu0120@gmail.com, linux-ext4@vger.kernel.org,
        linux-kernel@vger.kernel.org, "zhangyi (F)" <yi.zhang@huawei.com>,
        yebin10@huawei.com, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: [PATCH v2] ext4: fix bug in extents parsing when eh_entries == 0
 and eh_depth > 0
Message-ID: <YvZTcxF2DdtVEybn@suse.de>
References: <20220812105347.2251-1-lhenriques@suse.de>
 <e32464ec-4c5b-dcad-cfe3-93727dab5f5b@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <e32464ec-4c5b-dcad-cfe3-93727dab5f5b@huawei.com>
Precedence: bulk

Hi Baokun!

On Fri, Aug 12, 2022 at 08:50:34PM +0800, Baokun Li wrote:
> Hi Lu?s,
...
> > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> > index 53cfe2c681c4..a5457ac1999c 100644
> > --- a/fs/ext4/extents.c
> > +++ b/fs/ext4/extents.c
> > @@ -460,6 +460,11 @@ static int __ext4_ext_check(const char *function, unsigned int line,
> >   		error_msg = "invalid eh_entries";
> >   		goto corrupted;
> >   	}
> > +	if (unlikely((le16_to_cpu(eh->eh_entries) == 0) &&
> > +		     (le16_to_cpu(eh->eh_depth > 0)))) {
> 
> The parentheses are misplaced,

I'm not sure I understand what you mean.  I want to have

	if (unlikely((CONDITION A) && (CONDITION B))) {
		/* ... */
	}

so they look correct.  Or is that a matter of style/alignment?  (Which
checkpatch.pl doesn't complains about, by the way.)

>and le16_to_cpu is not needed here.

OK, I guess that, since both conditions do a comparison against '0', the
le16_to_cpu() can be dropped.  And, if the parentheses problem you
mentioned above is a style problem, dropping it will also solve it because
that statement will become

	if (unlikely((eh->eh_entries == 0) && (eh->eh_depth > 0))) {
		/* ... */
	}

And once again, thanks for your review!

Cheers,
-- 
Lu?s

> 
> > +		error_msg = "eh_entries is 0 but eh_depth is > 0";
> > +		goto corrupted;
> > +	}
> >   	if (!ext4_valid_extent_entries(inode, eh, lblk, &pblk, depth)) {
> >   		error_msg = "invalid extent entries";
> >   		goto corrupted;
> > .
> 
> -- 
> With Best Regards,
> Baokun Li
>