Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 12 Aug 2022 21:11:47 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Andreas Dilger <adilger@dilger.ca>
Cc:     linux-ext4@vger.kernel.org, Dongyang Li <dongyang@ddn.com>
Subject: Re: [PATCH] debugfs: quiet debugfs 'catastrophic' message
Message-ID: <Yvb6UzeX2Umg1ts+@mit.edu>
References: <20220805220606.11994-1-adilger@dilger.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220805220606.11994-1-adilger@dilger.ca>
Precedence: bulk

On Fri, Aug 05, 2022 at 04:06:07PM -0600, Andreas Dilger wrote:
> When debugfs runs with "-c", it prints a scary-looking message:
> 
>     catastrophic mode - not reading inode or group bitmaps
> 
> that is often misunderstood by users to mean that there is something
> wrong with the filesystem, when there is no problem at all.
> 
> Not reading the bitmaps is totally normal and expected behavior for
> the "-c" option, which is used to significantly shorten the debugfs
> command execution time by not reading metadata that isn't needed for
> commands run against very large filesystems.
> 
> Since there is often confusion about what this message means, it
> would be better to just avoid printing anything at all, since the
> use of "-c" is expressly requesting this behavior, and there are
> no messages printed out for other options.
> 
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
> Reviewed-by: Dongyang Li <dongyang@ddn.com>
> Change-Id: I59b26a601780544ab995aa4ca7ab0c2123c70118

Applied, thanks!

					- Ted