Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp219710rwb; Fri, 12 Aug 2022 18:16:18 -0700 (PDT) X-Google-Smtp-Source: AA6agR5F3Ae+dOu3lnkxOBxkuHnDPbU35kFSc8cluOw4qMq32USKm/DvYjhqxogQjci9xCUiXhWi X-Received: by 2002:a17:907:75f1:b0:72b:9e40:c1a9 with SMTP id jz17-20020a17090775f100b0072b9e40c1a9mr4118489ejc.523.1660353377921; Fri, 12 Aug 2022 18:16:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660353377; cv=none; d=google.com; s=arc-20160816; b=KyGj7UaimWmRsjMQYs+8wLooMlgDWCSTyXvod5Zm4AOcs6NE4immH4BVzAybcileaX SFzeRD2B7wWr/kgeeWtqV7XYuE/1xw9eWM7bSYjxxwctxoogMfAc2XIEw21FBGtM5/lh xPRHuKopb4c0BGsknIQLwQ8Pfrb+FTJQthZCJwsT/uSdSqK4GK68VMBj/tR+As+MYXiJ 3eO7zXXuBFL+M1FNLxLIp2j7zCwKKLuXeVdqT9361EUblR8+U2UtzyJL5kvsbUsRv0N4 JcQvNp7NxuXoNTs3tFJEykD277wAmEkSbfcAOmy5llFk7J25CChsUlIKxq3I2OyT8TG2 aDlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ku9v+EorGVFZA4ClIh/AoHXx5XUYT3Fj6A9bEo2Sp+k=; b=L1+0wJvF+c1XuzQTJwIN/3jjlDAMzeP1y66OPiME4PMvJzm1w7gR3zb2tSflSWcFMH W7JtUsItbCQQU4d83fK5I/LIw/KCefOZVICew95+lY2POd/IcIU2FchrOu3VSI5+0tJi nzI/Rx+TlXUyBqacFGMStMgtkCaLzHykDpnRM0ROVmhGlyu5w6YEsD3MYw9M6P1ZRU3M A6AJYWePPv6zb1IdeZ/MQdAvD6CAG5FOZ/1xHvUjgFQqTvaaQe2v2mOP+imaSQDKQEjL jThWgB/ZRdAE/XLHpwFMyr6hUFIlQGoOIq3g2ach10UKWfV1wFhXIaHaHnw2M/xDmEQ5 HbXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=OSDFjfK+; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o11-20020a170906974b00b00730a1f55ac8si3033731ejy.821.2022.08.12.18.15.53; Fri, 12 Aug 2022 18:16:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=OSDFjfK+; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237727AbiHMBMR (ORCPT + 99 others); Fri, 12 Aug 2022 21:12:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238008AbiHMBMQ (ORCPT ); Fri, 12 Aug 2022 21:12:16 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35BDAAA3E2 for ; Fri, 12 Aug 2022 18:12:16 -0700 (PDT) Received: from letrec.thunk.org (c-24-1-67-28.hsd1.il.comcast.net [24.1.67.28]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 27D1CAoH017229 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 12 Aug 2022 21:12:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1660353132; bh=ku9v+EorGVFZA4ClIh/AoHXx5XUYT3Fj6A9bEo2Sp+k=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=OSDFjfK+yd8KNvs+PBoUI4G5+GKiZ2dgyXgXcj5unWt5kGZZygwrukqkB+HPWuQ+q rapRKLjnxp6QLJ5IKqItHGx/GXVssp+xaPJMWiDQTudq1jFxlBh2QWOV6EPwZX55X3 RAQG/5cmJRv4GFfhrIcOoq6/+ckrqKVI8ZS9Dmq5E766W6BpUfYBSiXWNThtlU6QVN KKuxZhEOLraaqw7mPYl2EU+mseQUITx1dQCaq14YQhkN8/EgTa8ccYObjQjcZ3K6iO l/4JVUJGg2vkLGi9KKlmXyqFqhWk6FxHARfIRXHOgYFcOQZSm1gIkw+yqFNqT5m680 yRhECZJ9d14QA== Received: by letrec.thunk.org (Postfix, from userid 15806) id 0C2CA8C2DE9; Fri, 12 Aug 2022 21:12:10 -0400 (EDT) Date: Fri, 12 Aug 2022 21:12:10 -0400 From: "Theodore Ts'o" To: Andreas Dilger Cc: linux-ext4@vger.kernel.org, Li Dongyang Subject: Re: [PATCH] debugfs: allow for ncheck Message-ID: References: <20220301041031.74615-1-adilger@whamcloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220301041031.74615-1-adilger@whamcloud.com> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Feb 28, 2022 at 09:10:31PM -0700, Andreas Dilger wrote: > If the arg string is of the form , allow it for ncheck. > Improve the error message, use "Invalid inode number" instead > of "Bad inode", which implies the inode content being bad. > > Signed-off-by: Li Dongyang > Reviewed-by: Andreas Dilger Applied, thanks! - Ted