Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 Aug 2022 16:21:38 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     JunChao Sun <sunjunchao2870@gmail.com>
Cc:     linux-ext4@vger.kernel.org, linux-doc@vger.kernel.org,
        tytso@mit.edu, corbet@lwn.net
Subject: Re: [PATCH] Documentation: ext4: correct the document about
 superblock
Message-ID: <YvoQIvIlMsADeG2H@debian.me>
References: <20220814090016.3160-1-sunjunchao2870@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="C0wGcx6yGLwGR1Gt"
Content-Disposition: inline
In-Reply-To: <20220814090016.3160-1-sunjunchao2870@gmail.com>
Precedence: bulk


--C0wGcx6yGLwGR1Gt
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Aug 14, 2022 at 02:00:16AM -0700, JunChao Sun wrote:
> Correct some questions like this:
> s_lastcheck_hi field should be upper 8 bits of the
> s_lastcheck field, rather than itself.
>=20
> diff --git a/Documentation/filesystems/ext4/super.rst b/Documentation/fil=
esystems/ext4/super.rst
> index 268888522e35..0152888cac29 100644
> --- a/Documentation/filesystems/ext4/super.rst
> +++ b/Documentation/filesystems/ext4/super.rst
> @@ -456,15 +456,15 @@ The ext4 superblock is laid out as follows in
>     * - 0x277
>       - __u8
>       - s_lastcheck_hi
> -     - Upper 8 bits of the s_lastcheck_hi field.
> +     - Upper 8 bits of the s_lastcheck field.
>     * - 0x278
>       - __u8
>       - s_first_error_time_hi
> -     - Upper 8 bits of the s_first_error_time_hi field.
> +     - Upper 8 bits of the s_first_error_time field.
>     * - 0x279
>       - __u8
>       - s_last_error_time_hi
> -     - Upper 8 bits of the s_last_error_time_hi field.
> +     - Upper 8 bits of the s_last_error_time field.
>     * - 0x27A
>       - __u8
>       - s_pad[2]

The diff looks OK, but the description should be:
"The description of s_lastcheck_hi, s_first_error_time_hi, and
s_last_error_time_hi fields refer to themselves, while these means
referring to upper 8 bits (byte) of corresponding fields (s_lastcheck,
s_first_error_time, and s_last_error_time). Correct the mistake."

Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--C0wGcx6yGLwGR1Gt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCYvoQGgAKCRD2uYlJVVFO
o8oJAP97K4ZlgfWXsNm5/qWKaC8pdT9u15ITW3FP3IOOfqdZ1QD/ReUqmfzowVR1
j997tJPJsMkXr5EFR7kDt+LXBKUv6wA=
=aUqt
-----END PGP SIGNATURE-----

--C0wGcx6yGLwGR1Gt--