Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 15 Aug 2022 17:18:14 +0800
From:   Zorro Lang <zlang@redhat.com>
To:     "Darrick J. Wong" <djwong@kernel.org>
Cc:     linux-xfs@vger.kernel.org, fstests@vger.kernel.org,
        linux-ext4@vger.kernel.org
Subject: Re: [PATCHSET v2 0/3] fstests: refactor ext4-specific code
Message-ID: <20220815091814.eybgwyf4bjg6m4dx@zlang-mailbox>
References: <166007884125.3276300.15348421560641051945.stgit@magnolia>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <166007884125.3276300.15348421560641051945.stgit@magnolia>
Precedence: bulk

On Tue, Aug 09, 2022 at 02:00:41PM -0700, Darrick J. Wong wrote:
> Hi all,
> 
> This series aims to make it so that fstests can install device mapper
> filters for external log devices.  Before we can do that, however, we
> need to change fstests to pass the device path of the jbd2 device to
> mount and mkfs.  Before we can do /that/, refactor all the ext4-specific
> code out of common/rc into a separate common/ext4 file.
> 
> v2: fix _scratch_mkfs_sized for ext4, don't clutter up the outputs
> 
> If you're going to start using this mess, you probably ought to just
> pull from my git trees, which are linked below.
> 
> This is an extraordinary way to destroy everything.  Enjoy!
> Comments and questions are, as always, welcome.

Two weeks passed, this patchset is good to me, I'd like to merge this patchset
with "[PATCH 1/1] dmerror: support external log and realtime devices" together
this week.

Reviewed-by: Zorro Lang <zlang@redhat.com>

> 
> --D
> 
> fstests git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=refactor-ext4-helpers
> ---
>  common/config |    4 +
>  common/ext4   |  193 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  common/rc     |  186 ++++---------------------------------------------------
>  common/xfs    |   23 +++++++
>  4 files changed, 233 insertions(+), 173 deletions(-)
>  create mode 100644 common/ext4
>