Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Siddh Raman Pant <code@siddh.me>
To:     code@siddh.me
Cc:     david@fromorbit.com, djwong@kernel.org, fgheet255t@gmail.com,
        hch@infradead.org, linux-ext4@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-xfs@vger.kernel.org, riteshh@linux.ibm.com,
        syzbot+a8e049cd3abd342936b6@syzkaller.appspotmail.com,
        syzkaller-bugs@googlegroups.com
Message-ID: <20220818111117.102681-1-code@siddh.me>
Subject: Re: [syzbot] WARNING in iomap_iter
Date:   Thu, 18 Aug 2022 16:41:17 +0530
In-Reply-To: <20220818110031.89467-1-code@siddh.me>
References: <20220818110031.89467-1-code@siddh.me>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf8
Precedence: bulk

The last test patch accidentally left out less-than-zero checks...

Is there a way to cancel previously requested tests?

#syz test https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi=
t master

---
 drivers/block/loop.c      |  3 +++
 include/uapi/linux/loop.h | 12 ++++++------
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index e3c0ba93c1a3..4ca20ce3158d 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -977,6 +977,9 @@ loop_set_status_from_info(struct loop_device *lo,
 =09=09return -EINVAL;
 =09}
=20
+=09if (info->lo_offset < 0 || info->lo_sizelimit < 0)
+=09=09return -EINVAL;
+
 =09lo->lo_offset =3D info->lo_offset;
 =09lo->lo_sizelimit =3D info->lo_sizelimit;
 =09memcpy(lo->lo_file_name, info->lo_file_name, LO_NAME_SIZE);
diff --git a/include/uapi/linux/loop.h b/include/uapi/linux/loop.h
index 6f63527dd2ed..973565f38f9d 100644
--- a/include/uapi/linux/loop.h
+++ b/include/uapi/linux/loop.h
@@ -53,12 +53,12 @@ struct loop_info64 {
 =09__u64=09=09   lo_device;=09=09=09/* ioctl r/o */
 =09__u64=09=09   lo_inode;=09=09=09/* ioctl r/o */
 =09__u64=09=09   lo_rdevice;=09=09=09/* ioctl r/o */
-=09__u64=09=09   lo_offset;
-=09__u64=09=09   lo_sizelimit;/* bytes, 0 =3D=3D max available */
-=09__u32=09=09   lo_number;=09=09=09/* ioctl r/o */
-=09__u32=09=09   lo_encrypt_type;=09=09/* obsolete, ignored */
-=09__u32=09=09   lo_encrypt_key_size;=09=09/* ioctl w/o */
-=09__u32=09=09   lo_flags;
+=09__s64=09=09   lo_offset;
+=09__s64=09=09   lo_sizelimit;/* bytes, 0 =3D=3D max available */
+=09__s32=09=09   lo_number;=09=09=09/* ioctl r/o */
+=09__s32=09=09   lo_encrypt_type;=09=09/* obsolete, ignored */
+=09__s32=09=09   lo_encrypt_key_size;=09=09/* ioctl w/o */
+=09__s32=09=09   lo_flags;
 =09__u8=09=09   lo_file_name[LO_NAME_SIZE];
 =09__u8=09=09   lo_crypt_name[LO_NAME_SIZE];
 =09__u8=09=09   lo_encrypt_key[LO_KEY_SIZE]; /* ioctl w/o */
--=20
2.35.1