Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 Aug 2022 20:51:16 +0530
From:   Siddh Raman Pant <code@siddh.me>
To:     "Matthew Wilcox" <willy@infradead.org>
Cc:     "david" <david@fromorbit.com>, "djwong" <djwong@kernel.org>,
        "fgheet255t" <fgheet255t@gmail.com>, "hch" <hch@infradead.org>,
        "linux-ext4" <linux-ext4@vger.kernel.org>,
        "linux-fsdevel" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel" <linux-kernel@vger.kernel.org>,
        "linux-xfs" <linux-xfs@vger.kernel.org>,
        "riteshh" <riteshh@linux.ibm.com>,
        "syzbot+a8e049cd3abd342936b6" 
        <syzbot+a8e049cd3abd342936b6@syzkaller.appspotmail.com>,
        "syzkaller-bugs" <syzkaller-bugs@googlegroups.com>
Message-ID: <182b18b5d92.7a2e2b1623166.1514589417142553905@siddh.me>
In-Reply-To: <Yv5RmsUvRh+RKpXH@casper.infradead.org>
References: <20220818110031.89467-1-code@siddh.me>
 <20220818111117.102681-1-code@siddh.me> <Yv5RmsUvRh+RKpXH@casper.infradead.org>
Subject: Re: [syzbot] WARNING in iomap_iter
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Importance: Medium
User-Agent: Zoho Mail
Precedence: bulk

On Thu, 18 Aug 2022 20:20:02 +0530  Matthew Wilcox  wrote:
> I don't think changing these from u64 to s64 is the right way to go.

Why do you think so? Is there somnething I overlooked?

I think it won't intorduce regression, since if something is working,
it will continue to work. If something does break, then they were
relying on overflows, which is anyways an incorrect way to go about.

Also, it seems even the 32-bit compatibility structure uses signed
types.

Thanks,
Siddh