Received: by 2002:a05:6358:4e97:b0:b3:742d:4702 with SMTP id ce23csp917875rwb; Thu, 18 Aug 2022 14:54:38 -0700 (PDT) X-Google-Smtp-Source: AA6agR56DYpPGgCx9J0Axp48QybNbDEPV/WtIn5DtOHa7hIr0Qoso7oAv6KsvtPGQ9phylgkXWM+ X-Received: by 2002:a05:6402:26c2:b0:43d:d885:451a with SMTP id x2-20020a05640226c200b0043dd885451amr3666561edd.287.1660859678634; Thu, 18 Aug 2022 14:54:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660859678; cv=none; d=google.com; s=arc-20160816; b=M78Dt3QGLV0+/zaTZbXdnvNhI0BEYQnylxb44Nl9TGvssRUkpkmI+eXO60e1Pmzu9a ynei6yb+no4C/R2fXFeSkRGHZbRVK6lO/sS0jtFsHz6MrpulVXzNxkB/dbaRbK5L3+ig WbnYLDzFQEwJZuoUfF8Ad7R7cZebZKPRr8/vrdoCfAWfX7H3fplDMg5mMjJo557FYMnK /XYjswl+xup1P9VnEm7oZYhpe6LfMe9JE9rgbw0KI7esJy3AWWdRy9PBLQmLsSQSKJYf BG/G8Ci0+OzJMMqCfv+HpLcKMdmMuhHgDvROwPQVjdAXP9qU+W7om7NNGwfgScWnxUoA bXPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:mime-version:message-id:date :dkim-signature; bh=ggYZcW/jiHht2+YSvHf2xzH9Vi0hSCfs2RkxdmXJjMU=; b=eN9ngXcsCstJzRpGZGFOXa4jJ4VPhrUqLEMlli/YrsyPTR+7QqXczMCXe7qTB2SLZg 7XoQP5GDdauw7pK6uSfz9WJ4iAgXAxzB62H5+6POXORQfSM6JUPANEM+zCA796V5AsMa OPuxXDh9jnFWT4Uno6EVJdXLfwd/qTaSfRyspF4CibZ6GXZFw9k0/HhaUCa/2A4bw+2j 3R9Brzpec+pTph1DAze1ijv7vfwqxidnzVd5LXbwX8KCQwMNSFExB4jRAZLn/P/OnegQ oxkPTHv3LXM/xgiN9fIzbukIr+AND3QaHvXBd6xcJCsXL4spsoo7fDATldebIglGu6zf pYuw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=nejJkqLn; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e3-20020a17090658c300b007311b7ccd6esi1945591ejs.871.2022.08.18.14.54.10; Thu, 18 Aug 2022 14:54:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=nejJkqLn; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346993AbiHRVkz (ORCPT + 99 others); Thu, 18 Aug 2022 17:40:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346078AbiHRVkx (ORCPT ); Thu, 18 Aug 2022 17:40:53 -0400 Received: from mail-io1-xd49.google.com (mail-io1-xd49.google.com [IPv6:2607:f8b0:4864:20::d49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42682BD28E for ; Thu, 18 Aug 2022 14:40:53 -0700 (PDT) Received: by mail-io1-xd49.google.com with SMTP id w7-20020a5d9607000000b0067c6030dfb8so1595208iol.10 for ; Thu, 18 Aug 2022 14:40:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:from:to:cc; bh=ggYZcW/jiHht2+YSvHf2xzH9Vi0hSCfs2RkxdmXJjMU=; b=nejJkqLn39bRDQq7wbN19Ph5a2ZdHTa4Sd2es/UeWHwznTnN+IgKm9+hJKcYJK/zsi axeEP4d4aVZMHLgZ4TFSrj7qsbSrsiflvI3BmQW1l4+zR08ZElug1lMTRzZoukpt+aZv i8NvIdeiRCGOKsEMqlknSUrlH0z+hNn/FfK8WxNE6PKCKd/63862nyp7MlZHD88Bpqqh Sw4YQ1L1kfJBczrSy60QlE6wfbHa08MTkkQCQJXbHsogjeBoBf72TGi4aG8BfRzWNrdi FPRJrpfuJSLjkxldNomRCjr2nudoKJLyjQFU9/7/PXoI4xqdpvNQtJXhOHuFXu25H/Kr peBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc; bh=ggYZcW/jiHht2+YSvHf2xzH9Vi0hSCfs2RkxdmXJjMU=; b=XDc9qUV3uQ7/vVOoYgMYBIJ5eJA1fcFxKHEyaRaWa6gMsC3zQs3v6T70CnHSGLjuBI 4ivn1cLPikPUm4iN1HP12qZB7Q50W/4o8ag/SnfOrw7h7w8PpS9qvFyfJ3d9OeISlvlK nyAtIJ8FkRi1T1/sLRMd7kYWPW9fNYWh7nAvvTWC3JSwEzmOYuNOsjNEwRIVZsxrVRTR d4glBIWehVfy83jz1+zpEIYELHBj/0GWwph0bf64fEMf6ohdwGoWkzA0FEOfBJZvyNiB lPscrFI2Thy6wEaySMgsqw8xXe1CS1q5H0vAdw0Uhf+mlRAoE1U+w2Sdhq26r8SJlCoc 3Iuw== X-Gm-Message-State: ACgBeo3MOLSTWtrnDn68Y3hron+8EZF1Upv92NIGYM3hXg3Gk4IEdk4x fVUPX+TRwE48eB9S9DUZ6RVf4ujtbNO+7RM/ X-Received: from lalithkraj-spec-glinux.c.googlers.com ([fda3:e722:ac3:cc00:2b:ff92:c0a8:b94]) (user=lalithkraj job=sendgmr) by 2002:a05:6e02:661:b0:2e2:be22:67f0 with SMTP id l1-20020a056e02066100b002e2be2267f0mr2327973ilt.91.1660858852679; Thu, 18 Aug 2022 14:40:52 -0700 (PDT) Date: Thu, 18 Aug 2022 21:40:49 +0000 Message-Id: <20220818214049.1519544-1-lalithkraj@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.37.1.595.g718a3a8f04-goog Subject: [PATCH] ext4: Make ext4_lazyinit_thread freezable. From: Lalith Rajendran To: tytso@mit.edu, dilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Lalith Rajendran Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org ext4_lazyinit_thread is not set freezable. Hence when the thread calls try_to_freeze it doesn't freeze during suspend and continues to send requests to the storage during suspend, resulting in suspend failures. Signed-off-by: Lalith Rajendran --- fs/ext4/super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 9a66abcca1a85..d77e0904a1327 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3767,6 +3767,7 @@ static int ext4_lazyinit_thread(void *arg) unsigned long next_wakeup, cur; BUG_ON(NULL == eli); + set_freezable(); cont_thread: while (true) { -- 2.31.0