Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 18 Aug 2022 17:08:01 -0700
From:   "Darrick J. Wong" <djwong@kernel.org>
To:     Lalith Rajendran <lalithkraj@google.com>
Cc:     tytso@mit.edu, dilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: Make ext4_lazyinit_thread freezable.
Message-ID: <Yv7UYfFBmRTKXNc7@magnolia>
References: <20220818214049.1519544-1-lalithkraj@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220818214049.1519544-1-lalithkraj@google.com>
Precedence: bulk

On Thu, Aug 18, 2022 at 09:40:49PM +0000, Lalith Rajendran wrote:
> ext4_lazyinit_thread is not set freezable. Hence when the thread calls
> try_to_freeze it doesn't freeze during suspend and continues to send
> requests to the storage during suspend, resulting in suspend failures.

Maybe we should just make suspend freeze all the filesystems in order?

https://lore.kernel.org/linux-fsdevel/20210417001026.23858-1-mcgrof@kernel.org/ 

--D

> Signed-off-by: Lalith Rajendran <lalithkraj@google.com>
> ---
>  fs/ext4/super.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 9a66abcca1a85..d77e0904a1327 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3767,6 +3767,7 @@ static int ext4_lazyinit_thread(void *arg)
>  	unsigned long next_wakeup, cur;
>  
>  	BUG_ON(NULL == eli);
> +	set_freezable();
>  
>  cont_thread:
>  	while (true) {
> -- 
> 2.31.0
>