Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp2462511rwa; Mon, 22 Aug 2022 08:07:01 -0700 (PDT) X-Google-Smtp-Source: AA6agR5JLWzvS6f8vFm+ALDZQ8N2hPXOPyc33UESN4LiswSrkVPGPMx0uPSnuSpDmKjc8HJ82vxi X-Received: by 2002:a05:6402:354e:b0:440:5398:cd65 with SMTP id f14-20020a056402354e00b004405398cd65mr16394024edd.43.1661180821030; Mon, 22 Aug 2022 08:07:01 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1661180821; cv=pass; d=google.com; s=arc-20160816; b=bjD8I9m2QjGMAfHYdwxUpBR3UvI7VTPi/3DUbLOCR4KNqwfhiu9gHshJbU9cqc46g7 pzrNEdNmipgg6q8YcDntpRuILMx1//KvJL2ISLgDvdO97TsNBTlK0UjEl8BQMnBJYROQ JbFr7lMHXkx83QzcfPOUBBhuFh+OmVrmDMzpWzxhDDJAGq0H+4Ooq6Ef+0qcf0EORKGO aP+sAc8Y3M/TcJ6T7jfY6+2FJAavnfDpbWTaEqN9E1P/ghHCKVqKwvwYpU0jx2YAEXua BZ1smP3xymLLWRUjgV4sFAl4tTzHMqW/YbYwcKDJEhk6SC7iHSznz6tydbqFClJ6yFAX QbjQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:importance:content-transfer-encoding :mime-version:subject:references:in-reply-to:message-id:cc:to:from :date:dkim-signature; bh=/u/Wny60TF8LyG87rvYOmsY9vkwmsddSZaOyk12HpDI=; b=JF78lHbWOkSM4z18JYYRD3Jlyz5JBTtdtgc7nFK4YlH3B9zIq14Qb0jxVf6b+CkrWn ZmMReSjgDzIDoMpEwMmPaIRruzS67MFev60c8j7s8oRJpUgOIY6iIbGFggFhZDVK1/Wp xnTA9U5K7tUIU9RN8PfxRGtUxki7XZz0/q2Ly1xCytDuxbJFjjwefgW73EXVzSzh4hXJ gt5A0+lwPcv1+G2pgnKp1RJ0lbhZuX+meggOvJFY/VC4XtaP9IA3M3hxeUgiiv3lDNqj miJCzYx/j5SB/kS8BJt6xDPuL/4cCxK/l9LyAqxUwKiyjFJm5uEs87xAHKUsyoNnMcGa JP+Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@siddh.me header.s=zmail header.b="nKRg/6yn"; arc=pass (i=1 spf=pass spfdomain=siddh.me dkim=pass dkdomain=siddh.me dmarc=pass fromdomain=siddh.me>); spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siddh.me Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y71-20020a50bb4d000000b0043d14d03dd9si9821514ede.496.2022.08.22.08.06.33; Mon, 22 Aug 2022 08:07:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@siddh.me header.s=zmail header.b="nKRg/6yn"; arc=pass (i=1 spf=pass spfdomain=siddh.me dkim=pass dkdomain=siddh.me dmarc=pass fromdomain=siddh.me>); spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siddh.me Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235803AbiHVPDF (ORCPT + 99 others); Mon, 22 Aug 2022 11:03:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235828AbiHVPC6 (ORCPT ); Mon, 22 Aug 2022 11:02:58 -0400 Received: from sender-of-o50.zoho.in (sender-of-o50.zoho.in [103.117.158.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9754939B8D; Mon, 22 Aug 2022 08:02:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661180551; cv=none; d=zohomail.in; s=zohoarc; b=QSf4nmiLJx5ozxBoq+i1Fb0X2Eb0ZWVcugm0/fOUu4TUeNhfuzECMygE58LgJprE6gcIFmIjBQktQia5WMx6gFf1qp9kKmxVIzfFcgyFp7/j6fxyF7Mo71nRtqi0Y1Q0MvlDWBV4LZwHw6GSDE1PhH/s4zvrgyPTSY/hShN219I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.in; s=zohoarc; t=1661180551; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=/u/Wny60TF8LyG87rvYOmsY9vkwmsddSZaOyk12HpDI=; b=edKXGteBo64NDoFyisLen9BIUUSJVL/v7jUdSeoOaTOTLToKILM9BYvmckQyrgjNEI3FgSspAMu2ENXXxg7T639DaakkIxkQDk1tBHori7md3DYeiBKocRlvI+0XHQD+ixFAJuG/W1YhVwdlStQzWtvQw8dZgcI3/uKdrIRvM1Y= ARC-Authentication-Results: i=1; mx.zohomail.in; dkim=pass header.i=siddh.me; spf=pass smtp.mailfrom=code@siddh.me; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1661180551; s=zmail; d=siddh.me; i=code@siddh.me; h=Date:Date:From:From:To:To:Cc:Cc:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=/u/Wny60TF8LyG87rvYOmsY9vkwmsddSZaOyk12HpDI=; b=nKRg/6yn1laoseGxgZ4Byzzs6tgeatmM6XgjGzyaXNxBUtxEl0mnXZnXcpgWEHv/ fa2KAB+aUJ+YQGYq6AU9Zohca7NUdTW7Hnva6CUOKqxAwXCUvEP3azqlw7CpCs/1asn 6UwPJeYuVJZAq4fXslD+gxv4HLzuSNfJjpINvrSQ= Received: from mail.zoho.in by mx.zoho.in with SMTP id 1661180540583918.6664486750254; Mon, 22 Aug 2022 20:32:20 +0530 (IST) Date: Mon, 22 Aug 2022 20:32:20 +0530 From: Siddh Raman Pant To: "Matthew Wilcox" Cc: "david" , "djwong" , "fgheet255t" , "hch" , "linux-ext4" , "linux-fsdevel" , "linux-kernel" , "linux-xfs" , "riteshh" , "syzbot+a8e049cd3abd342936b6" , "syzkaller-bugs" Message-ID: <182c6137693.20a934d213186.5712495322312393662@siddh.me> In-Reply-To: References: <182c028abf0.2dc6f7c973088.2963173753499991828@siddh.me> <20220821114816.24193-1-code@siddh.me> <182c607e79a.820e4a7012709.6365464609772129416@siddh.me> Subject: Re: [syzbot] WARNING in iomap_iter MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_RED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, 22 Aug 2022 20:22:32 +0530 Matthew Wilcox wrote: > But it's not an integer. It's a bitfield. Nobody checks lo_flags for > "is it less than zero". That makes it very different from lo_offset. Thanks for clarifying, I see where I was wrong. I overlooked its use as a bitfield. Thanks, Siddh