Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
From:   Boyang Xue <bxue@redhat.com>
Date:   Tue, 23 Aug 2022 12:16:46 +0800
Message-ID: <CAHLe9YZvOcbimNsaYa=jk27uUR1jgVDtXXztLEa0AVnqveOoyQ@mail.gmail.com>
Subject: [bug report] disk quota exceed after multiple write/delete loops
To:     linux-ext4@vger.kernel.org
Cc:     linux-fsdevel@vger.kernel.org, Lukas Czerner <lczerner@redhat.com>
Content-Type: multipart/mixed; boundary="000000000000ce7bc605e6e0d5f3"
Precedence: bulk

--000000000000ce7bc605e6e0d5f3
Content-Type: text/plain; charset="UTF-8"

On the latest kernel 6.0.0-0.rc2, I find the user quota limit in an
ext4 mount is unstable, that after several successful "write file then
delete" loops, it will finally fail with "Disk quota exceeded". This
bug can be reproduced on at least kernel-6.0.0-0.rc2 and
kernel-5.14.0-*, but can't be reproduced on kernel-4.18.0 based RHEL8
kernel.

Reproducer (can also be found as the attachment):
```
#!/bin/bash

# setup
groupadd -f quota_test
useradd -g quota_test quota_test_user1
dd if=/dev/null of=ext4_5G.img bs=1G seek=5
lo_dev=$(losetup -f --show ext4_5G.img)
mkdir /mntpt
mkfs.ext4 -F ext4_5G.img
mount -o usrquota ext4_5G.img /mntpt
chmod 777 /mntpt
quotacheck -u /mntpt
setquota -u quota_test_user1 200000 300000 2000 3000 /mntpt
quotaon -u /mntpt

# test
for i in $(seq 1 100); do
    echo "*** Run#$((i++)) ***"
    echo "--- Quota before writing file ---"; quota -uv
quota_test_user1; echo "--- ---"
    su - quota_test_user1 -c "dd if=/dev/zero of=/mntpt/test_300m
bs=1024 count=300000" || break_flag=1
    echo "--- Quota after writing file ---"; quota -uv
quota_test_user1; echo "--- ---"
    rm -f /mntpt/test_300m
    sleep 10s # in case slow deletion
    echo "--- Quota after deleting file ---"; quota -uv
quota_test_user1; echo "--- ---"
    [[ $break_flag -eq 1 ]] && break
done

# cleanup
umount /mntpt
losetup -D
rm -rf ext4_5G.img /mntpt
userdel -r quota_test_user1
groupdel quota_test
```

Run log on kernel-6.0.0-0.rc2
```
(...skip successful Run#[1-2]...)
*** Run#3 ***
--- Quota before writing file ---
Disk quotas for user quota_test_user1 (uid 1003):
     Filesystem  blocks   quota   limit   grace   files   quota   limit   grace
     /dev/loop0       0  200000  300000               0    2000    3000
--- ---
dd: error writing '/mntpt/test_300m': Disk quota exceeded
299997+0 records in
299996+0 records out
307195904 bytes (307 MB, 293 MiB) copied, 1.44836 s, 212 MB/s
--- Quota after writing file ---
Disk quotas for user quota_test_user1 (uid 1003):
     Filesystem  blocks   quota   limit   grace   files   quota   limit   grace
     /dev/loop0  300000* 200000  300000   7days       1    2000    3000
--- ---
--- Quota after deleting file ---
Disk quotas for user quota_test_user1 (uid 1003):
     Filesystem  blocks   quota   limit   grace   files   quota   limit   grace
     /dev/loop0       0  200000  300000               0    2000    3000
--- ---
```

The kernel in test can be found at
https://koji.fedoraproject.org/koji/buildinfo?buildID=2050107

--000000000000ce7bc605e6e0d5f3
Content-Type: application/x-sh; name="test_quota_v01.sh"
Content-Disposition: attachment; filename="test_quota_v01.sh"
Content-Transfer-Encoding: base64
Content-ID: <f_l75o5cw00>
X-Attachment-Id: f_l75o5cw00

IyEvYmluL2Jhc2gKCiMgc2V0dXAKZ3JvdXBhZGQgLWYgcXVvdGFfdGVzdAp1c2VyYWRkIC1nIHF1
b3RhX3Rlc3QgcXVvdGFfdGVzdF91c2VyMQpkZCBpZj0vZGV2L251bGwgb2Y9ZXh0NF81Ry5pbWcg
YnM9MUcgc2Vlaz01CmxvX2Rldj0kKGxvc2V0dXAgLWYgLS1zaG93IGV4dDRfNUcuaW1nKQpta2Rp
ciAvbW50cHQKbWtmcy5leHQ0IC1GIGV4dDRfNUcuaW1nCm1vdW50IC1vIHVzcnF1b3RhIGV4dDRf
NUcuaW1nIC9tbnRwdApjaG1vZCA3NzcgL21udHB0CnF1b3RhY2hlY2sgLXUgL21udHB0CnNldHF1
b3RhIC11IHF1b3RhX3Rlc3RfdXNlcjEgMjAwMDAwIDMwMDAwMCAyMDAwIDMwMDAgL21udHB0CnF1
b3Rhb24gLXUgL21udHB0CgojIHRlc3QKZm9yIGkgaW4gJChzZXEgMSAxMDApOyBkbwogICAgICAg
IGVjaG8gIioqKiBSdW4jJCgoaSsrKSkgKioqIgoJZWNobyAiLS0tIFF1b3RhIGJlZm9yZSB3cml0
aW5nIGZpbGUgLS0tIjsgcXVvdGEgLXV2IHF1b3RhX3Rlc3RfdXNlcjE7IGVjaG8gIi0tLSAtLS0i
CglzdSAtIHF1b3RhX3Rlc3RfdXNlcjEgLWMgImRkIGlmPS9kZXYvemVybyBvZj0vbW50cHQvdGVz
dF8zMDBtIGJzPTEwMjQgY291bnQ9MzAwMDAwIiB8fCBicmVha19mbGFnPTEKCWVjaG8gIi0tLSBR
dW90YSBhZnRlciB3cml0aW5nIGZpbGUgLS0tIjsgcXVvdGEgLXV2IHF1b3RhX3Rlc3RfdXNlcjE7
IGVjaG8gIi0tLSAtLS0iCglybSAtZiAvbW50cHQvdGVzdF8zMDBtCglzbGVlcCAxMHMgIyBpbiBj
YXNlIHNsb3cgZGVsZXRpb24KCWVjaG8gIi0tLSBRdW90YSBhZnRlciBkZWxldGluZyBmaWxlIC0t
LSI7IHF1b3RhIC11diBxdW90YV90ZXN0X3VzZXIxOyBlY2hvICItLS0gLS0tIgoJW1sgJGJyZWFr
X2ZsYWcgLWVxIDEgXV0gJiYgYnJlYWsKZG9uZQoKIyBjbGVhbnVwCnVtb3VudCAvbW50cHQKbG9z
ZXR1cCAtRApybSAtcmYgZXh0NF81Ry5pbWcgL21udHB0CnVzZXJkZWwgLXIgcXVvdGFfdGVzdF91
c2VyMQpncm91cGRlbCBxdW90YV90ZXN0Cg==
--000000000000ce7bc605e6e0d5f3--