Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <df469d936b2e1c1a8c9c947896fa8a160f33b0e8.camel@kernel.org>
Subject: Re: [PATCH] iversion: update comments with info about atime updates
From:   Jeff Layton <jlayton@kernel.org>
To:     NeilBrown <neilb@suse.de>
Cc:     Dave Chinner <david@fromorbit.com>,
        Mimi Zohar <zohar@linux.ibm.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-integrity@vger.kernel.org, linux-nfs@vger.kernel.org,
        linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
        Trond Myklebust <trondmy@hammerspace.com>
Date:   Tue, 23 Aug 2022 07:51:16 -0400
In-Reply-To: <166125468756.23264.2859374883806269821@noble.neil.brown.name>
References: <20220822133309.86005-1-jlayton@kernel.org>
        , <ceb8f09a4cb2de67f40604d03ee0c475feb3130a.camel@linux.ibm.com>
        , <f17b9d627703bee2a7b531a051461671648a9dbd.camel@kernel.org>
        , <18827b350fbf6719733fda814255ec20d6dcf00f.camel@linux.ibm.com>
        , <4cc84440d954c022d0235bf407a60da66a6ccc39.camel@kernel.org>
        , <20220822233231.GJ3600936@dread.disaster.area>
        , <6cbcb33d33613f50dd5e485ecbf6ce7e305f3d6f.camel@kernel.org>
         <166125468756.23264.2859374883806269821@noble.neil.brown.name>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-08-23 at 21:38 +1000, NeilBrown wrote:
> On Tue, 23 Aug 2022, Jeff Layton wrote:
> > So, we can refer to that and simply say:
> >=20
> > "If the function updates the mtime or ctime on the inode, then the
> > i_version should be incremented. If only the atime is being updated,
> > then the i_version should not be incremented. The exception to this rul=
e
> > is explicit atime updates via utimes() or similar mechanism, which
> > should result in the i_version being incremented."
>=20
> Is that exception needed?  utimes() updates ctime.
>=20
> https://man7.org/linux/man-pages/man2/utimes.2.html
>=20
> doesn't say that, but
>=20
> https://pubs.opengroup.org/onlinepubs/007904875/functions/utimes.html
>=20
> does, as does the code.
>=20

Oh, good point! I think we can leave that out. Even better!
--=20
Jeff Layton <jlayton@kernel.org>