Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3822642rwa; Tue, 23 Aug 2022 10:41:44 -0700 (PDT) X-Google-Smtp-Source: AA6agR7fw6u7s1rB4ysYQnzL9B3wsc3mQx86RzsbsGGJE8dm8+YV6tvn/AFfGoRKO2kjrv+uthig X-Received: by 2002:a05:6402:4311:b0:447:9fb:b710 with SMTP id m17-20020a056402431100b0044709fbb710mr4423425edc.272.1661276504132; Tue, 23 Aug 2022 10:41:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661276504; cv=none; d=google.com; s=arc-20160816; b=jBFJ6rTnuY0FS+3SDonk2JGtANCnK/3HRxWqTxJzm8pShNKKjhwkib4PMSj+ilMayY ucIBnlfyXmKrJQfkfKOhh6yk/D/w8YiKXqGfO1kjpAzqBJBPhw8NKUPu+2b4mu4KRxEq XSbu6Wd3sUEOex7LupT725LocxaTHrX3kBEfMW2Mvr07Gza/0FndF1YZaxlnmRCqmSvd 66LWEFGGSU5RvBXMjHOD7ZbtofBLqOZtN8Hg8/jQebdjTX4GEE5FLNJ0kBJEOCu2o7zF PZEIPfWHQRf/ZojNbRw9uR+RdFWW0v8bQx+ZPQuyScRvetEYNYjCmG5Du3I8Kg5zoZJP uhBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LVn3okWCPixSaF/sLJscnWdb4hR5AjxVtymdhuNXQZE=; b=OQYg6qV8OCzy5i59JVrRr3xFOFoDEY02lVy6kCbjNdD8C0w6T5UemWPuHOsYSZK5zK ygCSLrDzfCCWAyuoxadXhIpFYrSPOTwdSvRxkw97AkXca07JpOXGEpJ24WThlBzgqPWa DQfUABFdl7dvUfHIB0ZRigpNgWZ6raKPg4Aynm46pBvjGd39sXFS7pb4DoB5YxbUHDeM B9tjvpS0KyMJ4SI70rhjJsTh+tMIxoSbFJU68zbP4nvnfaVnZMvl+xFr/KcbRHjRM0v9 eh5FsYQW/A2nxK4gUNsigytSmLLZI74v2GjMP8faTcMTCgbAaUKsTn8MxYxNms8oSgZQ 6DXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MAuankf2; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp24-20020a1709073e1800b007316ac034c1si196944ejc.496.2022.08.23.10.41.19; Tue, 23 Aug 2022 10:41:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=MAuankf2; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229548AbiHWRlD (ORCPT + 99 others); Tue, 23 Aug 2022 13:41:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229960AbiHWRkS (ORCPT ); Tue, 23 Aug 2022 13:40:18 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDB3E96774; Tue, 23 Aug 2022 08:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LVn3okWCPixSaF/sLJscnWdb4hR5AjxVtymdhuNXQZE=; b=MAuankf2Ata/zK+W3LJw0BlGjh tk3HkSzIzMe7tBq1t11agUkUEIfUKI5PPCbJvsu34JWWksYpdhvN9IAeayAu1yQr6/oCh+ZeOh1xM uA8t3EBy3gFw2R4kITE9yn2bYl5bnG2d8MartTEVeRwgiTHw7aiiN/1iBgLHRlkJ+lmHOIz9C9H2y CToXqHV5UadCOkF3Kt5CqOZfAGGtj8GluEifrvUs8S4phZEZkabRInosWxJPUeAtdoKaGlwrFp+pf smBsBoRsTA50e515p74CqZBexyNHrJVSioflqm5g2eh9EVmaHOdnSJXrlFvgcDBcnmEvuwCs2BBeD 4shBS68Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQVpr-00FOSe-Km; Tue, 23 Aug 2022 15:28:59 +0000 Date: Tue, 23 Aug 2022 16:28:59 +0100 From: Matthew Wilcox To: Siddh Raman Pant Cc: david@fromorbit.com, djwong@kernel.org, fgheet255t@gmail.com, hch@infradead.org, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, riteshh@linux.ibm.com, syzbot+a8e049cd3abd342936b6@syzkaller.appspotmail.com, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] WARNING in iomap_iter Message-ID: References: <182c6137693.20a934d213186.5712495322312393662@siddh.me> <20220823152101.165538-1-code@siddh.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220823152101.165538-1-code@siddh.me> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Aug 23, 2022 at 08:51:01PM +0530, Siddh Raman Pant wrote: > + if (lo->lo_offset < 0 || lo->lo_sizelimit < 0 || lo->lo_flags < 0) The lo_flags check is still there? > + return -EOVERFLOW; > + > memcpy(lo->lo_file_name, info->lo_file_name, LO_NAME_SIZE); > lo->lo_file_name[LO_NAME_SIZE-1] = 0; > lo->lo_flags = info->lo_flags; > -- > 2.35.1 > >