Received: by 2002:a05:6358:5282:b0:b5:90e7:25cb with SMTP id g2csp3989117rwa; Tue, 23 Aug 2022 14:02:32 -0700 (PDT) X-Google-Smtp-Source: AA6agR5zbERUAlRowHpGwVfwoO7L23nkfMaE68VIg8zdKwLNX2T4EPTsGVMlPSTC2BZm08tAB6bg X-Received: by 2002:a17:907:d0b:b0:73d:6bee:1456 with SMTP id gn11-20020a1709070d0b00b0073d6bee1456mr890105ejc.89.1661288552483; Tue, 23 Aug 2022 14:02:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661288552; cv=none; d=google.com; s=arc-20160816; b=HFfeBNKGXl4LFvd4Bv/WfnZjkVvWqiYkGO6P+5EaVjg303Ma0+1gCtP3e3aS4teFbm T+X+KtTky04CFdQAoxnm11Y6stKfYkmmyfbSKLw2oV32YGBf2wEAnc8ZVGeRdQAqdINS UaTCIsmtH9j+/aj+rXQG7zGTyRPw74J/MzvrEx0w0EmO1EjmYJoKDUU+B2jmcgNXyMZ8 Q1S1wvSuGbl4/fBcEXnO7oScRq/beig9mSOWb+xvy45t3wbkFZX5oyH0vz+IsE6M53V8 CBQFmSnUNwlh7QVfzWb1veiPf/RLXBTbAtXQyLTi6gSGDvqP/AHoFCRtELk0+QHXmWIS cuzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=PTTm42py41yQoEsLkKxWO4eb77BAB9nCF5K8wc3FaQ0=; b=NMXa9rWWi9kG+g4cVj2BkiHVy/Go4f4EWl5yeJYr7mVwU6yd2NtAIsyUTp74TNCz4v JAPIEvi8OxLmbMlIkDppUU8BxPvUEEF3QiiPHceTv9lYyUfgcisAL2/4EPtjKXLBSP3r q2GJHQjPJ6JOy+kADfRdXfv0uugTZI4W5eNuf+HGmv+otFSgVRkgXFXjS0V6oqMc2UMU Vrtk78h9lY3++STYFK1kS9WAAEPDth8WjtDozHhKiuPn+PubUl+QeNunNJsHCxmDFIHD Y1iHN0fbqhqCdTeAF02WUDJipXl9DrodLzjMiFfh/jot+wyvcut8LBaEdx40J9v1G0AX wlWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=iZ6TFj2g; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x2-20020a1709064bc200b0073d5436f711si521633ejv.174.2022.08.23.14.02.02; Tue, 23 Aug 2022 14:02:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=iZ6TFj2g; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbiHWU6b (ORCPT + 99 others); Tue, 23 Aug 2022 16:58:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbiHWU6a (ORCPT ); Tue, 23 Aug 2022 16:58:30 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC802D59 for ; Tue, 23 Aug 2022 13:58:27 -0700 (PDT) Received: from cwcc.thunk.org (pool-108-49-209-117.bstnma.fios.verizon.net [108.49.209.117]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 27NKwNsU013428 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Aug 2022 16:58:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1661288304; bh=PTTm42py41yQoEsLkKxWO4eb77BAB9nCF5K8wc3FaQ0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=iZ6TFj2gJCQ/9OTzghc+ir5VBXHHNNfmG0h9xAR0KPuayfVvHB7kZxzKpDs4k/RPb OCksfSi+NmAXb8tqEJOwpIAXLVLA0EiXlm6TEy9QhFcgqJGqB7cJbiG+qR88XdlFnL GA2kPcf7DiUJPahGTOhKgq3vkzSsbcs0sqAcQhRcmjuIwH+tSGfgyU5lO+PX0Cr0oO /FCSp6dCp33M0+/gQPQynSetVa1cDy4YnTTKz4yGJPIOGOkR0fjVx96zWcDTui3IPy omEheGFxrkUUxQPF8ktqIafzY3nZ8MismYJoLItBIC29tc/ryD/r8M7lPyrLT46oF9 7fRjMd563b6tw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 4F10815C3EC2; Tue, 23 Aug 2022 16:58:23 -0400 (EDT) From: "Theodore Ts'o" To: bongiojp@gmail.com Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org Subject: Re: [PATCH v4] tune2fs: Add support for get/set UUID ioctls. Date: Tue, 23 Aug 2022 16:58:21 -0400 Message-Id: <166128823287.2407454.16231141308595218283.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20220816205214.145632-1-bongiojp@gmail.com> References: <20220816205214.145632-1-bongiojp@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, 16 Aug 2022 13:52:14 -0700, Jeremy Bongio wrote: > When mounted, there is a race condition between changing the filesystem > UUID and changing other aspects of the filesystem, like mounting, resizing, > changing features, etc. Using these ioctls to get/set the UUID ensures the > filesystem is not being resized. > > Applied, thanks! I made a few changes for non-Linux portability, and to handle some error cases correctly. Also your patch wasn't setting old_uuid from the value returned from the ioctl, which I fixed up. - Ted [1/1] tune2fs: Add support for get/set UUID ioctls. commit: a83e199da0ca954f7f0d63756d6eea108caf107f Best regards, -- Theodore Ts'o