Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1354810rwe; Thu, 1 Sep 2022 17:33:25 -0700 (PDT) X-Google-Smtp-Source: AA6agR64PV1s6+I7mtPIWNHW5OwKl/r3N7lRLF03BbXvAXCw656NqGamqwVtFrgP0+LTzpqG9tmP X-Received: by 2002:a17:906:847c:b0:73f:d7cf:bf2d with SMTP id hx28-20020a170906847c00b0073fd7cfbf2dmr21731069ejc.327.1662078804847; Thu, 01 Sep 2022 17:33:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662078804; cv=none; d=google.com; s=arc-20160816; b=BUnWKfj4ALKnhHJF0fozDjlh0rnjbWRNe9imWol24F56vX8KT0c8kPawfP8Wtxd8X3 z9VKJjcWjiyNQlAO0DTEvh4iVIGSUUXA8i53x7aFCATlerthD8ipVGaIoEVNxepKqbqy BRRJVSg/jEhUV8zolERJl7eG8eoqq1zrkUjOhNQXBkjJ+P0XpsVNWoPKAUGzpt/uycED uG/G6oR+2yx3/8RigD//4C44/lRFQL66Jl3Uk/Uoe9rI/yHdR+Do4suYGeQ8Ul4uBUtM EBNPby5m9cF6lgcuJ7D/9eEbxB0Qob4ZCR6YYl4hCuy+ZSt7IT7V/babbz7m7PziNFxt lh4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=GX5ACSnHUYsKqlVKsOWkZfXxafThifKnGC34uwcAjqA=; b=ATWXSrB20sdkhxCoVl/VM3zNClsDFDc4yHS3n7EtGS2FqV4mdLiHYL47v/Obk8lbRF 3SlkKJGCbDA4u5pxH3Ls20bL6IVQfhWUkHat2GFotv9tgExJc0Oc7XZZvheFAcaaGlHr c98iPclYHqgCuiYGSxg4N0Qhw5UMURV9YvnGR6PfVLuJQ4WdLr6a5a6MRQmJHt/0A/DA 2IBU6avh+uyIKD4G1BGAOppczJAbVW2faokDM/OpQl3i1WAruTrLjrgU0jy58PU/6sms LpqaiZ1fVuyp3dOVHjCgV3P5JGVPVvHsfeEvDwn9RGPZezi3tGHX2CI8RG8sKhlvSEk0 673g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=DbYmmMXX; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l17-20020a1709067d5100b00732fd99cdb5si515372ejp.854.2022.09.01.17.32.53; Thu, 01 Sep 2022 17:33:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=DbYmmMXX; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234159AbiIBAar (ORCPT + 99 others); Thu, 1 Sep 2022 20:30:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232420AbiIBAaq (ORCPT ); Thu, 1 Sep 2022 20:30:46 -0400 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBC4B95AD4; Thu, 1 Sep 2022 17:30:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=GX5ACSnHUYsKqlVKsOWkZfXxafThifKnGC34uwcAjqA=; b=DbYmmMXXFvXNfgDpO9j4482+k4 Nz/X9ykWbPXR+tXPE74oUAJ0OHbE9QtvPBH0RB+KhOhadNfv/9vrgLGMZ9+wcWqW7VAXVhOOV75o3 Lyp0DTiKeqdG5X5L/wcgq6AV2KQXb4YXndw/JP/Aa8QfHL/MY5TYTY5oBTXvdipUZI4bUozQSc62V G79pth6KqCUyuRd1yAmlYDzOefDPBD5+eWrkNtYFbHAmu/C5JyvgY4VkVrl2IKWqdL9t6r60x7975 QXEarjETVKU4mXg3H7dYxd785+hlc7hbFdkioaIy61Ow0kOmryox7Ch1xu45qKOEIBiD7GapJh6M8 S1/0C80A==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.95 #2 (Red Hat Linux)) id 1oTuZu-00BA5L-Bu; Fri, 02 Sep 2022 00:30:34 +0000 Date: Fri, 2 Sep 2022 01:30:34 +0100 From: Al Viro To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cluster-devel@redhat.com, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, jack@suse.cz, tytso@mit.edu, akpm@linux-foundation.org, axboe@kernel.dk, rpeterso@redhat.com, agruenba@redhat.com, almaz.alexandrovich@paragon-software.com, mark@fasheh.com, dushistov@mail.ru, hch@infradead.org, chengzhihao1@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH v2 13/14] ext2: replace bh_submit_read() helper with bh_read_locked() Message-ID: References: <20220901133505.2510834-1-yi.zhang@huawei.com> <20220901133505.2510834-14-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901133505.2510834-14-yi.zhang@huawei.com> Sender: Al Viro X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Sep 01, 2022 at 09:35:04PM +0800, Zhang Yi wrote: > bh_submit_read() and the uptodate check logic in bh_uptodate_or_lock() > has been integrated in bh_read() helper, so switch to use it directly. s/bh_read_locked/bh_read/ in the summary?