Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1397912rwe; Thu, 1 Sep 2022 18:35:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR4YnaehzZTalCik0L/92snpc24X8LYEaLYPsmnMChANOZZvXQYSZxaWArUMVrhy7joVAB5d X-Received: by 2002:a17:90b:2712:b0:1fa:fe17:16db with SMTP id px18-20020a17090b271200b001fafe1716dbmr2140658pjb.165.1662082544873; Thu, 01 Sep 2022 18:35:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662082544; cv=none; d=google.com; s=arc-20160816; b=0JV5ojq+PHydgGXY3RowhrBpw/FkDtQtuWw4AJtAebGU913P7AGAsX0/gS/EZz4YcU 32CshN2sI/7JPjrYFYFhoBiEWCU6N+fCN3CjO/uRvYZwAzCLAGnQS8SxDMBCJJ9Q0MtO lhb7pQAq3ZDfciTX4FwD/hyftcHNoX4tcAsob2z3txbRlkc+veHsePHvyWNnNfyqZgdc obYA6VzwgFjIWejKY7r9oVFbkConYEKPp2TA3675vu+N3PPh8AQF6/KvluNiLzP/LZ2T 5Vq1mJlwEw1NRxl1srUM6Rm6fZj+KY0mM2ZBJTKoyk2ATcpC9vFZCARbTTCGTPZxNrDJ bFpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=Ui+mFtu0/MNBwbB3mygrnhnwrkzNChbsXzxe8PMPA4M=; b=h5HX/jGExgU+W3Vx2kgTlYJ24PhkQx0G01JJpt/BrIj0Y9ymbb4ty3dTict3yl6kob JNo7HCKvKAY+PcoTJCkAu6uxX4DqZgUBSUxLTknqerKIAIXf/AG/QTqtGjubaA8wcwse lpBhT5GiByTTQQNiCngEoYaUk7KA9IaFbFzQmQTfryDn7ZxYhIWVUSOSwqBYIBrjizVy ChSXx7XaY9jDBcOrk29qq+Q5AOflJOkeW+S6q7f2v2/VlLpZsquWrVcwiVf2EdHLywVJ VjlLyNKgvjyS1LCqegG0hxh43PtIYdQHz+rFAx4SknRnxBfByOXe2IQIxew8c5LaOykV EQ7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d1-20020a655ac1000000b0042a330a7ca7si496864pgt.659.2022.09.01.18.35.25; Thu, 01 Sep 2022 18:35:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229804AbiIBBc6 (ORCPT + 99 others); Thu, 1 Sep 2022 21:32:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbiIBBc5 (ORCPT ); Thu, 1 Sep 2022 21:32:57 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7A816CF71; Thu, 1 Sep 2022 18:32:56 -0700 (PDT) Received: from canpemm500005.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4MJgNT71ClzHncr; Fri, 2 Sep 2022 09:31:05 +0800 (CST) Received: from [10.174.178.134] (10.174.178.134) by canpemm500005.china.huawei.com (7.192.104.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 2 Sep 2022 09:32:54 +0800 Subject: Re: [PATCH v2 13/14] ext2: replace bh_submit_read() helper with bh_read_locked() To: Al Viro CC: , , , , , , , , , , , , , , , , , , References: <20220901133505.2510834-1-yi.zhang@huawei.com> <20220901133505.2510834-14-yi.zhang@huawei.com> From: Zhang Yi Message-ID: <3fdab5fd-1efa-9668-da5c-889e9bfa1524@huawei.com> Date: Fri, 2 Sep 2022 09:32:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.134] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500005.china.huawei.com (7.192.104.229) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 2022/9/2 8:30, Al Viro wrote: > On Thu, Sep 01, 2022 at 09:35:04PM +0800, Zhang Yi wrote: >> bh_submit_read() and the uptodate check logic in bh_uptodate_or_lock() >> has been integrated in bh_read() helper, so switch to use it directly. > > s/bh_read_locked/bh_read/ in the summary? > Sorry, I don't get your question, I have already replace bh_read_locked() with bh_read() in the commit message, there is no bh_read_locked in the whole patch. Am I missing something? Thanks, Yi.