Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1412178rwe; Thu, 1 Sep 2022 18:59:27 -0700 (PDT) X-Google-Smtp-Source: AA6agR4ted+t7QZL4VNmVdpu2QYPy2u0IHwK6y6C7tRFpi/3opKQsF2uLRcB3Xq+VaB/H9pjOp6h X-Received: by 2002:a17:90a:e383:b0:1fd:bc7d:bf60 with SMTP id b3-20020a17090ae38300b001fdbc7dbf60mr2195318pjz.237.1662083967608; Thu, 01 Sep 2022 18:59:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662083967; cv=none; d=google.com; s=arc-20160816; b=Oi5rDiDXq6ax+S4rLosGcZEc9FEUjH0E7OY3kv/jxcu/49F8CH0fcRDMP2VDLnGCNh N2RiXKEenYuvVwKI3bYTHDdP2qEeBOTaskjm70aA1PK/T8Q9wD+vIfmP5bnG1czzFWI/ VaI+UJF/kRDi/kGDmHP2X3qbNmgK8DDuakoiYWDfebwCMkgMqtR5+NJRdSsgHjmxDlwJ 5I6hyuWVP60/dyC5AKNhjL5byTOwMH+FfC3IqxguVv7DHc/029LWif5KUIbhbHmRmCJy mEl0DZfjQaKIlvEXjNTHlSynrZvEukXkQbCP+l5qDmussWs8NpUqWm4ZxaiCufCnmt21 Xy9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=AHoA94Hk0V1+0HXqlkIbJPhRwQPwm6frNDZtWCI6wa4=; b=R5UqeE9yFxVNTOfJm+u1ia/uDkmJZfgDMmNjbL8fzvLSWY8fIyWdmQ9j3hyRzJ6Y75 5cI/X+p6+f0tvs7o6Ox/GkarqUE7Jvtpf0J4F+M2FCldp8zQtTn6gBv1IvkZCwHFL5Cp X04DvWTZxrzOzkoit1AlrdLSNXDtquXo5rAEbKrJ1abA/okKsFmMGj408KDvQSFbOWZO paZa3e3byEmqH+ps74H/6YqfvqtctQjtJgWIMLpdAIggLKBKWsL8IGghLDTI5TbShwfg id7wraef7YzfKe/HVOxvILnlUpOSfgR3QlISJMMSHMnNtBS5WtC5V9cuwyZZYoW9WFEg 6fPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=dmkbGZng; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x48-20020a056a000bf000b00538186c29ccsi667633pfu.100.2022.09.01.18.59.08; Thu, 01 Sep 2022 18:59:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.org.uk header.s=zeniv-20220401 header.b=dmkbGZng; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=zeniv.linux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231577AbiIBBvQ (ORCPT + 99 others); Thu, 1 Sep 2022 21:51:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230091AbiIBBvO (ORCPT ); Thu, 1 Sep 2022 21:51:14 -0400 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C4F5A0257; Thu, 1 Sep 2022 18:51:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=AHoA94Hk0V1+0HXqlkIbJPhRwQPwm6frNDZtWCI6wa4=; b=dmkbGZng4M+5yesbaSJIyzSR+G SgZbfUxTIzQOoqEgJOgYQyTbTpEmNrepfK0p5bbL7T3+4dyC50bL7mdWHuenxQfkVNiuGPWVVgzD2 XiZGRxWe+23+Lxq5+KmtXd4dgeBuM1yxgWyq6E9DpGv9YZUQ/MHtTjgPPa3VGECxozbv0Yh9vGvdi nFlmbUF1s73SuRIdGPhXlm208Z9Cj5Dyr72/rJaSqPIpigLDmmLr4BLYqMUs9z0zuEkaMgGDWdpCU SSgWvJy5sf2CjXO7IboSmtjpMkxEVrW04qP5174UeR94zvkXLDnpEdQRk/8wjIVAcrnQFbHS2l8/B Y3uRWgqg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.95 #2 (Red Hat Linux)) id 1oTvpr-00BBC1-SY; Fri, 02 Sep 2022 01:51:07 +0000 Date: Fri, 2 Sep 2022 02:51:07 +0100 From: Al Viro To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cluster-devel@redhat.com, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, jack@suse.cz, tytso@mit.edu, akpm@linux-foundation.org, axboe@kernel.dk, rpeterso@redhat.com, agruenba@redhat.com, almaz.alexandrovich@paragon-software.com, mark@fasheh.com, dushistov@mail.ru, hch@infradead.org, chengzhihao1@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH v2 13/14] ext2: replace bh_submit_read() helper with bh_read_locked() Message-ID: References: <20220901133505.2510834-1-yi.zhang@huawei.com> <20220901133505.2510834-14-yi.zhang@huawei.com> <3fdab5fd-1efa-9668-da5c-889e9bfa1524@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3fdab5fd-1efa-9668-da5c-889e9bfa1524@huawei.com> Sender: Al Viro X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Sep 02, 2022 at 09:32:53AM +0800, Zhang Yi wrote: > On 2022/9/2 8:30, Al Viro wrote: > > On Thu, Sep 01, 2022 at 09:35:04PM +0800, Zhang Yi wrote: > >> bh_submit_read() and the uptodate check logic in bh_uptodate_or_lock() > >> has been integrated in bh_read() helper, so switch to use it directly. > > > > s/bh_read_locked/bh_read/ in the summary? > > > > Sorry, I don't get your question, I have already replace bh_read_locked() > with bh_read() in the commit message, there is no bh_read_locked in the whole > patch. Am I missing something? Take a look at the subject ;-)