Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp1412405rwe; Thu, 1 Sep 2022 18:59:51 -0700 (PDT) X-Google-Smtp-Source: AA6agR7nriNJEE/H+SmFJZzTLl+ec6gDwIygtEL+YY/KPOEbNumiBiDFc9qWA/wqnMXkBUGNmaNz X-Received: by 2002:a63:698a:0:b0:41c:8dfb:29cb with SMTP id e132-20020a63698a000000b0041c8dfb29cbmr28656962pgc.170.1662083990797; Thu, 01 Sep 2022 18:59:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662083990; cv=none; d=google.com; s=arc-20160816; b=0cv2m7ZUgspotrw1irOa7qVhbyTOxxYBYieSgkMc9S7kuuTRiTmT7mBr+M1LonqIol BZFpK0aweH4hKQnuWUovqetHdwnmmh1yq78jUFJMwsRXijopc4vfnR6G7lNERAN4QmUR yUcsWkFYxHXcPmUpHbqlI6bQMED5OEczrIols7SbnAi6VrRfTpA/dtNgeVJdxlfDEvR2 /yJHoftRc0NLAKorMWNDPP76XLaxQLyFnl8ZY83lfPN7pR/GGCPPgtixdBfjXVFAnmBm rl1OlZo92+YLUJY50bP3qxJ6FOxAqgJFyldnjQBn1/afsX3dwMKizP38kQzXfOXdqJ2j GKhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=37b0keShD3KmwOFuotmC78IQ38FfZoKZS2F4v85LOXk=; b=gO94o3/ptJ+sDTzstPprKW0EksupO0GtO4OLtAO0M1KRA4zBcpcCwP+FlvDQmbXAbM CTHUV4I6YqbCOABqVrtUURai2JZO7m36e3jjc4B/IyGXmiGejdPTOxA+t7K6xWR3V3Y4 ZBThMzRj1KPAoPFvtCnWSCUGc/OhIc12SqjD06M08oNbLBl7YmhK0qBVY+Je9n5RNOgL 4ql3V/C2LQqCeYZYPsDWxPuzB3/5Adks3CYppFIL1XS/ATCdo+fMrgUWDD4jZXl+2DOr eIqK4HIx0+3Kgl5LjAIlstZesQckLHCSNmBuJhL0x5ChZ9DdSV8NuI+9EgVZpAl38UEv Sg3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s22-20020a056a0008d600b0053a9a08b0c8si781048pfu.251.2022.09.01.18.59.37; Thu, 01 Sep 2022 18:59:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232199AbiIBB6l (ORCPT + 99 others); Thu, 1 Sep 2022 21:58:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232014AbiIBB6l (ORCPT ); Thu, 1 Sep 2022 21:58:41 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C354A98F0; Thu, 1 Sep 2022 18:58:40 -0700 (PDT) Received: from canpemm500005.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MJgw03pldzkX1X; Fri, 2 Sep 2022 09:54:56 +0800 (CST) Received: from [10.174.178.134] (10.174.178.134) by canpemm500005.china.huawei.com (7.192.104.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Fri, 2 Sep 2022 09:58:37 +0800 Subject: Re: [PATCH v2 13/14] ext2: replace bh_submit_read() helper with bh_read_locked() To: Al Viro CC: , , , , , , , , , , , , , , , , , , References: <20220901133505.2510834-1-yi.zhang@huawei.com> <20220901133505.2510834-14-yi.zhang@huawei.com> <3fdab5fd-1efa-9668-da5c-889e9bfa1524@huawei.com> From: Zhang Yi Message-ID: Date: Fri, 2 Sep 2022 09:58:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.134] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500005.china.huawei.com (7.192.104.229) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 2022/9/2 9:51, Al Viro wrote: > On Fri, Sep 02, 2022 at 09:32:53AM +0800, Zhang Yi wrote: >> On 2022/9/2 8:30, Al Viro wrote: >>> On Thu, Sep 01, 2022 at 09:35:04PM +0800, Zhang Yi wrote: >>>> bh_submit_read() and the uptodate check logic in bh_uptodate_or_lock() >>>> has been integrated in bh_read() helper, so switch to use it directly. >>> >>> s/bh_read_locked/bh_read/ in the summary? >>> >> >> Sorry, I don't get your question, I have already replace bh_read_locked() >> with bh_read() in the commit message, there is no bh_read_locked in the whole >> patch. Am I missing something? > > Take a look at the subject ;-) Oh, yes, I forgot to update the subject, will do. Thanks, Yi.