Received: by 2002:a05:6358:bb9e:b0:b9:5105:a5b4 with SMTP id df30csp2800380rwb; Mon, 5 Sep 2022 01:28:04 -0700 (PDT) X-Google-Smtp-Source: AA6agR6OmdAJvkZE395lCvRbMODbLfYP+r59bUGR4wIZgBx3/mN0GPlH5fF/WbdFN+2qvBgWJEvK X-Received: by 2002:a17:903:22c3:b0:176:b658:4eb6 with SMTP id y3-20020a17090322c300b00176b6584eb6mr2181341plg.56.1662366483892; Mon, 05 Sep 2022 01:28:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662366483; cv=none; d=google.com; s=arc-20160816; b=Ynec48TPA5hCwhrEIQ5O7Wb07o0UDWUOr4MjEwFCXzGuca56r8M/dxg+wJ3ITfrFau u04XSMQ/GZhC8R2b4chV8RBJApUyhIbpoOjP+ztV7EacitchvSVedN7ORsFMHeRstfAb Lqpv59HWv85TinaS/3cT3f9hySKF1dFraXauIxFXcAx6EaSp+F4Zyc3N/NzyPEhbuFFc pri9EoxaGc3tLFY43TG1Zqp3pM48jQH94epewh4B4d0iu+foYULZcWHH/DW2Cv87N7fe gwTgw6J3Lsdnb5afxjKCYH6AegiQaNB7pUMuYUXgw3j/jnXDb+MTc8k+AS6JVIyz1tYP 8GAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Opykd4NroLOvUVAS6DC0mH5AVipCgMT0W9fOrq2cA5g=; b=rZHkKayB3zze2CT2B+nFkoZ45lK2VjbpjII5ubtRUkZeVUS82leZO+nBIvI+ua1+fh 8j0+fnqrdnrQcxzE0L4dy9Ow2dXZGTnEAg31NJdCf7gp33iVd/P5f/3obAo8A4xkaxzn 5x9w6W5oVI8AKL4IP2FaPOTA7JHEYpGzynOX92KHp1Ft/yz91iCDAoun47xgpDnJZbvg AV/Y9eI8JdS//E5RSsypVW1Gy2gg+M8aLsFtx9e58O96UnwTnujqmUrNqvH/LvE5MSZp xytbXel+8HJRaXtvjd4faEmkNEpERi4TbX94pj6b7daHb57sS/1OmqmYvUZFn2U1/98T iqPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=kQY2cNMK; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q82-20020a632a55000000b004303da67c67si155412pgq.370.2022.09.05.01.27.44; Mon, 05 Sep 2022 01:28:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=kQY2cNMK; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237547AbiIEIYv (ORCPT + 99 others); Mon, 5 Sep 2022 04:24:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237550AbiIEIYp (ORCPT ); Mon, 5 Sep 2022 04:24:45 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67A8CD7; Mon, 5 Sep 2022 01:24:20 -0700 (PDT) Received: from letrec.thunk.org (guestnat-104-133-160-99.corp.google.com [104.133.160.99] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 2858NOnQ025716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 5 Sep 2022 04:23:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1662366211; bh=Opykd4NroLOvUVAS6DC0mH5AVipCgMT0W9fOrq2cA5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=kQY2cNMKCxqeSaFySEG9If6ZtQ8BhheeiKQJIw2xRYU0mwh5KEc4n5fb1xfvPk4CZ mBNdt31pMRPo3WHANZ5/Ldd6KIRnX21xck+7Bwn1Fcrsc5FcAOy78knWuHYTLXAl4g DxocwCUAw/g0qM3+vyInmt7rzH9XEt3Rw96cWfFdL1E5K22280Elx75++itsnVc6Gr BQtWa317FaLTf8L+CdQ4p6Ae6qIlTOrneZoG/Z4wofU62NxWKd3WMtYF7anpMD6LxL vXTuclZkTdheNbZQoIMugvCv3ZQ/q2LRDpdTb2u/xsaul3tZnLnf3enunBF8CgAtMV Liep1iIsFATVw== Received: by letrec.thunk.org (Postfix, from userid 15806) id 344298C2B5D; Mon, 5 Sep 2022 04:23:24 -0400 (EDT) Date: Mon, 5 Sep 2022 04:23:24 -0400 From: "Theodore Ts'o" To: Zhang Yi Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, cluster-devel@redhat.com, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, jack@suse.cz, akpm@linux-foundation.org, axboe@kernel.dk, viro@zeniv.linux.org.uk, rpeterso@redhat.com, agruenba@redhat.com, almaz.alexandrovich@paragon-software.com, mark@fasheh.com, dushistov@mail.ru, hch@infradead.org, chengzhihao1@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH v2 06/14] jbd2: replace ll_rw_block() Message-ID: References: <20220901133505.2510834-1-yi.zhang@huawei.com> <20220901133505.2510834-7-yi.zhang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220901133505.2510834-7-yi.zhang@huawei.com> X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Sep 01, 2022 at 09:34:57PM +0800, Zhang Yi wrote: > ll_rw_block() is not safe for the sync read path because it cannot > guarantee that submitting read IO if the buffer has been locked. We > could get false positive EIO after wait_on_buffer() if the buffer has > been locked by others. So stop using ll_rw_block() in > journal_get_superblock(). We also switch to new bh_readahead_batch() > for the buffer array readahead path. > > Signed-off-by: Zhang Yi Thanks, looks good. Reviewed-by: Theodore Ts'o - Ted