Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
Subject: Re: [PATCH] tune2fs: tune2fs_main() should return rc when some error,
 occurs
From:   Artem Blagodarenko <artem.blagodarenko@gmail.com>
In-Reply-To: <7a6e1a43-d041-c3cf-a3dd-a9761d8dd4d6@huawei.com>
Date:   Tue, 6 Sep 2022 12:41:26 +0300
Cc:     "Theodore Y. Ts'o" <tytso@mit.edu>,
        Ext4 Developers List <linux-ext4@vger.kernel.org>,
        linfeilong <linfeilong@huawei.com>,
        wuguanghao <wuguanghao3@huawei.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C9EBB17B-7EA2-44A3-9361-FDD09EE69FB5@gmail.com>
References: <7a6e1a43-d041-c3cf-a3dd-a9761d8dd4d6@huawei.com>
To:     Zhiqiang Liu <liuzhiqiang26@huawei.com>
Precedence: bulk

Reviewed-by: Artem Blagodarenko <artem.blagodarenko@gmail.com>

> On 5 Sep 2022, at 18:40, Zhiqiang Liu <liuzhiqiang26@huawei.com> =
wrote:
>=20
>=20
> If some error occurs, tune2fs_main() will go to closefs tag for
> releasing resource, and it should return correct value (rc) instead
> of 0 when ext2fs_close_free(&fs) successes.
>=20
> Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> ---
> misc/tune2fs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/misc/tune2fs.c b/misc/tune2fs.c
> index 25ade2fa..088f87e5 100644
> --- a/misc/tune2fs.c
> +++ b/misc/tune2fs.c
> @@ -3481,6 +3481,7 @@ _("Warning: The journal is dirty. You may wish =
to replay the journal like:\n\n"
> 			fputs(_("Error in using clear_mmp. "
> 				"It must be used with -f\n"),
> 			      stderr);
> +			rc =3D 1;
> 			goto closefs;
> 		}
> 	}
> @@ -3744,5 +3745,5 @@ closefs:
>=20
> 	if (feature_64bit)
> 		convert_64bit(fs, feature_64bit);
> -	return (ext2fs_close_free(&fs) ? 1 : 0);
> +	return (ext2fs_close_free(&fs) ? 1 : rc);
> }
> --=20
> 2.33.0
>=20
>=20