Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp307109rwn; Thu, 8 Sep 2022 01:46:45 -0700 (PDT) X-Google-Smtp-Source: AA6agR5AhNUP6Y1dgjiIm4xKVw5sm5tTlvRPNpqRJx6WX6BWB7yKC+IB5KKQxjHPqR+Czq1CoEag X-Received: by 2002:a17:902:9308:b0:174:9dff:716b with SMTP id bc8-20020a170902930800b001749dff716bmr8120323plb.75.1662626805056; Thu, 08 Sep 2022 01:46:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662626805; cv=none; d=google.com; s=arc-20160816; b=ZIZlw9srTO015m0scWCJBJTOShy1LpVn6wpy+KrmbfuI3/bTDMkubaPCIyiecZA7Bw VoWxZr/ksPAN4DeQfmrC2q54SF+GcQinU6NHgfIEIT6wpJMgMpSRFu+Wsbu/xQknA/lL n77muid6+3wtYN+iSaGlKUZQmrC8LY49oI8yy2CCZc5g37HV8dYUAeYv4VSkC0vFhLqh PHfvL9WQt6UB0QHI22GCigwrJCvD9Wgr30jGLypOkU6F0vWDGI7FyFaBL7VSPvFT4tev 3qSUEdQ6b7wz1xJRsLGwW6xDVfN/eAFCXgRWoPVH7qGZsH88Yn3VGnbT6hsYWoveJ4Ch cfIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=NYu0YovWqWzWdfYZiJVYYZmwb8uVVf1jRoDTIyfDYvM=; b=UTbJxxxiYjUblkWBfkjwiWqAYxW4mXM6/QGf4avFgzk4L/KBRR4PsxOoGn4kPs516M I0RspjbWvClbovTNlCrApju/OVsmh5OQQL7ylSeMqi0f0IzX87dQUSfJlptOM433rndQ 7hadxZt3OeGchIZe6OXqQDX0KtGcWHZM8LiSJL28FzNsCZRMj7lAkjsDRqVDrSYzOX9T 6zMPylukdDrih1Vwuafy2eGh3xuH33cEo/mlS2gc4xLiF7rLi9lLHmMWot1sEDoWopG3 XVsQjZ/kuszhJsEcvQNpSIasOdUAu00DEd6X3X96eojbxKM0W+V0imcjRu+Xm6xZ+qfD yS3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=h8FBDpFF; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g14-20020a056a000b8e00b0053b89017c91si16859405pfj.253.2022.09.08.01.46.32; Thu, 08 Sep 2022 01:46:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=h8FBDpFF; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230092AbiIHIpQ (ORCPT + 99 others); Thu, 8 Sep 2022 04:45:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231256AbiIHIpP (ORCPT ); Thu, 8 Sep 2022 04:45:15 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13FF19E697 for ; Thu, 8 Sep 2022 01:45:13 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id 78so16038465pgb.13 for ; Thu, 08 Sep 2022 01:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=NYu0YovWqWzWdfYZiJVYYZmwb8uVVf1jRoDTIyfDYvM=; b=h8FBDpFFcNgXkreE8ybyjncZ1bCovumHhd2b49wwwvlj/0es3mwhQErjKfjw+kbNmC 5queqTF+nKn4D0pLchqbP97y6WmtzbIeU2i1QrpUgsL2833O7s3a8UP+kaXvKnbcK9wd iuVRoUNoFDrBeeqyEke5/QRmEzinsRRD+7V+MlHwCRbZUm1IHJtxSXl4dqNVE7aW3eXv FbA5sI5atywqsqltPJLX5a4XCy1lClElFsYUp/k4FIWNsK7BoVvUwMwrPvQKLdOUzrqh gtykmUCF9CV6QR/IIaRguxevPpU+hc+aDNhxw8jAzlDRUFlagR/Di7OVLBP6NmZHs9qB 4OZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=NYu0YovWqWzWdfYZiJVYYZmwb8uVVf1jRoDTIyfDYvM=; b=Yq0osPzbT0RtsX66s5KiTyinnk8L1lzvKp0XrgP9YjaToka+icBg1gPYNYTK4SXgp9 Pr9p6g9u589FhYzFIAzvHgAbJOfrvFOIFAO2Ea61jKuIt8piNtiXMJ3q2dsE2IDNOgpS +rj0DWnLwQ2mAjrFoGrISeI+rfZm/rOv3fTpJw1KNkKWx+OvM5mPklYTaOM7fmRbLprb +NiQxb2RmppV4EsmqEkE1BYHV9E1FlvCAyf7SikQCRIp3e1pdHehoTcdynXaEYBqx6Pg BDQ/c6LE/s1liJOQWpgEPc7VH+DihCj8EqWPsd487H1aLKJYEtKdpAUZdB44ZlO0qz8n 7zHA== X-Gm-Message-State: ACgBeo0itNDahgzi2BtCmRymJNPz6OHL1Ganyom2AJgMYmLBgCh24Q61 j7IbdjuEsSd7ms1C9Ponp/I= X-Received: by 2002:a65:464a:0:b0:434:883:ea21 with SMTP id k10-20020a65464a000000b004340883ea21mr7312550pgr.152.1662626712644; Thu, 08 Sep 2022 01:45:12 -0700 (PDT) Received: from localhost ([2406:7400:63:83c4:f166:555c:90a1:a48d]) by smtp.gmail.com with ESMTPSA id j18-20020a170902759200b0016c50179b1esm13795329pll.152.2022.09.08.01.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 01:45:12 -0700 (PDT) Date: Thu, 8 Sep 2022 14:15:07 +0530 From: "Ritesh Harjani (IBM)" To: Jason Yan Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, lczerner@redhat.com, linux-ext4@vger.kernel.org Subject: Re: [PATCH v2 04/13] ext4: factor out ext4_handle_clustersize() Message-ID: <20220908084507.s2wyb4gznl2vmll2@riteshh-domain> References: <20220903030156.770313-1-yanaijie@huawei.com> <20220903030156.770313-5-yanaijie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220903030156.770313-5-yanaijie@huawei.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 22/09/03 11:01AM, Jason Yan wrote: > Factor out ext4_handle_clustersize(). No functional change. > > Signed-off-by: Jason Yan > Reviewed-by: Jan Kara > --- > fs/ext4/super.c | 110 +++++++++++++++++++++++++++--------------------- > 1 file changed, 61 insertions(+), 49 deletions(-) Changes looks good to me. Reviewed-by: Ritesh Harjani (IBM)