Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp338648rwn; Thu, 8 Sep 2022 02:22:28 -0700 (PDT) X-Google-Smtp-Source: AA6agR7nqYZ/UwLANgQcTfkf25AkRmtWOItmZQgEAAL360Jv8TavL3QOflrA08Zdq8iEcOhJzcEI X-Received: by 2002:a17:90a:c901:b0:200:4a88:6722 with SMTP id v1-20020a17090ac90100b002004a886722mr3080505pjt.229.1662628948439; Thu, 08 Sep 2022 02:22:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662628948; cv=none; d=google.com; s=arc-20160816; b=VdHjshST0amFuT0Hy6pJoG+lnC0X/EmpW6An69vU/YI7eBO0wrHxwMN8bM28aBvbVO gYm5FQeil2sbdJ3Ojx9tce2IdTLRzHd+L6XiXDdR4EgxvSSRiuK/oUO7lW9MAv1aMyRu LXFkkMDPBR8AAJ7LA2LFux97tbGCXfwRdKCdDbnqeK3vUHLi7Vk6RQldCIbraAiowjwW y2IkiMDJzMBs3Jv0BzFlel8NrOJzP/JxkkmxqZg73irnzSskH70ozW/IJzHUFTaI8X5M 3A4FNpTomPQaSaCJX5ihJJXIb6toHnEXDlO4l947Moxz5pVeIMlgcHG2yWvMzvXISOfS fz4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=/qxgNeQTTfDgcvL0EKTWk+U8QhzpgFCJdugMGsDjXlw=; b=QOxXisWOmKQZAbklqEE1VPuR2d/18t6SHMLQXRuUtgtEO7qUajTW5FKMYK/iYp7SYP wVG7HKHWpd1n4fLBk784umCjNs0I/sAuG4W+m8uYbD51zSIbfDFybaI59TOLmuFUTM7U bdS7ukSW8v7YiUlE8GSys6s1B9oWbV5peTppMSkz//aZhV7UAd0z4D0Edq8vB2BDjqgk lPJ9lt4j3fuG/Fly/clOX3cdGiU2ao1C0bYU7MGVb8KfdeaDW/deU2B800dKhDDDEh/d ew1Q4tXJHd+PgvI1MR/isQ5kcq6DPXkSm+ZgnOtZgYI+sY3Bz2aRRr9f80T7YmKRHHd2 upPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=npGwxfxW; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p4-20020a170902ebc400b0016c29e43c72si19161116plg.140.2022.09.08.02.22.15; Thu, 08 Sep 2022 02:22:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=npGwxfxW; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229899AbiIHJG0 (ORCPT + 99 others); Thu, 8 Sep 2022 05:06:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231272AbiIHJGZ (ORCPT ); Thu, 8 Sep 2022 05:06:25 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FBB1A024B for ; Thu, 8 Sep 2022 02:06:24 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id jm11so17142277plb.13 for ; Thu, 08 Sep 2022 02:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=/qxgNeQTTfDgcvL0EKTWk+U8QhzpgFCJdugMGsDjXlw=; b=npGwxfxW7UWy8M0ka7LNJzaUAdJQy/CiQ2h5bYRPxvXMoeEHAhWmwJr06BrBs7e6QY GsGSepgwOXlHmgd3E0DbL6mQrXwXyEkfCVtRr91+Kg1PSXsNmzTqvN7s+ljSWOxUPwNG j6DPJsTdO/V//G6hOcPqNRB175weSlz26oUcSMx2B0q7zjRm9FV+PifCenPzm1muY+AI PauXAX1TGHyzUURZwvFRbQd1HVnHRb7Sd8UkQ/W3z7F6S4elLGm/Px3JuA24MxihV87h FYqUI2LKEZA1N91GBmo1+QAv6BebKfcwYA1stCHfhumX5A8o5PRbImrEf1DieMa1UEhU 2vWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=/qxgNeQTTfDgcvL0EKTWk+U8QhzpgFCJdugMGsDjXlw=; b=a3+bdJzIWgjLV9lJCkMliqrW1Ci8HBnfuyUdfpukvWbBdpCRd5SHGl7XHNu5KpTGKt 0XJBWFKBsEpDfm8nIJOOKNCcOUTDja35Qzg6Gt0ES5MX+ETrnXr+rcUOLgnUPOieoK55 kV2rqwmcymDxSPlNmOXQPemiqfsEYk/xiJ9pBnIlr51gFFkjlPU96bWLtXci6aXVJiPp hBL3azIuDz/tiKw7tcVdrrXWoiwJXTSHU/jXhzDAiARzRIXs/I8dg/Br0Wu6Y2Oe+plR gZe61ISX1u+1IjGktYs4dO0v8OhMozFg41P823/gQXEdjuphvZaeOfmZpMMxpQ1pU4BP 9RSw== X-Gm-Message-State: ACgBeo2iFE5XiYBSd4C+GxAxDehfrUmGP1p+sFedYDTql/ItsfksF3z5 pxX/XEm9zdga4X1b8kWIgJY= X-Received: by 2002:a17:90b:3a8e:b0:200:5585:4099 with SMTP id om14-20020a17090b3a8e00b0020055854099mr3256662pjb.70.1662627983942; Thu, 08 Sep 2022 02:06:23 -0700 (PDT) Received: from localhost ([2406:7400:63:83c4:f166:555c:90a1:a48d]) by smtp.gmail.com with ESMTPSA id w20-20020a656954000000b0043093ec77ddsm12007325pgq.29.2022.09.08.02.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 02:06:23 -0700 (PDT) Date: Thu, 8 Sep 2022 14:36:18 +0530 From: "Ritesh Harjani (IBM)" To: Jason Yan Cc: tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz, lczerner@redhat.com, linux-ext4@vger.kernel.org Subject: Re: [PATCH v2 13/13] ext4: factor out ext4_journal_data_mode_check() Message-ID: <20220908090618.k2q5ocifngd5kz4j@riteshh-domain> References: <20220903030156.770313-1-yanaijie@huawei.com> <20220903030156.770313-14-yanaijie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220903030156.770313-14-yanaijie@huawei.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 22/09/03 11:01AM, Jason Yan wrote: > Factor out ext4_journal_data_mode_check(). No functional change. > > Signed-off-by: Jason Yan > Reviewed-by: Jan Kara > --- > fs/ext4/super.c | 60 ++++++++++++++++++++++++++++--------------------- > 1 file changed, 35 insertions(+), 25 deletions(-) Looks good to me. Thanks overall for the nice refactoring. Function __ext4_fill_super() indeed looks a lot better now :) Reviewed-by: Ritesh Harjani (IBM)