Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Sep 2022 14:00:17 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Jan Kara <jack@suse.cz>,
        Ted Tso <tytso@mit.edu>
Cc:     lkp@intel.com, kbuild-all@lists.01.org, linux-ext4@vger.kernel.org,
        Thorsten Leemhuis <regressions@leemhuis.info>,
        Ojaswin Mujoo <ojaswin@linux.ibm.com>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        Jan Kara <jack@suse.cz>
Subject: Re: [PATCH 5/5] ext4: Use buckets for cr 1 block scan instead of
 rbtree
Message-ID: <202209071206.u1iHKVzB-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220906152920.25584-5-jack@suse.cz>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8LsMtJne8nX3+pqShR6lf9boVF94HgDPp8qnP56XOATY64EwixFpqrmDiPRz?=
 =?us-ascii?Q?5HXonazz9KQYpXOqDkfJO0ZslUrtkwgqbUHn5/NNxvkpmrOmmB7KN9aFPJ8G?=
 =?us-ascii?Q?/XCt7j773CbjU9tJZyTVi853/PGLolPukK47mpKkTCUVMXD1XKwHZ5+RylSA?=
 =?us-ascii?Q?oI5rSghR5+etoOyUWai2NtOpPzks3zZLMmlz+b3vM37YvFHSsuvgs3j8kJ20?=
 =?us-ascii?Q?k8uSZT8TBFtJ702Zcryt/vsotV5tmaf2LWoeo+LevbYsUYhd8LodPcsXVYlR?=
 =?us-ascii?Q?Tmo+gQq2uvoySnLd0R1qPdVwLfGdSQV3vhJOEpqfUVk8gvRX0oIw5SEbX1uH?=
 =?us-ascii?Q?1sVHqq/7V7ke26tRqyT3hbp8U4XB1e3EH+g4WQhexSGujFsfqybpOePBiMim?=
 =?us-ascii?Q?ZcF1Dg3NVUzJVmyKcSrQdNE1YLT4GJB1mn+/8VHzBd/UBppjM+Upo22Xx86d?=
 =?us-ascii?Q?QmCq/swi29Kp7d5Sb9qIX0yx64g+QobB6L2XNdjEEn9sonGa5gGEP9V9sRgY?=
 =?us-ascii?Q?2LNFC9DNNvWDYHUMG24eBmorGfok4gRZ/t0Nk3vOwxRKRECFcAtIumx0zgoT?=
 =?us-ascii?Q?1UfLjk41ldEiIKJ9WWnBfIUbUdYYN0+0w/q9ZQT4cga9tc5oyw0UuSSglWxA?=
 =?us-ascii?Q?g1Cj7j+mfQI3U9PEy4UYmDGbgfgjHnaolJANkbDFpFLwsNiS0BD5BBBiruEK?=
 =?us-ascii?Q?kaSs/GkSTYiZLUWPKBsF6pi3JjT6plw8nngvs2xkDPfTkdYjgH8PVul5EHsY?=
 =?us-ascii?Q?GzHeREOk6WkdMLWk2gapw06ceoxbfVkYoE7wFaCb3OD16KSqceUTg2Kb2/Pq?=
 =?us-ascii?Q?ByGzgxfL97+peZNKhJPy+yBpdmxPwOzSATfvOkhI7MvCjNTQGpI7H73QPdGe?=
 =?us-ascii?Q?vJLRSy4cp9HLQomJT72oPS3ftpvhEQ/cLeYOgF5hMcMSMOmZ57LTEy+xX6yt?=
 =?us-ascii?Q?YRaTdxhuIixmqAMnUCMmOdXzDsPx62N9ddpfoheS/OLutz+r+mz0rrbgCh65?=
 =?us-ascii?Q?aUoYPwiM5G96SKZbF2o+UyMNkzxQQkwoHEpLANHDNumqAYoNtyFXSlyiZ4vc?=
 =?us-ascii?Q?1AB/9fpVGJ2LflR7X1pNjkZlMNdevGhjhig2diiFAy1m3icKCt02A7hKHhUx?=
 =?us-ascii?Q?0ZUaxUddiS+f+fyskppMXfOO01qjsxrG7RD6ZH7H3zOjhyxqlustgwc/IwQm?=
 =?us-ascii?Q?hEkcQPvkWFwRqsnW3cx/N6xaVJEyJGpIvtZi69eEChseLRFpi5P2r4kgWUcT?=
 =?us-ascii?Q?LZH45pnurp8ZyCk9IHyDKvGP1TcfeYZWz4QFw533kkqvOf0wW+mx39SDDLzE?=
 =?us-ascii?Q?9rVwaSkOHhfo8OoR+jEdgdus4nDcMZTsiYQFvqbBVcNeg9jtLVp1B3VfLYhq?=
 =?us-ascii?Q?9y0yOwwkvZZdVixrFvHMoATgXd3qBd4ZTgUkn9LaVDa4/TN2qS1O+ZFQhSXA?=
 =?us-ascii?Q?rT6q2LE+Jlis3wVRmf9bOi2t96d2NUetIXLed1kYokU8rwAGMxXGR1jIOZsK?=
 =?us-ascii?Q?Fn2K8Esfu5LSqwBoaJd41peg3dHmCIhRbmY/WFrA0INYSyM0z2dO0mdQ9eoP?=
 =?us-ascii?Q?2YuKO1z5igUZWh/0tsLkZV8TX1H2amZP9sLexvb2P+JACXBRXDcOAqMK7p0u?=
 =?us-ascii?Q?vw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5c1f714-ee25-4b8a-b1db-08da9189549f
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Sep 2022 11:00:28.0142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6/bVX1Z7+6BoYqEDqRp8bQGzkIgGLb0jjRBxiMNIZBNbpklei2kY5HLKNRR5fq3W/3enij0thR20Jq1WSw4ocZ0wjyZ7IUMg+k8CyeP7Akg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4294
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1
 definitions=2022-09-08_06,2022-09-07_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0
 mlxscore=0 phishscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000
 definitions=main-2209080040
X-Proofpoint-ORIG-GUID: JfFmq1ivyRq2DVmbrPCIXahFjaWrchxa
X-Proofpoint-GUID: JfFmq1ivyRq2DVmbrPCIXahFjaWrchxa
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

Hi Jan,

https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jan-Kara/ext4-Fix-performance-regression-with-mballoc/20220907-000945
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 53e99dcff61e1523ec1c3628b2d564ba15d32eb7
config: m68k-randconfig-m041-20220906 (https://download.01.org/0day-ci/archive/20220907/202209071206.u1iHKVzB-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

New smatch warnings:
fs/ext4/mballoc.c:945 ext4_mb_choose_next_group_cr1() error: uninitialized symbol 'grp'.

vim +/grp +945 fs/ext4/mballoc.c

196e402adf2e4c Harshad Shirwadkar 2021-04-01  909  static void ext4_mb_choose_next_group_cr1(struct ext4_allocation_context *ac,
196e402adf2e4c Harshad Shirwadkar 2021-04-01  910  		int *new_cr, ext4_group_t *group, ext4_group_t ngroups)
196e402adf2e4c Harshad Shirwadkar 2021-04-01  911  {
196e402adf2e4c Harshad Shirwadkar 2021-04-01  912  	struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
31b571b608cf66 Jan Kara           2022-09-06  913  	struct ext4_group_info *grp, *iter;
31b571b608cf66 Jan Kara           2022-09-06  914  	int i;
196e402adf2e4c Harshad Shirwadkar 2021-04-01  915  
196e402adf2e4c Harshad Shirwadkar 2021-04-01  916  	if (unlikely(ac->ac_flags & EXT4_MB_CR1_OPTIMIZED)) {
196e402adf2e4c Harshad Shirwadkar 2021-04-01  917  		if (sbi->s_mb_stats)
196e402adf2e4c Harshad Shirwadkar 2021-04-01  918  			atomic_inc(&sbi->s_bal_cr1_bad_suggestions);
31b571b608cf66 Jan Kara           2022-09-06  919  	}
31b571b608cf66 Jan Kara           2022-09-06  920  
31b571b608cf66 Jan Kara           2022-09-06  921  	for (i = mb_avg_fragment_size_order(ac->ac_sb, ac->ac_g_ex.fe_len);
31b571b608cf66 Jan Kara           2022-09-06  922  	     i < MB_NUM_ORDERS(ac->ac_sb); i++) {
31b571b608cf66 Jan Kara           2022-09-06  923  		if (list_empty(&sbi->s_mb_avg_fragment_size[i]))
31b571b608cf66 Jan Kara           2022-09-06  924  			continue;
31b571b608cf66 Jan Kara           2022-09-06  925  		read_lock(&sbi->s_mb_avg_fragment_size_locks[i]);
31b571b608cf66 Jan Kara           2022-09-06  926  		if (list_empty(&sbi->s_mb_avg_fragment_size[i])) {
31b571b608cf66 Jan Kara           2022-09-06  927  			read_unlock(&sbi->s_mb_largest_free_orders_locks[i]);
31b571b608cf66 Jan Kara           2022-09-06  928  			continue;

Smatch worries that we can hit these two continues on every iteration.
Why not just initialize "grp = NULL;" at the start of the function?

31b571b608cf66 Jan Kara           2022-09-06  929  		}
31b571b608cf66 Jan Kara           2022-09-06  930  		grp = NULL;
31b571b608cf66 Jan Kara           2022-09-06  931  		list_for_each_entry(iter, &sbi->s_mb_avg_fragment_size[i],
31b571b608cf66 Jan Kara           2022-09-06  932  				    bb_avg_fragment_size_node) {
196e402adf2e4c Harshad Shirwadkar 2021-04-01  933  			if (sbi->s_mb_stats)
196e402adf2e4c Harshad Shirwadkar 2021-04-01  934  				atomic64_inc(&sbi->s_bal_cX_groups_considered[1]);
31b571b608cf66 Jan Kara           2022-09-06  935  			if (likely(ext4_mb_good_group(ac, iter->bb_group, 1))) {
31b571b608cf66 Jan Kara           2022-09-06  936  				grp = iter;
196e402adf2e4c Harshad Shirwadkar 2021-04-01  937  				break;
196e402adf2e4c Harshad Shirwadkar 2021-04-01  938  			}
196e402adf2e4c Harshad Shirwadkar 2021-04-01  939  		}
31b571b608cf66 Jan Kara           2022-09-06  940  		read_unlock(&sbi->s_mb_avg_fragment_size_locks[i]);
31b571b608cf66 Jan Kara           2022-09-06  941  		if (grp)
31b571b608cf66 Jan Kara           2022-09-06  942  			break;
196e402adf2e4c Harshad Shirwadkar 2021-04-01  943  	}
196e402adf2e4c Harshad Shirwadkar 2021-04-01  944  
31b571b608cf66 Jan Kara           2022-09-06 @945  	if (grp) {
196e402adf2e4c Harshad Shirwadkar 2021-04-01  946  		*group = grp->bb_group;
196e402adf2e4c Harshad Shirwadkar 2021-04-01  947  		ac->ac_flags |= EXT4_MB_CR1_OPTIMIZED;
196e402adf2e4c Harshad Shirwadkar 2021-04-01  948  	} else {
196e402adf2e4c Harshad Shirwadkar 2021-04-01  949  		*new_cr = 2;
196e402adf2e4c Harshad Shirwadkar 2021-04-01  950  	}
196e402adf2e4c Harshad Shirwadkar 2021-04-01  951  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp