Received: by 2002:a05:6358:489b:b0:bb:da1:e618 with SMTP id x27csp1497815rwn; Thu, 8 Sep 2022 22:09:21 -0700 (PDT) X-Google-Smtp-Source: AA6agR6SPnmqYcnzAWn7dtqlnipYL00bBARXxDrqSk1PB0WTt1gO/c1U6YZyYZFM/dQa59EzP/WL X-Received: by 2002:a2e:b894:0:b0:25e:cb1f:365d with SMTP id r20-20020a2eb894000000b0025ecb1f365dmr3277748ljp.285.1662700160901; Thu, 08 Sep 2022 22:09:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662700160; cv=none; d=google.com; s=arc-20160816; b=FDR/94c3plcnUU4T0Kwj4jWI+wCEEBMrSofiG51kEKxnSJ29Lh0nx4Kd7UaCj0jbVh cefq/HidQdixadt9Za606UOiFKTXlm5/IKR3oEpWMJn2CRB7+SJzcA8WZVR+/ZRschAa REzMod0gHYLECGYAhXYHv01djonVPkI4PkqJXSO0CLSe3AzgRKKnAdU0L3KqrPrRpz8n JOMlH2VzeU/UiyjySPYU/WIzsWi6DC9XDmeJs/OE/OyqP6RSPg1vzQqqchYYMfkEk4mj dkGJLBsIDcMXJUBsBvZjD530mBUrotgRT3Q3Qs4F9tqindcvGiJqXZbsr2Q2QtL+BaDl lD8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=lHZr0z2LaLA2aH4nw3OWnSW2OW5stN7F6o9WPdifs2Q=; b=aQEqKCOgquwmeWell2w2t6xwIURKUUSdq95kXeWlJYuzlo56NtJxQn4qax0EXgwEXi fOHVErEmdSMKUVniekPud3UOuhWmUVSK/lnfK4zzxeCiNfZRUT2mVbLT8F39INm5h6Ll OzVF9XYrwyAUZdipIKYNQTyuph0XLrVBUFd4nFEfTB/CMOqYmiIY7E9CWlAWaxVMykAQ SZyhGVXCj/C89mlqvv07DI8Mpf5fNm3uV1k67QD/H3oEeu9I8ZdMPbxPv6ksrcFnanJO dIiFDZP281W2F33vEjJTMj1Vjj08QIceHbBs/PqQRqrdX33bqo6yx5gWBhZiklpQI5o9 ktdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JPt7BVVL; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r23-20020a2e8e37000000b0026aceea573asi382785ljk.50.2022.09.08.22.08.45; Thu, 08 Sep 2022 22:09:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=JPt7BVVL; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229955AbiIIEsJ (ORCPT + 99 others); Fri, 9 Sep 2022 00:48:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbiIIErv (ORCPT ); Fri, 9 Sep 2022 00:47:51 -0400 Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 324DD115CEB; Thu, 8 Sep 2022 21:47:51 -0700 (PDT) Received: by mail-pg1-x52c.google.com with SMTP id t70so509376pgc.5; Thu, 08 Sep 2022 21:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=lHZr0z2LaLA2aH4nw3OWnSW2OW5stN7F6o9WPdifs2Q=; b=JPt7BVVLiWpv8FRMD5jPZLIap87tuPuddsllLwJ3vRD3MYlgfnuTR3f/e2IvPA0Ep+ L4F1Gz5voEo/yTh4wR6FDSf3op9z44N+RyGdB8ubOioBV7nRIZ2WbObOT05B7jkMOrQN d0bkiefZm0PPodSP8Cwmw1Ul4M5qiTre/6il95ufBcW27HviZuJ1s4NjCi0nSOrYB/sA EeEqAcGXaDCE645bJbrAAe5Ofbvx8WKjdFLjwUwJyaR8vm2n60NUiCTnFud500qzi2+w UcIGEMhiIdOFGsD88aIzEkTxyO6wU7Uc5CoKJq65rb3Ky0eKxmkdsUh6SFcqeJE7vG05 BRbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=lHZr0z2LaLA2aH4nw3OWnSW2OW5stN7F6o9WPdifs2Q=; b=1G7fvZJfovAdkuuF+xm9e+zr17ifrAPosWekNybW2O/DT7+UzXiC0v4qlbnu+SjWh0 qy9pyRsllwmFLRxIOxs2BmPVT+YcsigDnNaeJrPLnobJTQBAKTyfjT0171e/WpYPIdK8 RUnHH/vdiirMPZnI0HpLCGDZ6w142hs5pUHEcVXsd/jCYlyuH826CkDylb27ngq+CmKa Z+//JvDs6V6SNAXGZfJKI7QIkcTeQ991Ru3tIWwnUoWeuHfJA5CUMBAgLE68W7Zp2siR 2sPg6WCD75MSnrBMLjlPJuLFNsNYmHrtE15Z5FZVLTY3d+fm8iDKc0ukJMZYtT0DkBPH E7bg== X-Gm-Message-State: ACgBeo1uqdQZHtCcZV3Lkv6vOF//R//iqlmcuOW9skVEqDFIH4z6HEUQ wAjC4X95qJKo4LQG+y0Z50bbhwKJgLCsQA== X-Received: by 2002:a05:6a00:2918:b0:536:3967:5d08 with SMTP id cg24-20020a056a00291800b0053639675d08mr12216948pfb.68.1662698870300; Thu, 08 Sep 2022 21:47:50 -0700 (PDT) Received: from localhost.localdomain (lily-optiplex-3070.dynamic.ucsd.edu. [2607:f720:1300:3033::1:4dd]) by smtp.googlemail.com with ESMTPSA id bf23-20020a656d17000000b00434a2b8ab1esm330313pgb.73.2022.09.08.21.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 21:47:49 -0700 (PDT) From: Li Zhong To: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org Cc: adilger.kernel@dilger.ca, tytso@mit.edu, Li Zhong Subject: [PATCH v1] fs/ext4/xattr: check the return value of ext4_xattr_inode_dec_ref() Date: Thu, 8 Sep 2022 21:47:27 -0700 Message-Id: <20220909044727.2622256-1-floridsleeves@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Check the return value of ext4_xattr_inode_dec_ref(), which could return error code and need to be warned. Signed-off-by: Li Zhong --- fs/ext4/xattr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index 533216e80fa2..76141ed12bc2 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1540,7 +1540,9 @@ static int ext4_xattr_inode_lookup_create(handle_t *handle, struct inode *inode, err = ext4_xattr_inode_write(handle, ea_inode, value, value_len); if (err) { - ext4_xattr_inode_dec_ref(handle, ea_inode); + err = ext4_xattr_inode_dec_ref(handle, ea_inode); + if (err) + ext4_warning_inode(ea_inode, "cleanup dec ref error %d", err); iput(ea_inode); return err; } -- 2.25.1