Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     liuzhiqiang26@huawei.com, linux-ext4@vger.kernel.org,
        adilger@whamcloud.com, zhanchengbin1@huawei.com
Cc:     "Theodore Ts'o" <tytso@mit.edu>, wuguanghao3@huawei.com,
        linfeilong@huawei.com
Subject: Re: [PATCH] tune2fs: fix tune2fs segfault when ext2fs_run_ext3_journal() fails
Date:   Mon, 12 Sep 2022 07:55:14 -0400
Message-Id: <166298370796.2551439.6275034691916615030.b4-ty@mit.edu>
In-Reply-To: <8e87fbc3-674a-af30-1234-54b36eb5ca5d@huawei.com>
References: <8e87fbc3-674a-af30-1234-54b36eb5ca5d@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 5 Sep 2022 19:16:03 +0800, Zhiqiang Liu wrote:
> When ext2fs_run_ext3_journal() fails, tune2fs cmd will occur one
> segfault problem as follows.
> (gdb) bt
> #0  0x00007fdadad69917 in ext2fs_mmp_stop (fs=0x0) at mmp.c:405
> #1  0x0000558fa5a9365a in main (argc=<optimized out>, argv=<optimized out>) at tune2fs.c:3440
> 
> misc/tune2fs.c:
> main()
>   -> ext2fs_open2(&fs)
>     -> ext2fs_mmp_start
>   ......
>   -> retval = ext2fs_run_ext3_journal(&fs)
>   -> if (retval)
>     // if ext2fs_run_ext3_journal fails, close and free fs.
>     -> ext2fs_close_free(&fs)
>     -> rc = 1
>     -> goto closefs
>   ......
> closefs:
>   -> if (rc)
>     -> ext2fs_mmp_stop(fs)     // fs has been set to NULL, boom!!
>   -> (ext2fs_close_free(&fs) ? 1 : 0); // close and free fs
> 
> [...]

Applied, thanks!

[1/1] tune2fs: fix tune2fs segfault when ext2fs_run_ext3_journal() fails
      commit: 66ecb6abe5d2c74191bb4bc24f3da036e5fa1213

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>